Page MenuHomePhabricator
Differential D12253

[sqlite] implement logic to get message store logic from SQLite
ClosedPublic
Actions

Authored by will on May 30 2024, 2:13 PM.
Tags
None
Referenced Files
F3512958: D12253.id41162.diff
Sat, Dec 21, 9:18 PM
F3512928: D12253.id40796.diff
Sat, Dec 21, 9:02 PM
F3509969: D12253.diff
Sat, Dec 21, 9:51 AM
Unknown Object (File)
Wed, Dec 18, 6:35 AM
Unknown Object (File)
Wed, Dec 18, 6:35 AM
Unknown Object (File)
Wed, Dec 18, 6:35 AM
Unknown Object (File)
Wed, Dec 18, 6:35 AM
Unknown Object (File)
Wed, Dec 18, 6:34 AM
View All 95 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
ginsu
Commits
rCOMM311602b156e7: [sqlite] implement logic to get message store logic from SQLite
Summary

Selects message store local data in C++ from SQLite

Depends on D12249

Test Plan

Logged the result and verified with SQLite table. Tested further in stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.May 30 2024, 2:13 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 30 2024, 2:13 PM
Harbormaster completed remote builds in B29321: Diff 40796.May 30 2024, 2:30 PM
will requested review of this revision.May 30 2024, 2:30 PM
tomek accepted this revision.Jun 3 2024, 4:42 AM

Depends on https://phab.comm.dev/D12249

Setting a dependency on the URL doesn't work - we have to use just the diff id D12249

This revision is now accepted and ready to land.Jun 3 2024, 4:42 AM
will edited the summary of this revision. (Show Details)Jun 3 2024, 4:44 AM
will added a parent revision: D12249: [sqlite] Implement C++ message store local ops.
In D12253#349092, @tomek wrote:

Depends on https://phab.comm.dev/D12249

Setting a dependency on the URL doesn't work - we have to use just the diff id D12249

Thanks for catching that

ginsu added a child revision: D12357: [web] handle message store local ops types in processMessageStoreOperations.Jun 7 2024, 4:50 PM
will updated this revision to Diff 41161.Jun 10 2024, 5:16 AM

rebase before landing

will updated this revision to Diff 41162.Jun 10 2024, 5:29 AM

fix prior rebase

Harbormaster completed remote builds in B29573: Diff 41161.Jun 10 2024, 5:33 AM
Harbormaster completed remote builds in B29574: Diff 41162.Jun 10 2024, 5:46 AM
Closed by commit rCOMM311602b156e7: [sqlite] implement logic to get message store logic from SQLite (authored by will). · Explain WhyJun 10 2024, 5:57 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM311602b156e7: [sqlite] implement logic to get message store logic from SQLite.

Revision Contents
Changeset List

PathSize
lib/
reducers/
1 line
types/
4 lines
native/
cpp/
CommonCpp/
NativeModules/
15 lines
PersistentStorageUtilities/
DataStores/
19 lines
web/
shared-worker/
utils/
1 line
worker/
2 lines

Diff 41163

View Options

lib/reducers/message-reducer.test.js

Loading...
View Options

lib/types/store-ops-types.js

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageStore.cpp

Loading...
View Options

web/shared-worker/utils/store.js

Loading...
View Options

web/shared-worker/worker/process-operations.js

Loading...