Page MenuHomePhabricator

[lib] Modify the approach to handling invite link acceptance
ClosedPublic

Authored by tomek on Jun 13 2024, 5:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 8:37 AM
Unknown Object (File)
Thu, Nov 28, 8:34 AM
Unknown Object (File)
Thu, Nov 28, 5:59 AM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
Unknown Object (File)
Fri, Nov 1, 8:15 PM
Unknown Object (File)
Oct 30 2024, 12:06 AM
Subscribers

Details

Summary

Later in the stack we need to join two threads which requires dispatching two success actions - something not possible in the current approach where we create a promise and pass it to a single dispatchActionPromise. In this new approach, we call dispatchActionPromise in an effect which allows adding the second effect later in the stack.

Note: this diff breaks a loading status. It is fixed in the next diff where steps are introduced. This approach is more efficient than fixing it in this diff.

https://linear.app/comm/issue/ENG-8250/join-a-thread-after-joining-a-community

Depends on D12422

Test Plan

Tested in combination with the rest of the stack by checking if joining a community link works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable