Page MenuHomePhabricator

[lib] Join a thread from an invite link
ClosedPublic

Authored by tomek on Jun 13 2024, 5:58 AM.
Tags
None
Referenced Files
F3361072: D12425.id41282.diff
Sun, Nov 24, 3:10 PM
F3360487: D12425.diff
Sun, Nov 24, 12:50 PM
Unknown Object (File)
Fri, Nov 1, 12:14 PM
Unknown Object (File)
Fri, Nov 1, 12:14 PM
Unknown Object (File)
Fri, Nov 1, 12:14 PM
Unknown Object (File)
Fri, Nov 1, 12:14 PM
Unknown Object (File)
Oct 22 2024, 10:06 PM
Unknown Object (File)
Oct 19 2024, 9:35 PM
Subscribers

Details

Summary

After joining a community, we check if a link is a thread link and join a thread if necessary.

https://linear.app/comm/issue/ENG-8250/join-a-thread-after-joining-a-community

Depends on D12424

Test Plan

Tested following cases:

  1. Accepting a community link when a user isn't a member of the community
  2. Accepting a thread link when a user isn't a member of the community
  3. Accepting a thread link when a user is a member of the community and isn't a member of the thread
  4. Clicking a community link when a user is a member of the community
  5. Clicking a thread link when a user is a member of the thread
  6. Clicking an invalid link
  7. Accepting a thread link when a user isn't a member of the community with a modification on the server side so that joining a thread fails. This results in joining the community and a modal with This invite link may be expired. Please try again with another invite link. message.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable