Page MenuHomePhabricator

[lib] improve handling Tunnelbroker socket state
ClosedPublic

Authored by kamil on Jun 14 2024, 5:37 AM.
Tags
None
Referenced Files
F3362976: D12440.diff
Sun, Nov 24, 11:38 PM
Unknown Object (File)
Sat, Nov 23, 9:02 PM
Unknown Object (File)
Sun, Nov 10, 12:38 PM
Unknown Object (File)
Fri, Nov 1, 1:47 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Subscribers

Details

Summary

Previously there was an edge case:

  1. Tunnelbroker socket state is connected: true and isAuthorized: false
  2. After calling setUnauthorizedDeviceID(false) the state is connected: true and isAuthorized: true, but the connection is still opened using the unauthorized type
  3. Next, the socket is closed and the state is connected: false and isAuthorized: true
  4. After the authenticating socket is in state connected: true and isAuthorized: true

As you can see - both 2 and 4 return the same result, but point 2 is not correct. This diff fixes this.

This bug can cause issues described in ENG-8385

Test Plan

Test switching from unauthorized to authorized session

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable