Page MenuHomePhabricator

[native] introduce disabled prop for EnumSettingsOption
ClosedPublic

Authored by ginsu on Jul 3 2024, 5:31 PM.
Tags
None
Referenced Files
F3581959: D12653.id42069.diff
Sun, Dec 29, 9:53 AM
F3575062: D12653.diff
Sat, Dec 28, 6:11 PM
Unknown Object (File)
Tue, Dec 17, 4:59 PM
Unknown Object (File)
Mon, Dec 16, 7:21 PM
Unknown Object (File)
Sun, Dec 15, 2:36 PM
Unknown Object (File)
Nov 11 2024, 3:34 AM
Unknown Object (File)
Nov 11 2024, 1:28 AM
Unknown Object (File)
Nov 10 2024, 2:16 PM
Subscribers

Details

Summary

For the new thread notifications settings we will need to be able to disable the input. This diff introduces the disabled prop to EnumSettingsOption in anticipation of this

example of disabled input:

Screenshot 2024-07-03 at 8.32.46 PM.png (2×3 px, 945 KB)

Depends on D12645

Test Plan

Please see screenshots below

Screenshot 2024-07-03 at 8.34.47 PM.png (1×944 px, 588 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Jul 3 2024, 5:47 PM
This revision is now accepted and ready to land.Jul 3 2024, 8:16 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing