Paths

Table of Contentst

Differential D12647

[native] introduce barebones UI for ThreadSettingsNotifications
ClosedPublic
Actions

Authored by ginsu on Wed, Jul 3, 1:11 AM.

Tags

None

Referenced Files

	F2235247: D12647.id41931.diff
	Thu, Jul 11, 12:06 AM

	F2232844: D12647.id42050.diff
	Wed, Jul 10, 5:31 PM

	F2230997: D12647.id41993.diff
	Wed, Jul 10, 12:16 PM

	F2230546: D12647.id42051.diff
	Wed, Jul 10, 11:05 AM

	Unknown Object (File)
	Mon, Jul 8, 5:34 PM

	Unknown Object (File)
	Mon, Jul 8, 7:28 AM

	F2184503: Screen Recording 2024-07-04 at 12.18.06 AM.mov
	Wed, Jul 3, 9:20 PM

	Unknown Object (File)
	Wed, Jul 3, 11:53 AM

View All 11 Files

Subscribers

Details

Reviewers

ashoat
inka

Commits

rCOMM769fcab17eac: [native] introduce barebones UI for ThreadSettingsNotifications

Summary

This diff introduces the barebones UI for ThreadSettingsNotifications. I know that there were visual changes requested in D12643, so this will also probably also need to be updated, but given that I am leaving soon, I want to get this out sooner rather than later

Depends on D12661

Test Plan

Please see the demo video below: (Please note the red block at the end is just something in my local stack and has not been included in any diffs)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Wed, Jul 3, 1:11 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Jul 3, 1:11 AM

ginsu edited the summary of this revision. (Show Details)Wed, Jul 3, 1:16 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, inka.

ginsu added a parent revision: D12646: [lib/web] introduce useThreadSettingsNotifications.

ginsu attached a referenced file: F2174800: Screen Recording 2024-07-03 at 4.13.35 AM.mov. (Show Details)

ginsu added a child revision: D12648: [native] introduce NotificationDescription.Wed, Jul 3, 1:24 AM

Harbormaster completed remote builds in B30076: Diff 41930.Wed, Jul 3, 1:27 AM

ginsu requested review of this revision.Wed, Jul 3, 1:27 AM

inka accepted this revision.Wed, Jul 3, 2:49 AM

This revision is now accepted and ready to land.Wed, Jul 3, 2:49 AM

ashoat mentioned this in D12646: [lib/web] introduce useThreadSettingsNotifications.Wed, Jul 3, 6:55 AM

ginsu removed a parent revision: D12646: [lib/web] introduce useThreadSettingsNotifications.Wed, Jul 3, 3:06 PM

update

ginsu edited the test plan for this revision. (Show Details)Wed, Jul 3, 9:20 PM

ginsu attached a referenced file: F2184503: Screen Recording 2024-07-04 at 12.18.06 AM.mov. (Show Details)

Harbormaster completed remote builds in B30122: Diff 41993.Wed, Jul 3, 9:50 PM

ginsu edited the summary of this revision. (Show Details)Wed, Jul 3, 10:09 PM

ginsu added a parent revision: D12661: [lib/native/web] factor out remaining shared logic + copy for thread notification settings.

ginsu removed a parent revision: D12646: [lib/web] introduce useThreadSettingsNotifications.

rebase before landing

This revision was landed with ongoing or failed builds.Thu, Jul 4, 11:21 AM

Closed by commit rCOMM769fcab17eac: [native] introduce barebones UI for ThreadSettingsNotifications (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM769fcab17eac: [native] introduce barebones UI for ThreadSettingsNotifications.

Harbormaster completed remote builds in B30159: Diff 42050.Thu, Jul 4, 11:24 AM

Revision Contents
Changeset List

Path

Size

native/

chat/

settings/

thread-settings-notifications.react.js

110 lines

Diff 41993

native/chat/settings/thread-settings-notifications.react.js

Loading...