Currently the ThreadSettingsPushNotifs component renders a switch that the user can use to update their notif settings. We should update ThreadSettingsPushNotifs to instead navigate to our new thread settings notifications screen
Depends on D12664
Details
Details
Please see the demo video below
When hasPushPermissions is true:
When hasPushPermissions is false:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/chat/settings/thread-settings-push-notifs.react.js | ||
|---|---|---|
| 48–50 ↗ | (On Diff #42001) | This constructor can be removed now. It's not doing anything except calling its parent. If it's not defined, the parent will be called anyways |
| 60–66 ↗ | (On Diff #42001) | Let's avoid ternary like this. See point 3 here Instead I think it would be cleaner to assign two variables and render both below: let editSettingsButton, notifSettingsLinkingButton; if (this.props.hasPushPermissions) { editSettingsButton = ( <EditSettingButton onPress={this.onPressEditThreadNotificationSettings} /> ); } else { notifSettingsLinkingButton = ( <TouchableOpacity onPress={this.onNotificationsSettingsLinkingIconPress}> <SWMansionIcon name="info-circle" size={20} color="gray" /> </TouchableOpacity> ); } |