Page MenuHomePhabricator
Differential D12737

[SQLite] Introduce getRelatedMessages
ClosedPublic
Actions

Authored by ashoat on Jul 14 2024, 6:08 PM.
Tags
None
Referenced Files
F3367913: D12737.diff
Mon, Nov 25, 5:09 PM
Unknown Object (File)
Wed, Nov 20, 2:25 PM
Unknown Object (File)
Wed, Nov 20, 2:25 PM
Unknown Object (File)
Tue, Nov 5, 3:22 AM
Unknown Object (File)
Oct 18 2024, 10:29 PM
Unknown Object (File)
Oct 18 2024, 10:24 PM
Unknown Object (File)
Oct 14 2024, 1:34 PM
Unknown Object (File)
Sep 25 2024, 8:25 PM
View All 34 Files
Subscribers
None

Details

Reviewers
kamil
tomek
marcin
Commits
rCOMMae2fd4b4f144: [SQLite] Introduce getRelatedMessages
Summary

I'm modelling this stack after @kamil's recent one (see D12080) that introduced functions to SQLiteAPI. First I'm introducing the shared SQLite C++ code, and then I will introduce the layers on native and web that will interact with it. This diff also contains some web-specific customizations necessary on the SQLite C++ code.

This query will be used for:

  1. Querying for a sidebar source's latest edit at sidebar creation time (ENG-8788)
  2. Querying for a messages edits and reactions for search results (ENG-87890)
Test Plan
  1. In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
  2. I tested a message ID that did not exist and confirmed I got undefined back

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jul 14 2024, 6:08 PM
ashoat edited the summary of this revision. (Show Details)Jul 14 2024, 6:10 PM
ashoat added a child revision: D12738: [web] Introduce getRelatedMessages to shared worker.Jul 14 2024, 6:11 PM
Harbormaster completed remote builds in B30310: Diff 42270.Jul 14 2024, 6:24 PM
ashoat requested review of this revision.Jul 14 2024, 6:24 PM
marcin accepted this revision.Jul 15 2024, 2:52 AM
This revision is now accepted and ready to land.Jul 15 2024, 2:52 AM
ashoat removed a parent revision: D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling.Jul 15 2024, 4:46 PM
ashoat added a parent revision: D12735: [native] Introduce MessageEntity type alias in more places.Jul 15 2024, 7:00 PM
ashoat retitled this revision from [SQLite] Introduce getLatestMessageEdit to [SQLite] Introduce getRelatedMessages.
ashoat edited the summary of this revision. (Show Details)
ashoat added a parent revision: D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling.
ashoat edited the summary of this revision. (Show Details)Jul 15 2024, 7:02 PM
ashoat removed a parent revision: D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling.
ashoat edited the test plan for this revision. (Show Details)
ashoat edited parent revisions, added: D12760: [SQLite] Factor out SQLiteQueryExecutor::processMessagesResults; removed: D12735: [native] Introduce MessageEntity type alias in more places.Jul 15 2024, 7:08 PM
ashoat updated this revision to Diff 42309.Jul 15 2024, 7:13 PM

Rework into getRelatedMessages, which can be reused for rendering search results

Harbormaster completed remote builds in B30347: Diff 42309.Jul 15 2024, 7:34 PM
Closed by commit rCOMMae2fd4b4f144: [SQLite] Introduce getRelatedMessages (authored by ashoat). · Explain WhyJul 16 2024, 6:46 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMae2fd4b4f144: [SQLite] Introduce getRelatedMessages.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
4 lines
4 lines
35 lines
web/
cpp/
5 lines
shared-worker/
_generated/
types/
12 lines

Diff 42309

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...