Differential D12827

[lib] Reduce duplication in message-types.js
ClosedPublic
Actions

Authored by ashoat on Jul 21 2024, 4:41 AM.

Tags

None

Referenced Files

	F32171419: D12827.1765060697.diff
	Fri, Dec 5, 10:38 PM

Subscribers

None

Details

Reviewers

tomek
kamil
marcin

Commits

rCOMMfa1d5228f1a2: [lib] Reduce duplication in message-types.js

Summary

Noticed the same two properties being redefined in a bunch of types. Figured it made sense to factor it out.

Depends on D12826

Test Plan

Flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jul 21 2024, 4:41 AM

ashoat added a child revision: D12828: [lib] Make sure thick threads starts out with startReached.

Harbormaster completed remote builds in B30546: Diff 42593.Jul 21 2024, 4:58 AM

ashoat requested review of this revision.Jul 21 2024, 4:58 AM

tomek accepted this revision.Jul 22 2024, 10:30 AM

This revision is now accepted and ready to land.Jul 22 2024, 10:30 AM

Closed by commit rCOMMfa1d5228f1a2: [lib] Reduce duplication in message-types.js. · Explain WhyJul 22 2024, 4:29 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfa1d5228f1a2: [lib] Reduce duplication in message-types.js.

Revision Contents
Changeset List

Path

Size

lib/

types/

message-types.js

28 lines

Diff 42593

lib/types/message-types.js

Loading...