[native][web] Add a timestamp column to threads table
ClosedPublic
Actions

Authored by tomek on Aug 30 2024, 6:37 AM.

Details

Reviewers

kamil
inka

Commits

rCOMM9d16076365c5: [native][web] Add a timestamp column to threads table

Summary

Create a new column where timestamps are stored.

https://linear.app/comm/issue/ENG-8751/add-a-timestamps-property-to-a-thick-thread-info

Test Plan

On native and web check if the migration succeeds. Also, clear the db and run the app to make sure creating new schema works.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 30 2024, 6:37 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 30 2024, 6:37 AM

Harbormaster completed remote builds in B31371: Diff 43815.Aug 30 2024, 6:57 AM

tomek requested review of this revision.Aug 30 2024, 6:57 AM

Fix the mapping

tomek added a child revision: D13214: [lib] Introduce thread timestamps on the JS side.Aug 30 2024, 9:08 AM

Harbormaster completed remote builds in B31374: Diff 43818.Aug 30 2024, 9:16 AM

inka accepted this revision.Sep 3 2024, 2:58 AM

This revision is now accepted and ready to land.Sep 3 2024, 2:58 AM

Closed by commit rCOMM9d16076365c5: [native][web] Add a timestamp column to threads table (authored by tomek). · Explain WhySep 6 2024, 8:10 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM9d16076365c5: [native][web] Add a timestamp column to threads table.

Revision Contents
Changeset List

Path

Size

lib/

types/

thread-types.js

1 line

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

32 lines

entities/

Thread.h

8 lines

NativeModules/

PersistentStorageUtilities/

DataStores/

ThreadStore.cpp

13 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

3 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

messages-and-media-queries.test.js

2 lines

threads-queries.test.js

46 lines

types/

entities.js

3 lines

entities.test.js

1 line

Diff 43818

View Options

lib/types/thread-types.js

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadStore.cpp

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

View Options

web/shared-worker/_generated/comm_query_executor.wasm

View Options

web/shared-worker/queries/messages-and-media-queries.test.js

View Options

web/shared-worker/queries/threads-queries.test.js

View Options

web/shared-worker/types/entities.js

View Options

web/shared-worker/types/entities.test.js

[native][web] Add a timestamp column to threads tableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43818

lib/types/thread-types.js

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadStore.cpp

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/messages-and-media-queries.test.js

web/shared-worker/queries/threads-queries.test.js

web/shared-worker/types/entities.js

web/shared-worker/types/entities.test.js

[native][web] Add a timestamp column to threads table
ClosedPublic
Actions

Revision Contents
Changeset List