Page MenuHomePhabricator
Differential D13211

[native][web] Add a timestamp column to threads table
ClosedPublic
Actions

Authored by tomek on Aug 30 2024, 6:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 10:49 PM
Unknown Object (File)
Sun, Mar 9, 12:49 PM
Unknown Object (File)
Mar 4 2025, 10:48 PM
Unknown Object (File)
Mar 4 2025, 10:48 PM
Unknown Object (File)
Mar 4 2025, 10:48 PM
Unknown Object (File)
Mar 4 2025, 12:29 AM
Unknown Object (File)
Mar 1 2025, 9:47 PM
Unknown Object (File)
Feb 17 2025, 2:52 PM
View All 45 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM9d16076365c5: [native][web] Add a timestamp column to threads table
Summary

Create a new column where timestamps are stored.

https://linear.app/comm/issue/ENG-8751/add-a-timestamps-property-to-a-thick-thread-info

Test Plan

On native and web check if the migration succeeds. Also, clear the db and run the app to make sure creating new schema works.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
types/
1 line
native/
cpp/
CommonCpp/
DatabaseManagers/
32 lines
entities/
8 lines
NativeModules/
PersistentStorageUtilities/
DataStores/
13 lines
web/
cpp/
3 lines
shared-worker/
_generated/
queries/
2 lines
46 lines
types/
3 lines
1 line

Diff 43818

View Options

lib/types/thread-types.js

// @flow // @flow
import type { NotificationsCreationData } from './notif-types.js';
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string, +dmOpID?: string,
}
| {
+notificationsCreationData?: NotificationsCreationData,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

// @flow // @flow
import type { NotificationsCreationData } from './notif-types.js';
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string, +dmOpID?: string,
}
| {
+notificationsCreationData?: NotificationsCreationData,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h

// @flow // @flow
import type { NotificationsCreationData } from './notif-types.js';
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string, +dmOpID?: string,
}
| {
+notificationsCreationData?: NotificationsCreationData,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadStore.cpp

// @flow // @flow
import type { NotificationsCreationData } from './notif-types.js';
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string, +dmOpID?: string,
}
| {
+notificationsCreationData?: NotificationsCreationData,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/messages-and-media-queries.test.js

Loading...
View Options

web/shared-worker/queries/threads-queries.test.js

Loading...
View Options

web/shared-worker/types/entities.js

Loading...
View Options

web/shared-worker/types/entities.test.js

Loading...