Page MenuHomePhabricator
Differential D13547

[lib] Make sure we set isViewer in useExistingThreadInfoFinder
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:06 PM.
Tags
None
Referenced Files
F3311480: D13547.id44728.diff
Tue, Nov 19, 8:59 AM
F3311478: D13547.id44777.diff
Tue, Nov 19, 8:58 AM
Unknown Object (File)
Sun, Nov 10, 4:20 PM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 1, 4:46 PM
Unknown Object (File)
Fri, Nov 1, 5:36 AM
Unknown Object (File)
Tue, Oct 29, 10:47 AM
View All 33 Files
Subscribers
None

Details

Reviewers
tomek
kamil
inka
Commits
rCOMM332eeeba691e: [lib] Make sure we set isViewer in useExistingThreadInfoFinder
Summary

When we call createPendingThread in useExistingThreadInfoFinder, we need to include isViewer in order to make sure a PRIVATE thread is rendered as eg. "ashoat" instead of "just you". This is because the naming is based on ifJustViewer, which only applies if the members list only includes the viewer.

Depends on D13546

Test Plan

Confirm that I see eg. "ashoat" instead of "just you" for PRIVATE thread uiName

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
5 lines

Diff 44777

View Options

lib/shared/thread-utils.js

Loading...