Page MenuHomePhabricator

[tunnelbroker] Ignore connection error messages handled elsewhere
ClosedPublic

Authored by bartek on Oct 3 2024, 1:37 PM.
Tags
None
Referenced Files
F3341592: D13608.id44905.diff
Thu, Nov 21, 11:20 PM
F3341489: D13608.id44937.diff
Thu, Nov 21, 11:05 PM
F3337772: D13608.diff
Thu, Nov 21, 5:09 PM
Unknown Object (File)
Sun, Nov 10, 11:38 AM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 1:48 PM
Unknown Object (File)
Sun, Oct 27, 10:34 PM
Unknown Object (File)
Fri, Oct 25, 10:36 AM
Subscribers

Details

Summary

This is to avoid alerting spam for errors from inside lapin library that we handle e.g. by reconnecting to RabbitMQ.

Depends on D13607

Test Plan

When Tunnelbroker is open, stop RabbitMQ server.

Before: Error was displayed with errorType = AMQP_ERROR that connection is lost.
After: The error is not displayed from this handler. Error message appears only when all exponential backoff attempts fail.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Oct 4 2024, 8:44 AM
bartek edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Oct 7 2024, 2:50 AM