Page MenuHomePhabricator
Differential D13605

[tunnelbroker] Refactor Websocket session init
ClosedPublic
Actions

Authored by bartek on Oct 3 2024, 1:36 PM.
Tags
None
Referenced Files
F3360044: D13605.diff
Sun, Nov 24, 11:53 AM
Unknown Object (File)
Fri, Nov 22, 4:48 PM
Unknown Object (File)
Fri, Nov 22, 4:48 PM
Unknown Object (File)
Fri, Nov 22, 4:48 PM
Unknown Object (File)
Fri, Nov 22, 12:10 AM
Unknown Object (File)
Thu, Nov 21, 11:56 PM
Unknown Object (File)
Thu, Nov 21, 11:25 PM
Unknown Object (File)
Thu, Nov 21, 11:22 PM
View All 66 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMMb43e6708eee6: [tunnelbroker] Refactor Websocket session init
Summary

Separated AMQP and DeviceInfo/auth logic from initiate_session(). Moved channel creation deeper into WebsocketSession::init_amqp()

Depends on D13604

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Oct 3 2024, 1:36 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 1:36 PM
bartek added a child revision: D13606: [tunnelbroker] Recover AMQP consumers.Oct 3 2024, 1:37 PM
Harbormaster completed remote builds in B32056: Diff 44885.Oct 3 2024, 2:06 PM
bartek updated this revision to Diff 44894.Oct 4 2024, 3:27 AM

Rebase

Harbormaster completed remote builds in B32063: Diff 44894.Oct 4 2024, 3:45 AM
bartek edited the summary of this revision. (Show Details)Oct 4 2024, 3:53 AM
bartek edited the test plan for this revision. (Show Details)
bartek edited the summary of this revision. (Show Details)
bartek updated this revision to Diff 44902.Oct 4 2024, 8:17 AM

Remove connection pool

bartek published this revision for review.Oct 4 2024, 8:38 AM
Harbormaster completed remote builds in B32070: Diff 44902.Oct 4 2024, 8:42 AM
kamil accepted this revision.EditedOct 7 2024, 2:04 AM

Looks a lot cleaner now

services/tunnelbroker/src/websockets/session.rs
204 ↗(On Diff #44902)

I would prefer something like get_device_info_from_frame

This revision is now accepted and ready to land.Oct 7 2024, 2:04 AM
bartek updated this revision to Diff 44923.Oct 7 2024, 7:06 AM

Rename

Harbormaster completed remote builds in B32087: Diff 44923.Oct 7 2024, 7:25 AM
Closed by commit rCOMMb43e6708eee6: [tunnelbroker] Refactor Websocket session init (authored by bartek). · Explain WhyOct 7 2024, 7:28 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMb43e6708eee6: [tunnelbroker] Refactor Websocket session init.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
websockets/
37 lines
91 lines

Diff 44894

View Options

services/tunnelbroker/src/websockets/mod.rs

Loading...
View Options

services/tunnelbroker/src/websockets/session.rs

Loading...