Page MenuHomePhabricator
Differential D13604

[tunnelbroker] Use AMQP wrapper in servers
ClosedPublic
Actions

Authored by bartek on Oct 3 2024, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 1:10 AM
Unknown Object (File)
Wed, Dec 18, 11:38 AM
Unknown Object (File)
Wed, Dec 18, 11:38 AM
Unknown Object (File)
Wed, Dec 18, 11:38 AM
Unknown Object (File)
Mon, Nov 25, 1:02 PM
Unknown Object (File)
Fri, Nov 22, 4:48 PM
Unknown Object (File)
Fri, Nov 22, 4:48 PM
Unknown Object (File)
Nov 21 2024, 10:45 PM
View All 44 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMMe2324a90efb1: [tunnelbroker] Use AMQP wrapper in servers
Summary

Replacing legacy connection with the new wrapper struct

Depends on D13603

Test Plan

cargo build, tunnelbroker integration tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Oct 3 2024, 1:36 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 1:36 PM
bartek added a child revision: D13605: [tunnelbroker] Refactor Websocket session init.Oct 3 2024, 1:36 PM
Harbormaster completed remote builds in B32055: Diff 44884.Oct 3 2024, 2:01 PM
bartek edited the summary of this revision. (Show Details)Oct 4 2024, 3:50 AM
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Oct 4 2024, 3:52 AM
bartek added inline comments.
services/tunnelbroker/src/grpc/mod.rs
61–64 ↗(On Diff #44884)

By retrieving it each time we make sure it's connected - the channel().await takes care of it

131–134 ↗(On Diff #44884)

This expect caused crashes when trying to create channels on already-broken connection

bartek updated this revision to Diff 44901.Oct 4 2024, 8:17 AM

Remove connection pool

Harbormaster completed remote builds in B32069: Diff 44901.Oct 4 2024, 8:39 AM
bartek mentioned this in D13621: [tunnelbroker] Implement lazy AMQP channel wrapper.Oct 6 2024, 11:51 PM
kamil accepted this revision.Oct 7 2024, 1:52 AM
This revision is now accepted and ready to land.Oct 7 2024, 1:52 AM
Closed by commit rCOMMe2324a90efb1: [tunnelbroker] Use AMQP wrapper in servers (authored by bartek). · Explain WhyOct 7 2024, 7:28 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe2324a90efb1: [tunnelbroker] Use AMQP wrapper in servers.
bartek mentioned this in rCOMMb92865431259: [tunnelbroker] Implement lazy AMQP channel wrapper.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
grpc/
22 lines
4 lines
websockets/
26 lines

Diff 44901

View Options

services/tunnelbroker/src/grpc/mod.rs

Loading...
View Options

services/tunnelbroker/src/main.rs

Loading...
View Options

services/tunnelbroker/src/websockets/mod.rs

Loading...