Paths

Table of Contentst

[comm-lib] Add missing feature dependency to Cargo.toml
ClosedPublic
Actions

Authored by bartek on Oct 9 2024, 1:28 AM.

Tags

None

Referenced Files

	F3352259: D13649.id44999.diff
	Sat, Nov 23, 5:18 AM

	Unknown Object (File)
	Thu, Nov 21, 5:27 PM

	Unknown Object (File)
	Thu, Nov 21, 11:35 AM

	Unknown Object (File)
	Mon, Nov 11, 4:08 PM

	Unknown Object (File)
	Sat, Nov 9, 3:55 AM

	Unknown Object (File)
	Sat, Nov 9, 2:21 AM

	Unknown Object (File)
	Fri, Nov 1, 12:08 PM

	Unknown Object (File)
	Fri, Nov 1, 11:34 AM

View All 20 Files

Subscribers

ashoat

tomek

Details

Reviewers

varun
will
kamil

Commits

rCOMM4dd91d929b9c: [comm-lib] Add missing feature dependency to Cargo.toml

Summary

Noticed that this was missing and compilation failed for services with enabled blob-client feature, but disabled http feature.

Test Plan

cargo build -p comm-lib --all-features

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 9 2024, 1:28 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 9 2024, 1:28 AM

bartek added a child revision: D13650: [identity] Add function to remove holders for devices.Oct 9 2024, 1:34 AM

Harbormaster completed remote builds in B32129: Diff 44999.Oct 9 2024, 2:02 AM

bartek published this revision for review.Oct 9 2024, 2:23 AM

kamil accepted this revision.Oct 10 2024, 2:28 AM

This revision is now accepted and ready to land.Oct 10 2024, 2:28 AM

Closed by commit rCOMM4dd91d929b9c: [comm-lib] Add missing feature dependency to Cargo.toml (authored by bartek). · Explain WhyOct 14 2024, 7:20 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM4dd91d929b9c: [comm-lib] Add missing feature dependency to Cargo.toml.

Revision Contents
Changeset List

Path

Size

shared/

comm-lib/

Cargo.toml

1 line

Diff 45163

View Options

shared/comm-lib/Cargo.toml

[comm-lib] Add missing feature dependency to Cargo.tomlClosedPublicActions