[CommCoreModule][native_rust_library] deprecate SIWE related backup code
ClosedPublic
Actions

Authored by kamil on Oct 31 2024, 3:10 PM.

Details

Reviewers

varun
bartek

Commits

rCOMM0504d518f7f1: [CommCoreModule][native_rust_library] deprecate SIWE related backup code

Summary

ENG-6145.

In the past logic was diverged, it shouldn't be - for C++/Rust we should just use backup with secret (no matter if this is a secret from password or wallet signature)

Depends on D13844

Test Plan

N/A, removing dead code

Diff Detail

Repository

rCOMM Comm

Branch

backup-work-5

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Oct 31 2024, 3:10 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 31 2024, 3:10 PM

kamil added a child revision: D13847: [native] update Secondary Device Auth flow to support SIWE users.Oct 31 2024, 3:13 PM

Harbormaster completed remote builds in B32480: Diff 45513.Oct 31 2024, 3:45 PM

kamil published this revision for review.Oct 31 2024, 3:53 PM

varun accepted this revision.Nov 5 2024, 3:20 PM

This revision is now accepted and ready to land.Nov 5 2024, 3:20 PM

bartek accepted this revision.Nov 6 2024, 8:38 AM

Closed by commit rCOMM0504d518f7f1: [CommCoreModule][native_rust_library] deprecate SIWE related backup code. · Explain WhyNov 7 2024, 12:07 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0504d518f7f1: [CommCoreModule][native_rust_library] deprecate SIWE related backup code.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

11 lines

CommCoreModule.cpp

48 lines

_generated/

commJSI-generated.cpp

commJSI.h

native_rust_library/

src/

backup.rs

45 lines

lib.rs

3 lines

schema/

CommCoreModuleSchema.js

6 lines

Diff 45513

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/native_rust_library/src/backup.rs

View Options

native/native_rust_library/src/lib.rs

View Options

native/schema/CommCoreModuleSchema.js

[CommCoreModule][native_rust_library] deprecate SIWE related backup codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45513

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/native_rust_library/src/backup.rs

native/native_rust_library/src/lib.rs

native/schema/CommCoreModuleSchema.js

[CommCoreModule][native_rust_library] deprecate SIWE related backup code
ClosedPublic
Actions

Revision Contents
Changeset List