Page MenuHomePhabricator

[native] update Secondary Device Auth flow to support SIWE users
Needs ReviewPublic

Authored by kamil on Thu, Oct 31, 8:13 AM.
Tags
None
Referenced Files
F3116156: D13847.id45514.diff
Thu, Oct 31, 10:25 PM
F3114788: D13847.diff
Thu, Oct 31, 8:43 PM
F3111362: D13847.id45514.diff
Thu, Oct 31, 1:50 PM
F3111335: D13847.id.diff
Thu, Oct 31, 1:50 PM
F3111328: D13847.diff
Thu, Oct 31, 1:50 PM
Subscribers

Details

Reviewers
varun
bartek
Summary

ENG-6145.

ENG-9825

  1. Turn functions into a hook
  2. Update SecondaryDeviceQRCodeScanner to fetch credentials for both username/wallet users
  3. Clean some code

Depends on D13846

Test Plan

Tested in D13849

Diff Detail

Repository
rCOMM Comm
Branch
backup-work-5
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Thu, Oct 31, 8:53 AM
kamil edited the test plan for this revision. (Show Details)
kamil added inline comments.
native/backup/use-client-backup.js
41

we can't use useGetBackupSecretForLoggedInUser because in this one case we need also message too

native/backup/use-get-backup-secret.js
12

it's named like this, to make sure it won't be used e.g. during restore where we need different mechanism