Differential D13873

[backup-service] refactor uploading function in `/backups` endpoint
AcceptedPublic
Actions

Authored by kamil on Tue, Nov 5, 6:33 AM.

Tags

None

Referenced Files

	F3164439: D13873.diff
	Wed, Nov 6, 7:22 PM

	F3163704: D13873.id45608.diff
	Wed, Nov 6, 3:24 PM

	F3163703: D13873.id45607.diff
	Wed, Nov 6, 3:24 PM

	F3163698: D13873.id.diff
	Wed, Nov 6, 3:24 PM

	F3163687: D13873.diff
	Wed, Nov 6, 3:24 PM

Subscribers

Details

Reviewers

varun
bartek

Summary

Part of ENG-6145.

Tracked in ENG-9645.

Extract code that will be needed in endpoints introduced later in the stack
Added comment explaining the purpose of this endpoint
Fixed typo in previous comment

Depends on D13872

Test Plan

run commtest

Diff Detail

Repository

Branch

backup-work-6

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Tue, Nov 5, 6:33 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Nov 5, 6:33 AM

kamil edited the summary of this revision. (Show Details)Tue, Nov 5, 6:33 AM

minor update

kamil added a child revision: D13875: [backup-service] make `user_data` optional in `BackupItem`.Tue, Nov 5, 6:44 AM

Harbormaster completed remote builds in B32539: Diff 45607.Tue, Nov 5, 6:51 AM

Harbormaster completed remote builds in B32540: Diff 45608.Tue, Nov 5, 6:53 AM

kamil published this revision for review.Tue, Nov 5, 7:42 AM

bartek accepted this revision.Wed, Nov 6, 1:05 AM

This revision is now accepted and ready to land.Wed, Nov 6, 1:05 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

8 lines

http/

handlers/

98 lines

9 lines

Diff 45607

services/backup/src/error.rs

Loading...

services/backup/src/http/handlers/backup.rs

Loading...

services/backup/src/http/mod.rs

Loading...