Page MenuHomePhabricator

[backup-service] implement endpoint to upload User Keys
ClosedPublic

Authored by kamil on Tue, Nov 5, 9:05 AM.
Tags
None
Referenced Files
F3335410: D13876.id45681.diff
Thu, Nov 21, 9:37 AM
F3329392: D13876.diff
Wed, Nov 20, 4:52 PM
Unknown Object (File)
Wed, Nov 20, 5:26 AM
Unknown Object (File)
Tue, Nov 19, 4:48 PM
Unknown Object (File)
Sat, Nov 16, 11:56 PM
Unknown Object (File)
Fri, Nov 15, 5:25 PM
Unknown Object (File)
Fri, Nov 15, 1:41 AM
Unknown Object (File)
Tue, Nov 12, 5:49 AM
Subscribers

Details

Summary

Part of ENG-6145.

Tracked in ENG-9672.

image.png (818×2 px, 211 KB)

Depends on D13875

Test Plan

Tested in D13879

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Wed, Nov 6, 3:41 AM
kamil edited the summary of this revision. (Show Details)
kamil added inline comments.
services/backup/src/http/handlers/backup.rs
111–122 ↗(On Diff #45615)

We need an old backup item to add new holder to user data

124–158 ↗(On Diff #45615)

this could probably implemented better but not sure - curious for reviewers perspective

bartek added inline comments.
services/backup/src/http/handlers/backup.rs
124–158 ↗(On Diff #45615)

From data safety and consistency perspective, this code makes a lot of sense - we make sure each backup has its own attachment holders. It's slightly worse about performance due to multiple Blob service calls, however this code won't be run frequently.
A potential improvement would be to use the batch-holder endpoints, but this is a follow-up for a separate diff, it can be deferred.

This revision is now accepted and ready to land.Wed, Nov 6, 6:12 AM
services/backup/src/http/handlers/backup.rs
124–158 ↗(On Diff #45615)

Good call, created ENG-9874