Differential D13876

[backup-service] implement endpoint to upload User Keys
ClosedPublic
Actions

Authored by kamil on Tue, Nov 5, 9:05 AM.

Tags

None

Referenced Files

	F3329392: D13876.diff
	Wed, Nov 20, 4:52 PM

	Unknown Object (File)
	Wed, Nov 20, 5:26 AM

	Unknown Object (File)
	Tue, Nov 19, 4:48 PM

	Unknown Object (File)
	Sat, Nov 16, 11:56 PM

	Unknown Object (File)
	Fri, Nov 15, 5:25 PM

	Unknown Object (File)
	Fri, Nov 15, 1:41 AM

	Unknown Object (File)
	Tue, Nov 12, 5:49 AM

	Unknown Object (File)
	Mon, Nov 11, 1:28 PM

View All 25 Files

Subscribers

Details

Reviewers

varun
bartek

Commits

rCOMM3eeef1e77029: [backup-service] implement endpoint to upload User Keys

Summary

Part of ENG-6145.

Tracked in ENG-9672.

image.png (818×2 px, 211 KB)

Depends on D13875

Test Plan

Tested in D13879

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Tue, Nov 5, 9:05 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Nov 5, 9:05 AM

kamil added a child revision: D13877: [backup-service] implement endpoint to upload User Data.Tue, Nov 5, 9:07 AM

update

kamil edited the test plan for this revision. (Show Details)Tue, Nov 5, 9:16 AM

Harbormaster completed remote builds in B32543: Diff 45611.Tue, Nov 5, 9:23 AM

Harbormaster completed remote builds in B32547: Diff 45615.Tue, Nov 5, 9:48 AM

kamil published this revision for review.Wed, Nov 6, 3:41 AM

kamil edited the summary of this revision. (Show Details)

kamil added inline comments.

services/backup/src/http/handlers/backup.rs
111–122	We need an old backup item to add new holder to user data
124–158	this could probably implemented better but not sure - curious for reviewers perspective

bartek accepted this revision.Wed, Nov 6, 6:12 AM

bartek added inline comments.

services/backup/src/http/handlers/backup.rs
124–158	From data safety and consistency perspective, this code makes a lot of sense - we make sure each backup has its own attachment holders. It's slightly worse about performance due to multiple Blob service calls, however this code won't be run frequently. A potential improvement would be to use the batch-holder endpoints, but this is a follow-up for a separate diff, it can be deferred.

This revision is now accepted and ready to land.Wed, Nov 6, 6:12 AM

kamil added inline comments.Thu, Nov 7, 2:08 AM

services/backup/src/http/handlers/backup.rs
124–158	Good call, created ENG-9874

Closed by commit rCOMM3eeef1e77029: [backup-service] implement endpoint to upload User Keys (authored by kamil). · Explain WhyThu, Nov 7, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3eeef1e77029: [backup-service] implement endpoint to upload User Keys.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

http/

handlers/

137 lines

8 lines

Diff 45615

services/backup/src/http/handlers/backup.rs

Loading...

services/backup/src/http/mod.rs

Loading...