[backup-service] implement endpoint to upload User Keys
ClosedPublic
Actions

services/backup/src/http/handlers/backup.rs
111–122	We need an old backup item to add new holder to user data
124–158	this could probably implemented better but not sure - curious for reviewers perspective

bartek accepted this revision.Nov 6 2024, 6:12 AM

bartek added inline comments.

services/backup/src/http/handlers/backup.rs
124–158	From data safety and consistency perspective, this code makes a lot of sense - we make sure each backup has its own attachment holders. It's slightly worse about performance due to multiple Blob service calls, however this code won't be run frequently. A potential improvement would be to use the batch-holder endpoints, but this is a follow-up for a separate diff, it can be deferred.

This revision is now accepted and ready to land.Nov 6 2024, 6:12 AM

kamil added inline comments.Nov 7 2024, 2:08 AM

services/backup/src/http/handlers/backup.rs
124–158	Good call, created ENG-9874

Closed by commit rCOMM3eeef1e77029: [backup-service] implement endpoint to upload User Keys (authored by kamil). · Explain WhyNov 7 2024, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3eeef1e77029: [backup-service] implement endpoint to upload User Keys.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

http/

handlers/

backup.rs

137 lines

mod.rs

8 lines

Diff 45615

View Options

services/backup/src/http/handlers/backup.rs

Show First 20 Lines • Show All 89 Lines • ▼ Show 20 Lines	self
user_id,		user_id,
device_id,		device_id,
access_token,		access_token,
})		})
.await		.await
}		}
}		}

		fn pake_registration_start(
		rng: &mut (impl Rng + CryptoRng),
		user_id: String,
		password: &str,
		device_id: String,
		username: String,
		user_public_key: String,
		) -> Result<(RegistrationRequest, Option<ClientRegistration<Cipher>>), Status> {
		let client_registration_start_result =
		ClientRegistration::<Cipher>::start(rng, password.as_bytes()).map_err(
		\|e\| {
		error!("Failed to start PAKE registration: {}", e);
		Status::failed_precondition("PAKE failure")
		},
		)?;
		let pake_registration_request =
		client_registration_start_result.message.serialize();
		Ok((
		RegistrationRequest {
		data: Some(PakeRegistrationRequestAndUserId(
		PakeRegistrationRequestAndUserIdStruct {
		user_id,
		device_id,
		pake_registration_request,
		username,
		user_public_key,
		},
		)),
		},
		Some(client_registration_start_result.state),
		))
		}

fn pake_registration_finish(		fn pake_registration_finish(
rng: &mut (impl Rng + CryptoRng),		rng: &mut (impl Rng + CryptoRng),
registration_response_bytes: &[u8],		registration_response_bytes: &[u8],
client_registration: Option<ClientRegistration<Cipher>>,		client_registration: Option<ClientRegistration<Cipher>>,
) -> Result<RegistrationUpload<Cipher>, Status> {		) -> Result<RegistrationUpload<Cipher>, Status> {
client_registration		client_registration
.ok_or_else(\|\| {		.ok_or_else(\|\| {
error!("PAKE client_registration not found");		error!("PAKE client_registration not found");
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines

View Options

services/backup/src/http/mod.rs

Show First 20 Lines • Show All 89 Lines • ▼ Show 20 Lines	self
user_id,		user_id,
device_id,		device_id,
access_token,		access_token,
})		})
.await		.await
}		}
}		}

		fn pake_registration_start(
		rng: &mut (impl Rng + CryptoRng),
		user_id: String,
		password: &str,
		device_id: String,
		username: String,
		user_public_key: String,
		) -> Result<(RegistrationRequest, Option<ClientRegistration<Cipher>>), Status> {
		let client_registration_start_result =
		ClientRegistration::<Cipher>::start(rng, password.as_bytes()).map_err(
		\|e\| {
		error!("Failed to start PAKE registration: {}", e);
		Status::failed_precondition("PAKE failure")
		},
		)?;
		let pake_registration_request =
		client_registration_start_result.message.serialize();
		Ok((
		RegistrationRequest {
		data: Some(PakeRegistrationRequestAndUserId(
		PakeRegistrationRequestAndUserIdStruct {
		user_id,
		device_id,
		pake_registration_request,
		username,
		user_public_key,
		},
		)),
		},
		Some(client_registration_start_result.state),
		))
		}

fn pake_registration_finish(		fn pake_registration_finish(
rng: &mut (impl Rng + CryptoRng),		rng: &mut (impl Rng + CryptoRng),
registration_response_bytes: &[u8],		registration_response_bytes: &[u8],
client_registration: Option<ClientRegistration<Cipher>>,		client_registration: Option<ClientRegistration<Cipher>>,
) -> Result<RegistrationUpload<Cipher>, Status> {		) -> Result<RegistrationUpload<Cipher>, Status> {
client_registration		client_registration
.ok_or_else(\|\| {		.ok_or_else(\|\| {
error!("PAKE client_registration not found");		error!("PAKE client_registration not found");
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines

[backup-service] implement endpoint to upload User KeysClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45615

services/backup/src/http/handlers/backup.rs

services/backup/src/http/mod.rs

[backup-service] implement endpoint to upload User Keys
ClosedPublic
Actions

Revision Contents
Changeset List