Details
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/backup/use-client-backup.js | ||
|---|---|---|
| 41 ↗ | (On Diff #45514) | we can't use useGetBackupSecretForLoggedInUser because in this one case we need also message too |
| native/backup/use-get-backup-secret.js | ||
|---|---|---|
| 12 ↗ | (On Diff #45514) | it's named like this, to make sure it won't be used e.g. during restore where we need different mechanism |
left a question inline
| native/backup/use-client-backup.js | ||
|---|---|---|
| 45 ↗ | (On Diff #45514) | why doesn't this function just get the SIWE backup secrets internally? seems unnecessary to pass siweBackupSecrets between JS and C++ |
| native/backup/use-client-backup.js | ||
|---|---|---|
| 45 ↗ | (On Diff #45514) | good question - I have no idea, I don't remember the reasoning behind that decision (D11715) This code is now used for testing purposes, I am going to remove this (createNewSIWEBackup) and re-write as part of Native changes for minimal version of backup project, I also noted this here. I can do it as part of this stack but this change won't be really related to this stack (and removed anyway) - let me know what you think @varun |
| native/backup/use-client-backup.js | ||
|---|---|---|
| 45 ↗ | (On Diff #45514) | I think it's fine if you make this change later |