Page MenuHomePhabricator

[native] bottom sheet for exploring communities
Needs RevisionPublic

Authored by varun on Wed, Nov 20, 11:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 8:27 PM
Unknown Object (File)
Sat, Nov 30, 8:40 AM
Unknown Object (File)
Fri, Nov 29, 3:15 PM
Unknown Object (File)
Wed, Nov 27, 6:03 PM
Unknown Object (File)
Wed, Nov 27, 3:25 PM
Unknown Object (File)
Wed, Nov 27, 3:25 PM
Unknown Object (File)
Wed, Nov 27, 3:25 PM
Unknown Object (File)
Wed, Nov 27, 3:25 PM
Subscribers

Details

Reviewers
ashoat
Summary

in a subsequent diff, the buttons in this bottom sheet will lead to different navigations

Test Plan

successfully navigated to and dismissed bottom sheet on android and ios. confirmed that the buttons were positioned correctly on multiple screen sizes

Simulator Screenshot - iPhone 16 Pro Max - 2024-11-21 at 02.40.15.png (2×1 px, 248 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

native/components/directory-prompt-bottom-sheet.react.js
41

we add buttonHeight twice here since there are two buttons

47–53

this will be replaced with navigations in a subsequent diff

native/components/directory-prompt.react.js
10

Maybe something like this would be better. "Explore communities" would be redundant with our button text, though

native/components/directory-prompt.react.js
7

This comment should be removed

native/vectors/community-logo.react.js
6

Logo doesn’t really make sense here. Will change this to CommunityIcon

ashoat requested changes to this revision.Thu, Nov 21, 5:50 PM

Code is great, but I want to workshop the design & copy just a little bit

native/components/directory-prompt.react.js
10

How about "Discover communities"

11–13

This text feels weird and superfluous... I feel like it's not really communicating anything.

How about:

Want to join some interest-based communities on Comm?

"Interest-based" sounds corpo, but maybe something like that?

native/vectors/community-logo.react.js
6

Where'd you get this SVG? What's the license? Why not use one of the icons? I'm not sure I love the cutout that the foreground silhouette makes against the background silhouettes

9

Thinking more about this SVG graphic, I think it could be cool to have one if we do something more with it than an icon.

I wonder if we could use the graphic to preview some communities that people on the app might want to join... eg. Geopolitics, Screens, NYC, etc. Maybe worth checking with Rahul about?

This revision now requires changes to proceed.Thu, Nov 21, 5:50 PM
native/components/directory-prompt.react.js
11–13

Want to join some communities on Comm that match your vibe?

Want to join some communities on Comm that match your interests?

Want to join some communities on Comm that relate to your interests?

Any of these work?

native/vectors/community-logo.react.js
9
native/components/directory-prompt.react.js
11–13

Hmm, I don't love the trailing prepositional phrase there... can you rephrase in a way that avoids it?

native/components/directory-prompt.react.js
11–13

Do you not like the prepositional phrase or do you not like that it's at the end?

Would this work?

Want to join some communities that match your interests on Comm?

native/components/directory-prompt.react.js
11–13

It's definitely better in the middle, but still sounds awkward to me