Paths

Table of Contentst

Differential D14036

[native][web] Show version unsupported modal when received use_new_flow on logout
ClosedPublic
Actions

Authored by bartek on Nov 25 2024, 3:52 AM.

Tags

None

Referenced Files

	F3535949: D14036.diff
	Wed, Dec 25, 5:07 PM

	Unknown Object (File)
	Mon, Dec 23, 6:11 AM

	Unknown Object (File)
	Sun, Dec 22, 3:23 AM

	Unknown Object (File)
	Fri, Dec 20, 7:07 PM

	Unknown Object (File)
	Mon, Dec 16, 1:38 PM

	Unknown Object (File)
	Mon, Dec 16, 1:17 AM

	Unknown Object (File)
	Mon, Dec 16, 1:17 AM

	Unknown Object (File)
	Mon, Dec 16, 1:17 AM

View All 30 Files

Subscribers

Details

Reviewers

kamil
varun

Commits

rCOMMa9ed6112cc26: [native][web] Show version unsupported modal when received use_new_flow on…

Summary

Address ENG-9718.
Display "version unsupported" message upon logout, when use_new_flow response is received

Depends on D14035

Test Plan

Mocked Identity logout response. I was visually logged out and modal appeared.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 25 2024, 3:52 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 25 2024, 3:52 AM

bartek added a child revision: D14037: [native] Show version unsupported when opened QR screen.Nov 25 2024, 3:54 AM

Harbormaster completed remote builds in B32810: Diff 45997.Nov 25 2024, 4:41 AM

bartek published this revision for review.Nov 25 2024, 5:09 AM

kamil accepted this revision.Nov 26 2024, 2:13 AM

kamil added inline comments.

native/profile/profile-screen.react.js
579–581	I would memoize this object
web/settings/account-settings.react.js
48–53	I would use `React.useMemo` instead of `React.useCallback` and memorize entire `useLogOut` param

This revision is now accepted and ready to land.Nov 26 2024, 2:13 AM

bartek added inline comments.Fri, Nov 29, 3:03 AM

web/settings/account-settings.react.js
48–53	Good idea, thank you

Apply hooks suggestion

Harbormaster completed remote builds in B32897: Diff 46128.Fri, Nov 29, 3:30 AM

Closed by commit rCOMMa9ed6112cc26: [native][web] Show version unsupported modal when received use_new_flow on… (authored by bartek). · Explain WhyFri, Nov 29, 5:03 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa9ed6112cc26: [native][web] Show version unsupported modal when received use_new_flow on….

ashoat added inline comments.Mon, Dec 2, 10:10 AM

native/profile/profile-screen.react.js
579–581	This feedback doesn't seem to have been addressed

bartek mentioned this in D14078: [native] Memoize logOutOptions.Wed, Dec 4, 7:44 AM

bartek mentioned this in rCOMM58cdeac3bb64: [native] Memoize logOutOptions.Fri, Dec 6, 4:45 AM

Revision Contents
Changeset List

Path

Size

native/

profile/

profile-screen.react.js

7 lines

web/

settings/

account-settings.react.js

11 lines

Diff 45997

native/profile/profile-screen.react.js

Loading...

web/settings/account-settings.react.js

Loading...