Paths

Table of Contentst

-
native/
-
chat/
1/3
chat.react.js
-
components/
1/3
directory-prompt-bottom-sheet.react.js
1/3
nux-tips-context.react.js
-
navigation/
1/3
app-navigator.react.js
-
community-directory-tip.react.js
-
community-drawer-button.react.js
-
nux-tip-overlay-backdrop.react.js
-
route-names.js

[native] navigate to community directory nux tip if user declines prompt or closes bottom sheet
ClosedPublic
Actions

Authored by varun on Nov 26 2024, 10:19 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM170dee3fa121: [native] navigate to community directory nux tip if user declines prompt or…

Summary

Depends on D14053

I'm having trouble getting screen recordings to work on my computer, so I'll have to update this diff with a recording from my phone in the morning.

Test Plan

tested dismissing the bottom sheet with a swipe down gesture and declining the prompt by pressing the button. in both cases, the tip appeared after the sheet was closed. the tip appeared in the right spot and i was able to close it.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Nov 26 2024, 10:19 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 26 2024, 10:19 PM

varun added a reviewer: tomek.Nov 26 2024, 10:21 PM

varun added 1 blocking reviewer(s): ashoat.

Harbormaster completed remote builds in B32880: Diff 46095.Nov 26 2024, 10:36 PM

varun requested review of this revision.Nov 26 2024, 10:36 PM

tomek accepted this revision.Nov 27 2024, 2:23 AM

tomek added inline comments.

native/chat/chat.react.js
393–394	I'm not familiar with the rest of the stack, but are you sure we want these two tips to be displayed for the same button? Does this button have two purposes now?
native/components/directory-prompt-bottom-sheet.react.js
57–65	Is it possible for this sheet to appear multiple times? Are we going to show this tip every time?
native/navigation/nux-tip-overlay-backdrop.react.js
59	It's interesting that we were reading this param while this route was typed to have none: `+NUXTipOverlayBackdrop: void,`.

Code looks good, but passing back for a screen recording... I'm not sure about the copy, and a recording would will help me iterate on it

native/chat/chat.react.js
393–394	The button doesn't have two purposes, but we have two NUX tips for it: The first is the standard one on account registration, which is already implemented (`COMMUNITY_DRAWER`). The second is being introduced here, and allows us to point the user to the drawer (where the discovery experience can be launched) if they decline it when we prompt them.
native/components/directory-prompt-bottom-sheet.react.js
57–65	I think that the prompt only appears once, as contrasted with the directory itself (which can be launched from the side drawer)... but it would be good for @varun to confirm that the prompts only ever appears once.
native/navigation/nux-tip-overlay-backdrop.react.js
59	Also curious for an explanation on this. Feels like some changes were left out of an earlier diff?

This revision now requires changes to proceed.Nov 27 2024, 9:21 AM

varun added inline comments.Nov 27 2024, 11:10 AM

native/components/directory-prompt-bottom-sheet.react.js
57–65	that's correct. the bottom sheet will only appear once per install. previous diff (which is still in draft state) has the handler component that makes sure it only appears once
native/navigation/nux-tip-overlay-backdrop.react.js
59	Yeah, this was my mistake… when I worked on D13917, `flow` didn't pick up that the route was still typed to have no params. Luckily, it complained this time when I called `navigation.navigate()` I investigated this a little just now and found that `flow` does not (at least, not always) type check the params passed to `useNavigation().navigate()`. I don't know if this is intentional, but it seems concerning... Sorry, meant to preempt this discussion with a diff comment but forgot to publish it.

ashoat added inline comments.Nov 27 2024, 3:12 PM

native/navigation/nux-tip-overlay-backdrop.react.js
59	Ah yeah, `useNavigation()` is impossible to type well because the types depend on what component it's called from. In contrast, `props.navigation` from a React Navigation screen component will have the right type for the component.

varun added a child revision: D14181: [keyserver] filter out communities that viewer is a member of or that aren't public.Dec 23 2024, 9:18 PM

varun requested review of this revision.Jan 29 2025, 6:21 PM

varun edited the test plan for this revision. (Show Details)

varun attached a referenced file: F3938810: Simulator Screen Recording - iPhone 16 Pro Max - 2025-01-29 at 21.20.50.mp4. (Show Details)

ashoat accepted this revision.Jan 30 2025, 10:56 AM

This revision is now accepted and ready to land.Jan 30 2025, 10:56 AM

Closed by commit rCOMM170dee3fa121: [native] navigate to community directory nux tip if user declines prompt or… (authored by varun). · Explain WhyMar 1 2025, 2:25 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM170dee3fa121: [native] navigate to community directory nux tip if user declines prompt or….

Revision Contents
Changeset List

Path

Size

native/

chat/

chat.react.js

1 line

components/

directory-prompt-bottom-sheet.react.js

26 lines

nux-tips-context.react.js

6 lines

navigation/

app-navigator.react.js

6 lines

community-directory-tip.react.js

19 lines

community-drawer-button.react.js

1 line

nux-tip-overlay-backdrop.react.js

9 lines

route-names.js

8 lines

Diff 46095

View Options

native/chat/chat.react.js

	Show First 20 Lines • Show All 861 Lines • ▼ Show 20 Lines
	// persisted. However, we aren't able to specify nested keys in `blacklist`.			// persisted. However, we aren't able to specify nested keys in `blacklist`.
	// As a result, if we want to prevent nested keys from being persisted we'll			// As a result, if we want to prevent nested keys from being persisted we'll
	// need to use `createTransform(...)` to specify an `inbound` function that			// need to use `createTransform(...)` to specify an `inbound` function that
	// allows us to modify the `state` object before it's passed through			// allows us to modify the `state` object before it's passed through
	// `JSON.stringify(...)` and written to disk. We specify the keys for which			// `JSON.stringify(...)` and written to disk. We specify the keys for which
	// this transformation should be executed in the `whitelist` property of the			// this transformation should be executed in the `whitelist` property of the
	// `config` object that's passed to `createTransform(...)`.			// `config` object that's passed to `createTransform(...)`.
	// eslint-disable-next-line no-unused-vars			// eslint-disable-next-line no-unused-vars
	type PersistedThreadMessageInfo = {
	+startReached: boolean,
	};
	type PersistedMessageStore = {			type PersistedMessageStore = {
	+local: { +[id: string]: LocalMessageInfo },			+local: { +[id: string]: LocalMessageInfo },
	+currentAsOf: { +[keyserverID: string]: number },			+currentAsOf: { +[keyserverID: string]: number },
	+threads: { +[threadID: string]: PersistedThreadMessageInfo },
	};			};

	const messageStoreMessagesBlocklistTransform: Transform = createTransform(			const messageStoreMessagesBlocklistTransform: Transform = createTransform(
	(state: MessageStore): PersistedMessageStore => {			(state: MessageStore): PersistedMessageStore => {
	const { messages, threads, ...messageStoreSansMessages } = state;			const { messages, threads, ...messageStoreSansMessages } = state;
	// We also do not want to persist `messageStore.threads[ID].messageIDs`			return { ...messageStoreSansMessages };
	// because they can be deterministically computed based on messages we have
	// from SQLite
	const threadsToPersist = {};
	for (const threadID in threads) {
	const { messageIDs, ...threadsData } = threads[threadID];
	threadsToPersist[threadID] = threadsData;
	}
	return { ...messageStoreSansMessages, threads: threadsToPersist };
	},			},
	(state: MessageStore): MessageStore => {			(state: MessageStore): MessageStore => {
	const { threads: persistedThreads, ...messageStore } = state;
	const threads = {};
	for (const threadID in persistedThreads) {
	threads[threadID] = { ...persistedThreads[threadID], messageIDs: [] };
	}
	// We typically expect `messageStore.messages` to be `undefined` because			// We typically expect `messageStore.messages` to be `undefined` because
	// messages are persisted in the SQLite `messages` table rather than via			// messages are persisted in the SQLite `messages` table rather than via
	// `redux-persist`. In this case we want to set `messageStore.messages`			// `redux-persist`. In this case we want to set `messageStore.messages`
	// to {} so we don't run into issues with `messageStore.messages` being			// to {} so we don't run into issues with `messageStore.messages` being
	// `undefined` (https://phab.comm.dev/D5545).			// `undefined` (https://phab.comm.dev/D5545).
	//			//
	// However, in the case that a user is upgrading from a client where			// However, in the case that a user is upgrading from a client where
	// `persistConfig.version` < 31, we expect `messageStore.messages` to			// `persistConfig.version` < 31, we expect `messageStore.messages` to
	// contain messages stored via `redux-persist` that we need in order			// contain messages stored via `redux-persist` that we need in order
	// to correctly populate the SQLite `messages` table in migration 31			// to correctly populate the SQLite `messages` table in migration 31
	// (https://phab.comm.dev/D2600).			// (https://phab.comm.dev/D2600).
	//			//
	// However, because `messageStoreMessagesBlocklistTransform` modifies			// However, because `messageStoreMessagesBlocklistTransform` modifies
	// `messageStore` before migrations are run, we need to make sure we aren't			// `messageStore` before migrations are run, we need to make sure we aren't
	// inadvertently clearing `messageStore.messages` (by setting to {}) before			// inadvertently clearing `messageStore.messages` (by setting to {}) before
	// messages are stored in SQLite (https://linear.app/comm/issue/ENG-2377).			// messages are stored in SQLite (https://linear.app/comm/issue/ENG-2377).
	return { ...messageStore, threads, messages: messageStore.messages ?? {} };			return {
				...state,
				threads: state.threads ?? {},
				messages: state.messages ?? {},
				};
	},			},
	{ whitelist: ['messageStore'] },			{ whitelist: ['messageStore'] },
	);			);

	type PersistedReportStore = $Diff<			type PersistedReportStore = $Diff<
	ReportStore,			ReportStore,
	{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },			{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
	>;			>;
	▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
	};			};

	const codeVersion: number = commCoreModule.getCodeVersion();			const codeVersion: number = commCoreModule.getCodeVersion();

	// This local exists to avoid a circular dependency where redux-setup needs to			// This local exists to avoid a circular dependency where redux-setup needs to
	// import all the navigation and screen stuff, but some of those screens want to			// import all the navigation and screen stuff, but some of those screens want to
	// access the persistor to purge its state.			// access the persistor to purge its state.
	let storedPersistor = null;			let storedPersistor = null;

				atulUnsubmitted Not Done Inline Actions Is your editor auto formatter maybe adding these newlines? Feel free to disregard if intentional, but noticed these D9682 as well. atul: Is your editor auto formatter maybe adding these newlines? Feel free to disregard if…
				kamilAuthorUnsubmitted Done Inline Actions looks like it's my IDE fault, it is adding this while committing, I'll take a look kamil: looks like it's my IDE fault, it is adding this while committing, I'll take a look
				atulUnsubmitted Not Done Inline Actions Sweet, thanks for taking a look! Not a huge deal regardless, guess it clutters up `git blame` history a bit.. but not end of the world atul: Sweet, thanks for taking a look! Not a huge deal regardless, guess it clutters up `git blame`…
	function setPersistor(persistor: *) {			function setPersistor(persistor: *) {
	storedPersistor = persistor;			storedPersistor = persistor;
	}			}

	function getPersistor(): empty {			function getPersistor(): empty {
	invariant(storedPersistor, 'should be set');			invariant(storedPersistor, 'should be set');
	return storedPersistor;			return storedPersistor;
	}			}

	export { persistConfig, codeVersion, setPersistor, getPersistor };			export { persistConfig, codeVersion, setPersistor, getPersistor };

View Options

native/components/directory-prompt-bottom-sheet.react.js

	Show First 20 Lines • Show All 861 Lines • ▼ Show 20 Lines
	// persisted. However, we aren't able to specify nested keys in `blacklist`.			// persisted. However, we aren't able to specify nested keys in `blacklist`.
	// As a result, if we want to prevent nested keys from being persisted we'll			// As a result, if we want to prevent nested keys from being persisted we'll
	// need to use `createTransform(...)` to specify an `inbound` function that			// need to use `createTransform(...)` to specify an `inbound` function that
	// allows us to modify the `state` object before it's passed through			// allows us to modify the `state` object before it's passed through
	// `JSON.stringify(...)` and written to disk. We specify the keys for which			// `JSON.stringify(...)` and written to disk. We specify the keys for which
	// this transformation should be executed in the `whitelist` property of the			// this transformation should be executed in the `whitelist` property of the
	// `config` object that's passed to `createTransform(...)`.			// `config` object that's passed to `createTransform(...)`.
	// eslint-disable-next-line no-unused-vars			// eslint-disable-next-line no-unused-vars
	type PersistedThreadMessageInfo = {
	+startReached: boolean,
	};
	type PersistedMessageStore = {			type PersistedMessageStore = {
	+local: { +[id: string]: LocalMessageInfo },			+local: { +[id: string]: LocalMessageInfo },
	+currentAsOf: { +[keyserverID: string]: number },			+currentAsOf: { +[keyserverID: string]: number },
	+threads: { +[threadID: string]: PersistedThreadMessageInfo },
	};			};

	const messageStoreMessagesBlocklistTransform: Transform = createTransform(			const messageStoreMessagesBlocklistTransform: Transform = createTransform(
	(state: MessageStore): PersistedMessageStore => {			(state: MessageStore): PersistedMessageStore => {
	const { messages, threads, ...messageStoreSansMessages } = state;			const { messages, threads, ...messageStoreSansMessages } = state;
	// We also do not want to persist `messageStore.threads[ID].messageIDs`			return { ...messageStoreSansMessages };
	// because they can be deterministically computed based on messages we have
	// from SQLite
	const threadsToPersist = {};
	for (const threadID in threads) {
	const { messageIDs, ...threadsData } = threads[threadID];
	threadsToPersist[threadID] = threadsData;
	}
	return { ...messageStoreSansMessages, threads: threadsToPersist };
	},			},
	(state: MessageStore): MessageStore => {			(state: MessageStore): MessageStore => {
	const { threads: persistedThreads, ...messageStore } = state;
	const threads = {};
	for (const threadID in persistedThreads) {
	threads[threadID] = { ...persistedThreads[threadID], messageIDs: [] };
	}
	// We typically expect `messageStore.messages` to be `undefined` because			// We typically expect `messageStore.messages` to be `undefined` because
	// messages are persisted in the SQLite `messages` table rather than via			// messages are persisted in the SQLite `messages` table rather than via
	// `redux-persist`. In this case we want to set `messageStore.messages`			// `redux-persist`. In this case we want to set `messageStore.messages`
	// to {} so we don't run into issues with `messageStore.messages` being			// to {} so we don't run into issues with `messageStore.messages` being
	// `undefined` (https://phab.comm.dev/D5545).			// `undefined` (https://phab.comm.dev/D5545).
	//			//
	// However, in the case that a user is upgrading from a client where			// However, in the case that a user is upgrading from a client where
	// `persistConfig.version` < 31, we expect `messageStore.messages` to			// `persistConfig.version` < 31, we expect `messageStore.messages` to
	// contain messages stored via `redux-persist` that we need in order			// contain messages stored via `redux-persist` that we need in order
	// to correctly populate the SQLite `messages` table in migration 31			// to correctly populate the SQLite `messages` table in migration 31
	// (https://phab.comm.dev/D2600).			// (https://phab.comm.dev/D2600).
	//			//
	// However, because `messageStoreMessagesBlocklistTransform` modifies			// However, because `messageStoreMessagesBlocklistTransform` modifies
	// `messageStore` before migrations are run, we need to make sure we aren't			// `messageStore` before migrations are run, we need to make sure we aren't
	// inadvertently clearing `messageStore.messages` (by setting to {}) before			// inadvertently clearing `messageStore.messages` (by setting to {}) before
	// messages are stored in SQLite (https://linear.app/comm/issue/ENG-2377).			// messages are stored in SQLite (https://linear.app/comm/issue/ENG-2377).
	return { ...messageStore, threads, messages: messageStore.messages ?? {} };			return {
				...state,
				threads: state.threads ?? {},
				messages: state.messages ?? {},
				};
	},			},
	{ whitelist: ['messageStore'] },			{ whitelist: ['messageStore'] },
	);			);

	type PersistedReportStore = $Diff<			type PersistedReportStore = $Diff<
	ReportStore,			ReportStore,
	{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },			{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
	>;			>;
	▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
	};			};

	const codeVersion: number = commCoreModule.getCodeVersion();			const codeVersion: number = commCoreModule.getCodeVersion();

	// This local exists to avoid a circular dependency where redux-setup needs to			// This local exists to avoid a circular dependency where redux-setup needs to
	// import all the navigation and screen stuff, but some of those screens want to			// import all the navigation and screen stuff, but some of those screens want to
	// access the persistor to purge its state.			// access the persistor to purge its state.
	let storedPersistor = null;			let storedPersistor = null;

				atulUnsubmitted Not Done Inline Actions Is your editor auto formatter maybe adding these newlines? Feel free to disregard if intentional, but noticed these D9682 as well. atul: Is your editor auto formatter maybe adding these newlines? Feel free to disregard if…
				kamilAuthorUnsubmitted Done Inline Actions looks like it's my IDE fault, it is adding this while committing, I'll take a look kamil: looks like it's my IDE fault, it is adding this while committing, I'll take a look
				atulUnsubmitted Not Done Inline Actions Sweet, thanks for taking a look! Not a huge deal regardless, guess it clutters up `git blame` history a bit.. but not end of the world atul: Sweet, thanks for taking a look! Not a huge deal regardless, guess it clutters up `git blame`…
	function setPersistor(persistor: *) {			function setPersistor(persistor: *) {
	storedPersistor = persistor;			storedPersistor = persistor;
	}			}

	function getPersistor(): empty {			function getPersistor(): empty {
	invariant(storedPersistor, 'should be set');			invariant(storedPersistor, 'should be set');
	return storedPersistor;			return storedPersistor;
	}			}

	export { persistConfig, codeVersion, setPersistor, getPersistor };			export { persistConfig, codeVersion, setPersistor, getPersistor };

View Options

native/components/nux-tips-context.react.js

	Show First 20 Lines • Show All 861 Lines • ▼ Show 20 Lines
	// persisted. However, we aren't able to specify nested keys in `blacklist`.			// persisted. However, we aren't able to specify nested keys in `blacklist`.
	// As a result, if we want to prevent nested keys from being persisted we'll			// As a result, if we want to prevent nested keys from being persisted we'll
	// need to use `createTransform(...)` to specify an `inbound` function that			// need to use `createTransform(...)` to specify an `inbound` function that
	// allows us to modify the `state` object before it's passed through			// allows us to modify the `state` object before it's passed through
	// `JSON.stringify(...)` and written to disk. We specify the keys for which			// `JSON.stringify(...)` and written to disk. We specify the keys for which
	// this transformation should be executed in the `whitelist` property of the			// this transformation should be executed in the `whitelist` property of the
	// `config` object that's passed to `createTransform(...)`.			// `config` object that's passed to `createTransform(...)`.
	// eslint-disable-next-line no-unused-vars			// eslint-disable-next-line no-unused-vars
	type PersistedThreadMessageInfo = {
	+startReached: boolean,
	};
	type PersistedMessageStore = {			type PersistedMessageStore = {
	+local: { +[id: string]: LocalMessageInfo },			+local: { +[id: string]: LocalMessageInfo },
	+currentAsOf: { +[keyserverID: string]: number },			+currentAsOf: { +[keyserverID: string]: number },
	+threads: { +[threadID: string]: PersistedThreadMessageInfo },
	};			};

	const messageStoreMessagesBlocklistTransform: Transform = createTransform(			const messageStoreMessagesBlocklistTransform: Transform = createTransform(
	(state: MessageStore): PersistedMessageStore => {			(state: MessageStore): PersistedMessageStore => {
	const { messages, threads, ...messageStoreSansMessages } = state;			const { messages, threads, ...messageStoreSansMessages } = state;
	// We also do not want to persist `messageStore.threads[ID].messageIDs`			return { ...messageStoreSansMessages };
	// because they can be deterministically computed based on messages we have
	// from SQLite
	const threadsToPersist = {};
	for (const threadID in threads) {
	const { messageIDs, ...threadsData } = threads[threadID];
	threadsToPersist[threadID] = threadsData;
	}
	return { ...messageStoreSansMessages, threads: threadsToPersist };
	},			},
	(state: MessageStore): MessageStore => {			(state: MessageStore): MessageStore => {
	const { threads: persistedThreads, ...messageStore } = state;
	const threads = {};
	for (const threadID in persistedThreads) {
	threads[threadID] = { ...persistedThreads[threadID], messageIDs: [] };
	}
	// We typically expect `messageStore.messages` to be `undefined` because			// We typically expect `messageStore.messages` to be `undefined` because
	// messages are persisted in the SQLite `messages` table rather than via			// messages are persisted in the SQLite `messages` table rather than via
	// `redux-persist`. In this case we want to set `messageStore.messages`			// `redux-persist`. In this case we want to set `messageStore.messages`
	// to {} so we don't run into issues with `messageStore.messages` being			// to {} so we don't run into issues with `messageStore.messages` being
	// `undefined` (https://phab.comm.dev/D5545).			// `undefined` (https://phab.comm.dev/D5545).
	//			//
	// However, in the case that a user is upgrading from a client where			// However, in the case that a user is upgrading from a client where
	// `persistConfig.version` < 31, we expect `messageStore.messages` to			// `persistConfig.version` < 31, we expect `messageStore.messages` to
	// contain messages stored via `redux-persist` that we need in order			// contain messages stored via `redux-persist` that we need in order
	// to correctly populate the SQLite `messages` table in migration 31			// to correctly populate the SQLite `messages` table in migration 31
	// (https://phab.comm.dev/D2600).			// (https://phab.comm.dev/D2600).
	//			//
	// However, because `messageStoreMessagesBlocklistTransform` modifies			// However, because `messageStoreMessagesBlocklistTransform` modifies
	// `messageStore` before migrations are run, we need to make sure we aren't			// `messageStore` before migrations are run, we need to make sure we aren't
	// inadvertently clearing `messageStore.messages` (by setting to {}) before			// inadvertently clearing `messageStore.messages` (by setting to {}) before
	// messages are stored in SQLite (https://linear.app/comm/issue/ENG-2377).			// messages are stored in SQLite (https://linear.app/comm/issue/ENG-2377).
	return { ...messageStore, threads, messages: messageStore.messages ?? {} };			return {
				...state,
				threads: state.threads ?? {},
				messages: state.messages ?? {},
				};
	},			},
	{ whitelist: ['messageStore'] },			{ whitelist: ['messageStore'] },
	);			);

	type PersistedReportStore = $Diff<			type PersistedReportStore = $Diff<
	ReportStore,			ReportStore,
	{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },			{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
	>;			>;
	▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
	};			};

	const codeVersion: number = commCoreModule.getCodeVersion();			const codeVersion: number = commCoreModule.getCodeVersion();

	// This local exists to avoid a circular dependency where redux-setup needs to			// This local exists to avoid a circular dependency where redux-setup needs to
	// import all the navigation and screen stuff, but some of those screens want to			// import all the navigation and screen stuff, but some of those screens want to
	// access the persistor to purge its state.			// access the persistor to purge its state.
	let storedPersistor = null;			let storedPersistor = null;

				atulUnsubmitted Not Done Inline Actions Is your editor auto formatter maybe adding these newlines? Feel free to disregard if intentional, but noticed these D9682 as well. atul: Is your editor auto formatter maybe adding these newlines? Feel free to disregard if…
				kamilAuthorUnsubmitted Done Inline Actions looks like it's my IDE fault, it is adding this while committing, I'll take a look kamil: looks like it's my IDE fault, it is adding this while committing, I'll take a look
				atulUnsubmitted Not Done Inline Actions Sweet, thanks for taking a look! Not a huge deal regardless, guess it clutters up `git blame` history a bit.. but not end of the world atul: Sweet, thanks for taking a look! Not a huge deal regardless, guess it clutters up `git blame`…
	function setPersistor(persistor: *) {			function setPersistor(persistor: *) {
	storedPersistor = persistor;			storedPersistor = persistor;
	}			}

	function getPersistor(): empty {			function getPersistor(): empty {
	invariant(storedPersistor, 'should be set');			invariant(storedPersistor, 'should be set');
	return storedPersistor;			return storedPersistor;
	}			}

	export { persistConfig, codeVersion, setPersistor, getPersistor };			export { persistConfig, codeVersion, setPersistor, getPersistor };

View Options

native/navigation/app-navigator.react.js

	Show First 20 Lines • Show All 861 Lines • ▼ Show 20 Lines
	// persisted. However, we aren't able to specify nested keys in `blacklist`.			// persisted. However, we aren't able to specify nested keys in `blacklist`.
	// As a result, if we want to prevent nested keys from being persisted we'll			// As a result, if we want to prevent nested keys from being persisted we'll
	// need to use `createTransform(...)` to specify an `inbound` function that			// need to use `createTransform(...)` to specify an `inbound` function that
	// allows us to modify the `state` object before it's passed through			// allows us to modify the `state` object before it's passed through
	// `JSON.stringify(...)` and written to disk. We specify the keys for which			// `JSON.stringify(...)` and written to disk. We specify the keys for which
	// this transformation should be executed in the `whitelist` property of the			// this transformation should be executed in the `whitelist` property of the
	// `config` object that's passed to `createTransform(...)`.			// `config` object that's passed to `createTransform(...)`.
	// eslint-disable-next-line no-unused-vars			// eslint-disable-next-line no-unused-vars
	type PersistedThreadMessageInfo = {
	+startReached: boolean,
	};
	type PersistedMessageStore = {			type PersistedMessageStore = {
	+local: { +[id: string]: LocalMessageInfo },			+local: { +[id: string]: LocalMessageInfo },
	+currentAsOf: { +[keyserverID: string]: number },			+currentAsOf: { +[keyserverID: string]: number },
	+threads: { +[threadID: string]: PersistedThreadMessageInfo },
	};			};

	const messageStoreMessagesBlocklistTransform: Transform = createTransform(			const messageStoreMessagesBlocklistTransform: Transform = createTransform(
	(state: MessageStore): PersistedMessageStore => {			(state: MessageStore): PersistedMessageStore => {
	const { messages, threads, ...messageStoreSansMessages } = state;			const { messages, threads, ...messageStoreSansMessages } = state;
	// We also do not want to persist `messageStore.threads[ID].messageIDs`			return { ...messageStoreSansMessages };
	// because they can be deterministically computed based on messages we have
	// from SQLite
	const threadsToPersist = {};
	for (const threadID in threads) {
	const { messageIDs, ...threadsData } = threads[threadID];
	threadsToPersist[threadID] = threadsData;
	}
	return { ...messageStoreSansMessages, threads: threadsToPersist };
	},			},
	(state: MessageStore): MessageStore => {			(state: MessageStore): MessageStore => {
	const { threads: persistedThreads, ...messageStore } = state;
	const threads = {};
	for (const threadID in persistedThreads) {
	threads[threadID] = { ...persistedThreads[threadID], messageIDs: [] };
	}
	// We typically expect `messageStore.messages` to be `undefined` because			// We typically expect `messageStore.messages` to be `undefined` because
	// messages are persisted in the SQLite `messages` table rather than via			// messages are persisted in the SQLite `messages` table rather than via
	// `redux-persist`. In this case we want to set `messageStore.messages`			// `redux-persist`. In this case we want to set `messageStore.messages`
	// to {} so we don't run into issues with `messageStore.messages` being			// to {} so we don't run into issues with `messageStore.messages` being
	// `undefined` (https://phab.comm.dev/D5545).			// `undefined` (https://phab.comm.dev/D5545).
	//			//
	// However, in the case that a user is upgrading from a client where			// However, in the case that a user is upgrading from a client where
	// `persistConfig.version` < 31, we expect `messageStore.messages` to			// `persistConfig.version` < 31, we expect `messageStore.messages` to
	// contain messages stored via `redux-persist` that we need in order			// contain messages stored via `redux-persist` that we need in order
	// to correctly populate the SQLite `messages` table in migration 31			// to correctly populate the SQLite `messages` table in migration 31
	// (https://phab.comm.dev/D2600).			// (https://phab.comm.dev/D2600).
	//			//
	// However, because `messageStoreMessagesBlocklistTransform` modifies			// However, because `messageStoreMessagesBlocklistTransform` modifies
	// `messageStore` before migrations are run, we need to make sure we aren't			// `messageStore` before migrations are run, we need to make sure we aren't
	// inadvertently clearing `messageStore.messages` (by setting to {}) before			// inadvertently clearing `messageStore.messages` (by setting to {}) before
	// messages are stored in SQLite (https://linear.app/comm/issue/ENG-2377).			// messages are stored in SQLite (https://linear.app/comm/issue/ENG-2377).
	return { ...messageStore, threads, messages: messageStore.messages ?? {} };			return {
				...state,
				threads: state.threads ?? {},
				messages: state.messages ?? {},
				};
	},			},
	{ whitelist: ['messageStore'] },			{ whitelist: ['messageStore'] },
	);			);

	type PersistedReportStore = $Diff<			type PersistedReportStore = $Diff<
	ReportStore,			ReportStore,
	{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },			{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
	>;			>;
	▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
	};			};

	const codeVersion: number = commCoreModule.getCodeVersion();			const codeVersion: number = commCoreModule.getCodeVersion();

	// This local exists to avoid a circular dependency where redux-setup needs to			// This local exists to avoid a circular dependency where redux-setup needs to
	// import all the navigation and screen stuff, but some of those screens want to			// import all the navigation and screen stuff, but some of those screens want to
	// access the persistor to purge its state.			// access the persistor to purge its state.
	let storedPersistor = null;			let storedPersistor = null;

				atulUnsubmitted Not Done Inline Actions Is your editor auto formatter maybe adding these newlines? Feel free to disregard if intentional, but noticed these D9682 as well. atul: Is your editor auto formatter maybe adding these newlines? Feel free to disregard if…
				kamilAuthorUnsubmitted Done Inline Actions looks like it's my IDE fault, it is adding this while committing, I'll take a look kamil: looks like it's my IDE fault, it is adding this while committing, I'll take a look
				atulUnsubmitted Not Done Inline Actions Sweet, thanks for taking a look! Not a huge deal regardless, guess it clutters up `git blame` history a bit.. but not end of the world atul: Sweet, thanks for taking a look! Not a huge deal regardless, guess it clutters up `git blame`…
	function setPersistor(persistor: *) {			function setPersistor(persistor: *) {
	storedPersistor = persistor;			storedPersistor = persistor;
	}			}

	function getPersistor(): empty {			function getPersistor(): empty {
	invariant(storedPersistor, 'should be set');			invariant(storedPersistor, 'should be set');
	return storedPersistor;			return storedPersistor;
	}			}

	export { persistConfig, codeVersion, setPersistor, getPersistor };			export { persistConfig, codeVersion, setPersistor, getPersistor };