[native] Update the SIWE backup restore screen
ClosedPublic
Actions

Authored by tomek on Tue, Dec 17, 7:25 AM.

Details

Reviewers

kamil
bartek
angelika

Commits

rCOMMad8616357835: [native] Update the SIWE backup restore screen

Summary

This screen needs to be updated in a couple of ways:

We should display it in the same navigator as the rest of the flow. This improves consistency.
A cancel button should be removed, because we don't support restoring an account without restoring the backup.
A loading state should be added to the SIWE button.
Some minor layout tweaks are necessary for the screen to look consistent.

restore-siwe-backup-screen.png (1×834 px, 228 KB)

https://linear.app/comm/issue/ENG-9967/connect-the-siwe-logic-with-the-ui

Depends on D14163

Test Plan

Tested in combination with the rest of the stack. Made sure the screen looks good and can be used.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Tue, Dec 17, 7:25 AM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Dec 17, 7:25 AM

Revert backup menu change

tomek edited the summary of this revision. (Show Details)Tue, Dec 17, 7:30 AM

tomek added a child revision: D14090: [native] Navigate to a SIWE backup screen.

Harbormaster completed remote builds in B33164: Diff 46555.Tue, Dec 17, 7:43 AM

Harbormaster completed remote builds in B33165: Diff 46556.

tomek requested review of this revision.Tue, Dec 17, 7:44 AM

Does it still work from Backup Menu or should be removed to avoid confusion?

This revision is now accepted and ready to land.Wed, Dec 18, 6:02 AM

In D14164#394909, @kamil wrote:

Does it still work from Backup Menu or should be removed to avoid confusion?

Right, removing this makes a lot of sense now.

In D14164#394917, @tomek wrote:

In D14164#394909, @kamil wrote:

Does it still work from Backup Menu or should be removed to avoid confusion?

Right, removing this makes a lot of sense now.