Page MenuHomePhabricator

[native] Update the SIWE backup restore screen
AcceptedPublic

Authored by tomek on Tue, Dec 17, 7:25 AM.
Tags
None
Referenced Files
F3489833: D14164.diff
Wed, Dec 18, 1:49 PM
F3486908: D14164.id46556.diff
Wed, Dec 18, 6:18 AM
F3486907: D14164.id46555.diff
Wed, Dec 18, 6:18 AM
F3486885: D14164.id.diff
Wed, Dec 18, 6:17 AM
F3486867: D14164.diff
Wed, Dec 18, 6:17 AM
F3482909: restore-siwe-backup-screen.png
Tue, Dec 17, 7:30 AM
Subscribers

Details

Summary

This screen needs to be updated in a couple of ways:

  1. We should display it in the same navigator as the rest of the flow. This improves consistency.
  2. A cancel button should be removed, because we don't support restoring an account without restoring the backup.
  3. A loading state should be added to the SIWE button.
  4. Some minor layout tweaks are necessary for the screen to look consistent.

restore-siwe-backup-screen.png (1×834 px, 228 KB)

https://linear.app/comm/issue/ENG-9967/connect-the-siwe-logic-with-the-ui

Depends on D14163

Test Plan

Tested in combination with the rest of the stack. Made sure the screen looks good and can be used.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Revert backup menu change

tomek requested review of this revision.Tue, Dec 17, 7:44 AM

Does it still work from Backup Menu or should be removed to avoid confusion?

This revision is now accepted and ready to land.Wed, Dec 18, 6:02 AM

Does it still work from Backup Menu or should be removed to avoid confusion?

Right, removing this makes a lot of sense now.