Requesting review so this diff gets back in @ashoat's queue. I have a question about readonly syntax.

Going to assume that you grepped the code base for these style names, and they weren't used anywhere. If so then LGTM.

My only real comment here is, what do you think about getting rid of the -settings- in many of these file names? If they're in the settings folder now they're kind of redundant, no?

I have no clue what's going on here. Going to unassign myself.

update type

rubber stamp

In D4035#113263, @palys-swm wrote:

As a test plan, please also check all the places where we use Input and haven't specify disabled value. (it looks like the prop was mandatory, so probably it is ok)

remove disabled prop

add readonly

update setstate type

• Could you link the figma designs? I looked in the linear issue but it wasn't there either?
• Assuming the positioning of the button will be updated in future diffs? The Button, icon and menu item seem like they should all be centered.

LGTM, could you add a screen shot of the image too?

In D4005#112299, @atul wrote:

Thoughts on InlineMessageAction or something? We use "Action" instead of "Engagement" on web so it might be more consistent?

self review

In D3997#112145, @palys-swm wrote:

This is not only a refactor, but it also changes the logic. In the previous version, when item.endsCluster then marginBottom: 5 + clusterEndHeight, but now marginBottom: clusterEndHeight. Is that intentional?

fix logic

[native] [fix] [ENG-1123] update chat bubble design

In D3971#111902, @ashoat wrote:

Strong agree with everything @atul said regarding diff naming – @benschac's diff titles are very complex to parse for me, and I think the Linear issue number is just adding clutter and should be replaced with a link in the diff description

Addressed @atul's comment here: https://phabricator.ashoat.com/D3996 moved chatMessageItemKey into the util chat/util file.

In D3972#111889, @atul wrote:

Makes sense to pull out the helper function.

Is there a reason we call this file chat-message-constants? I might be missing something but it doesn't look like we're keeping constant values in it?

Maybe something like chat-message-utils?

In D3973#111901, @ashoat wrote:

We should make sure we keep the versions in sync across the yarn workspaces

This is critical. If yarn upgrade-interactive doesn't make it easy to do this we should avoid using it. In general I'm a bit skeptical of tools like that, as I worry they hide complexity from the user that is necessary to understand in order to do the work well. I tend to simply edit yarn.lock and package.json files directory when I want something changed. I always try to go through all package.json files as well as all relevant entires in yarn.lock in order to look for inconsistencies

remove positioning

In D3971#111310, @atul wrote:

It looks like the position[ing] prop isn't used in InlineSidebar at all. Looks like it should be removed altogether?

address diff comment

In D3839#110920, @def-au1t wrote:

I feel like the test plan still hasn't been updated. Am I right?

remove unused css classes

add comment

add comment

fix comment

remove prettier

just tested with comment, it's working as expected.

use max-len