Page MenuHomePhorge
Feed Search

Sep 16 2022

derek added inline comments to D5023: [native] added webview to login with working SIWE (registration only).
Sep 16 2022, 3:12 PM
derek updated the diff for D5023: [native] added webview to login with working SIWE (registration only).

addressed comments

Sep 16 2022, 3:11 PM
derek closed D5152: [landing] changed webview bridge message to include signature.
Sep 16 2022, 3:02 PM
derek committed rCOMM472008f36983: [landing] changed webview bridge message to include signature.
Sep 16 2022, 3:02 PM

Sep 15 2022

derek requested review of D5152: [landing] changed webview bridge message to include signature.
Sep 15 2022, 4:41 PM
derek closed D5132: [webpack] added config that allows landing & web to be accessed on physical devices on same network.
Sep 15 2022, 4:20 PM
derek committed rCOMM855cb9513aef: [webpack] added config that allows landing & web to be accessed on physical….
Sep 15 2022, 4:20 PM

Sep 14 2022

derek closed D4997: [landing] SIWE component with RainbowKit that connects & signs a message.
Sep 14 2022, 5:52 PM
derek committed rCOMM554659653560: [landing] SIWE component with RainbowKit that connects & signs a message.
Sep 14 2022, 5:52 PM
derek updated the summary of D5132: [webpack] added config that allows landing & web to be accessed on physical devices on same network.
Sep 14 2022, 2:58 PM
derek requested review of D5132: [webpack] added config that allows landing & web to be accessed on physical devices on same network.
Sep 14 2022, 2:38 PM
derek added a comment to D5023: [native] added webview to login with working SIWE (registration only).

addressed all feedback with changes

Sep 14 2022, 2:23 PM
derek updated the diff for D5023: [native] added webview to login with working SIWE (registration only).

memoized webview src

Sep 14 2022, 2:23 PM
derek updated the diff for D5023: [native] added webview to login with working SIWE (registration only).

removed webpack config changes

Sep 14 2022, 2:21 PM
derek added inline comments to D4997: [landing] SIWE component with RainbowKit that connects & signs a message.
Sep 14 2022, 2:19 PM
derek updated the diff for D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

added comment with docs link

Sep 14 2022, 2:19 PM

Sep 6 2022

derek updated the diff for D5023: [native] added webview to login with working SIWE (registration only).

fixes for physical devices, see https://linear.app/comm/issue/ENG-1747/cant-load-landing-on-physical-device

Sep 6 2022, 7:04 PM
derek updated the summary of D5023: [native] added webview to login with working SIWE (registration only).
Sep 6 2022, 2:08 PM
derek requested review of D5023: [native] added webview to login with working SIWE (registration only).

@atul sorry that was unclear - i meant WIP in the context of SIWE. as a diff, this is ready for review

Sep 6 2022, 2:07 PM

Sep 1 2022

derek updated the summary of D5023: [native] added webview to login with working SIWE (registration only).
Sep 1 2022, 6:51 PM
derek updated the summary of D5023: [native] added webview to login with working SIWE (registration only).
Sep 1 2022, 6:50 PM
derek updated the summary of D5023: [native] added webview to login with working SIWE (registration only).
Sep 1 2022, 6:50 PM
derek requested review of D5023: [native] added webview to login with working SIWE (registration only).
Sep 1 2022, 6:48 PM
derek updated the diff for D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

change webview arguments

Sep 1 2022, 6:18 PM
derek closed D4404: [docs] updated dev env docs for protobuf edge case.
Sep 1 2022, 4:57 PM
derek committed rCOMM037d3f89d54a: [docs] updated dev env docs for protobuf edge case.
Sep 1 2022, 4:57 PM
derek updated the diff for D4404: [docs] updated dev env docs for protobuf edge case.

removed duplicate "install"

Sep 1 2022, 4:57 PM
derek added inline comments to D4997: [landing] SIWE component with RainbowKit that connects & signs a message.
Sep 1 2022, 4:54 PM
derek updated the diff for D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

responded to atul's comments

Sep 1 2022, 4:52 PM

Aug 31 2022

derek requested review of D4997: [landing] SIWE component with RainbowKit that connects & signs a message.
Aug 31 2022, 6:05 PM

Aug 29 2022

derek closed D4959: [native] added react-native-webview to support SIWE.
Aug 29 2022, 6:10 PM
derek committed rCOMM75437d1e9f83: [native] added react-native-webview to support SIWE.
Aug 29 2022, 6:10 PM

Aug 27 2022

derek closed D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".
Aug 27 2022, 6:11 PM
derek added a reverting change for D4510: [landing] SIWE component with RainbowKit that connects & signs a message: rCOMM2681d4fbb030: Revert "[landing] SIWE component with RainbowKit that connects & signs a….
Aug 27 2022, 6:11 PM
derek committed rCOMM2681d4fbb030: Revert "[landing] SIWE component with RainbowKit that connects & signs a….
Aug 27 2022, 6:11 PM
derek added a reverting change for rCOMM4dd1bf70caab: [landing] SIWE component with RainbowKit that connects & signs a message: rCOMM2681d4fbb030: Revert "[landing] SIWE component with RainbowKit that connects & signs a….
Aug 27 2022, 6:11 PM
derek requested review of D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".

requesting review because builds passed 🫡

Aug 27 2022, 6:02 PM
derek updated the summary of D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".
Aug 27 2022, 5:54 PM
derek requested review of D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".
Aug 27 2022, 5:51 PM
derek abandoned D4964: [landing] revert changes in D4510.
Aug 27 2022, 5:50 PM
derek added a reverting change for D4510: [landing] SIWE component with RainbowKit that connects & signs a message: D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".
Aug 27 2022, 5:46 PM
derek added a reverting change for rCOMM4dd1bf70caab: [landing] SIWE component with RainbowKit that connects & signs a message: D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".
Aug 27 2022, 5:46 PM

Aug 26 2022

derek requested review of D4964: [landing] revert changes in D4510.
Aug 26 2022, 9:57 PM
derek closed D4960: [landing] fixed fatal bundling issue using window outside function scope.
Aug 26 2022, 7:27 PM
derek committed rCOMM87421718444f: [landing] fixed fatal bundling issue using window outside function scope.
Aug 26 2022, 7:27 PM
derek requested review of D4960: [landing] fixed fatal bundling issue using window outside function scope.
Aug 26 2022, 6:52 PM
derek updated the diff for D4959: [native] added react-native-webview to support SIWE.

Updating D4959: rebased on top of master

Aug 26 2022, 4:39 PM
derek updated the diff for D4404: [docs] updated dev env docs for protobuf edge case.

Updating D4404: rebased

Aug 26 2022, 4:36 PM
derek updated the diff for D4404: [docs] updated dev env docs for protobuf edge case.

Updating D4404: fixed whitespace

Aug 26 2022, 4:33 PM
derek added a comment to D4404: [docs] updated dev env docs for protobuf edge case.

@ashoat as per your comment I fixed the spacing on line 822 in my last commit - my guess is flow (or some other part of the precommit hook) is linting that space. i'll reach out to dev & find someone to help me troubleshoot that

Aug 26 2022, 4:17 PM
derek requested review of D4959: [native] added react-native-webview to support SIWE.
Aug 26 2022, 4:16 PM
derek updated the diff for D4404: [docs] updated dev env docs for protobuf edge case.

Updating D4404: Summary: updated dev env docs for protobuf edge case, responded to diff comments

Aug 26 2022, 4:14 PM
derek closed D4510: [landing] SIWE component with RainbowKit that connects & signs a message.
Aug 26 2022, 3:31 PM
derek committed rCOMM4dd1bf70caab: [landing] SIWE component with RainbowKit that connects & signs a message.
Aug 26 2022, 3:31 PM

Aug 11 2022

derek retitled D4510: [landing] SIWE component with RainbowKit that connects & signs a message from Summary: SIWE component with RainbowKit that connects & signs a message
Aug 11 2022, 7:32 PM
derek abandoned D4546: Summary: ran codegen for identity service CPP modules.
Aug 11 2022, 7:04 PM
derek requested review of D4546: Summary: ran codegen for identity service CPP modules.

added context for the diff @abosh

Aug 11 2022, 6:29 PM
derek updated the summary of D4546: Summary: ran codegen for identity service CPP modules.
Aug 11 2022, 6:28 PM
derek updated the summary of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.
Aug 11 2022, 6:26 PM
derek requested review of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

@varun i added more context in the description & linked the linear issue
@ashoat welcoming feedback on how i can improve my summaries/test plans

Aug 11 2022, 6:25 PM
derek updated the summary of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.
Aug 11 2022, 6:24 PM

Jul 22 2022

derek added a comment to D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

@varun added a description

Jul 22 2022, 4:15 PM

Jul 20 2022

atul renamed derek.
Jul 20 2022, 6:31 PM

Jul 15 2022

derek requested review of D4546: Summary: ran codegen for identity service CPP modules.
Jul 15 2022, 7:54 PM
derek updated the summary of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.
Jul 15 2022, 3:28 PM
derek updated the summary of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.
Jul 15 2022, 3:28 PM

Jul 12 2022

derek requested review of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.
Jul 12 2022, 7:52 PM
derek abandoned D4349: Summary: added boilerplate for SIWE.

abandoned for https://phab.comm.dev/D4510

Jul 12 2022, 7:40 PM

Jun 29 2022

derek added reviewers for D4404: [docs] updated dev env docs for protobuf edge case: varun, abosh.
Jun 29 2022, 7:28 PM
derek added reviewers for D4404: [docs] updated dev env docs for protobuf edge case: ashoat, atul.
Jun 29 2022, 7:28 PM
derek requested review of D4404: [docs] updated dev env docs for protobuf edge case.
Jun 29 2022, 7:19 PM

Jun 23 2022

derek requested review of D4349: Summary: added boilerplate for SIWE.
Jun 23 2022, 9:17 PM
derek abandoned D4348: Summary: added boilerplate for SIWE.

more fun with phabricator, new diff https://phab.comm.dev/D4349

Jun 23 2022, 9:12 PM
derek requested review of D4348: Summary: added boilerplate for SIWE.
Jun 23 2022, 8:55 PM