Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Sep 16 2022

• derek added inline comments to D5023: [native] added webview to login with working SIWE (registration only).

Sep 16 2022, 8:12 AM

• derek updated the diff for D5023: [native] added webview to login with working SIWE (registration only).

addressed comments

Sep 16 2022, 8:11 AM

• derek closed D5152: [landing] changed webview bridge message to include signature.

Sep 16 2022, 8:02 AM

• derek committed rCOMM472008f36983: [landing] changed webview bridge message to include signature (authored by • derek).

[landing] changed webview bridge message to include signature

Sep 16 2022, 8:02 AM

Sep 15 2022

• derek requested review of D5152: [landing] changed webview bridge message to include signature.

Sep 15 2022, 9:41 AM

• derek closed D5132: [webpack] added config that allows landing & web to be accessed on physical devices on same network.

Sep 15 2022, 9:20 AM

• derek committed rCOMM855cb9513aef: [webpack] added config that allows landing & web to be accessed on physical… (authored by • derek).

[webpack] added config that allows landing & web to be accessed on physical…

Sep 15 2022, 9:20 AM

Sep 14 2022

• derek closed D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

Sep 14 2022, 10:52 AM

• derek committed rCOMM554659653560: [landing] SIWE component with RainbowKit that connects & signs a message (authored by • derek).

[landing] SIWE component with RainbowKit that connects & signs a message

Sep 14 2022, 10:52 AM

• derek updated the summary of D5132: [webpack] added config that allows landing & web to be accessed on physical devices on same network.

Sep 14 2022, 7:58 AM

• derek requested review of D5132: [webpack] added config that allows landing & web to be accessed on physical devices on same network.

Sep 14 2022, 7:38 AM

• derek added a comment to D5023: [native] added webview to login with working SIWE (registration only).

addressed all feedback with changes

Sep 14 2022, 7:23 AM

• derek updated the diff for D5023: [native] added webview to login with working SIWE (registration only).

memoized webview src

Sep 14 2022, 7:23 AM

• derek updated the diff for D5023: [native] added webview to login with working SIWE (registration only).

removed webpack config changes

Sep 14 2022, 7:21 AM

• derek added inline comments to D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

Sep 14 2022, 7:19 AM

• derek updated the diff for D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

added comment with docs link

Sep 14 2022, 7:19 AM

Sep 6 2022

• derek updated the diff for D5023: [native] added webview to login with working SIWE (registration only).

fixes for physical devices, see https://linear.app/comm/issue/ENG-1747/cant-load-landing-on-physical-device

Sep 6 2022, 12:04 PM

• derek updated the summary of D5023: [native] added webview to login with working SIWE (registration only).

Sep 6 2022, 7:08 AM

• derek requested review of D5023: [native] added webview to login with working SIWE (registration only).

@atul sorry that was unclear - i meant WIP in the context of SIWE. as a diff, this is ready for review

Sep 6 2022, 7:07 AM

Sep 1 2022

• derek updated the summary of D5023: [native] added webview to login with working SIWE (registration only).

Sep 1 2022, 11:51 AM

• derek updated the summary of D5023: [native] added webview to login with working SIWE (registration only).

Sep 1 2022, 11:50 AM

• derek updated the summary of D5023: [native] added webview to login with working SIWE (registration only).

Sep 1 2022, 11:50 AM

• derek requested review of D5023: [native] added webview to login with working SIWE (registration only).

Sep 1 2022, 11:48 AM

• derek updated the diff for D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

change webview arguments

Sep 1 2022, 11:18 AM

• derek closed D4404: [docs] updated dev env docs for protobuf edge case.

Sep 1 2022, 9:57 AM

• derek committed rCOMM037d3f89d54a: [docs] updated dev env docs for protobuf edge case (authored by • derek).

[docs] updated dev env docs for protobuf edge case

Sep 1 2022, 9:57 AM

• derek updated the diff for D4404: [docs] updated dev env docs for protobuf edge case.

removed duplicate "install"

Sep 1 2022, 9:57 AM

• derek added inline comments to D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

Sep 1 2022, 9:54 AM

• derek updated the diff for D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

responded to atul's comments

Sep 1 2022, 9:52 AM

Aug 31 2022

• derek requested review of D4997: [landing] SIWE component with RainbowKit that connects & signs a message.

Aug 31 2022, 11:05 AM

Aug 29 2022

• derek closed D4959: [native] added react-native-webview to support SIWE.

Aug 29 2022, 11:10 AM

• derek committed rCOMM75437d1e9f83: [native] added react-native-webview to support SIWE (authored by • derek).

[native] added react-native-webview to support SIWE

Aug 29 2022, 11:10 AM

Aug 27 2022

• derek closed D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".

Aug 27 2022, 11:11 AM

• derek added a reverting change for D4510: [landing] SIWE component with RainbowKit that connects & signs a message: rCOMM2681d4fbb030: Revert "[landing] SIWE component with RainbowKit that connects & signs a….

Aug 27 2022, 11:11 AM

• derek committed rCOMM2681d4fbb030: Revert "[landing] SIWE component with RainbowKit that connects & signs a… (authored by • derek).

Revert "[landing] SIWE component with RainbowKit that connects & signs a…

Aug 27 2022, 11:11 AM

• derek added a reverting change for rCOMM4dd1bf70caab: [landing] SIWE component with RainbowKit that connects & signs a message: rCOMM2681d4fbb030: Revert "[landing] SIWE component with RainbowKit that connects & signs a….

Aug 27 2022, 11:11 AM

• derek requested review of D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".

requesting review because builds passed 🫡

Aug 27 2022, 11:02 AM

• derek updated the summary of D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".

Aug 27 2022, 10:54 AM

• derek requested review of D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".

Aug 27 2022, 10:51 AM

• derek abandoned D4964: [landing] revert changes in D4510.

Aug 27 2022, 10:50 AM

• derek added a reverting change for D4510: [landing] SIWE component with RainbowKit that connects & signs a message: D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".

Aug 27 2022, 10:46 AM

• derek added a reverting change for rCOMM4dd1bf70caab: [landing] SIWE component with RainbowKit that connects & signs a message: D4971: Revert "[landing] SIWE component with RainbowKit that connects & signs a message".

Aug 27 2022, 10:46 AM

Aug 26 2022

• derek requested review of D4964: [landing] revert changes in D4510.

Aug 26 2022, 2:57 PM

• derek closed D4960: [landing] fixed fatal bundling issue using window outside function scope.

Aug 26 2022, 12:27 PM

• derek committed rCOMM87421718444f: [landing] fixed fatal bundling issue using window outside function scope (authored by • derek).

[landing] fixed fatal bundling issue using window outside function scope

Aug 26 2022, 12:27 PM

• derek requested review of D4960: [landing] fixed fatal bundling issue using window outside function scope.

Aug 26 2022, 11:52 AM

• derek updated the diff for D4959: [native] added react-native-webview to support SIWE.

Updating D4959: rebased on top of master

Aug 26 2022, 9:39 AM

• derek updated the diff for D4404: [docs] updated dev env docs for protobuf edge case.

Updating D4404: rebased

Aug 26 2022, 9:36 AM

• derek updated the diff for D4404: [docs] updated dev env docs for protobuf edge case.

Updating D4404: fixed whitespace

Aug 26 2022, 9:33 AM

• derek added a comment to D4404: [docs] updated dev env docs for protobuf edge case.

@ashoat as per your comment I fixed the spacing on line 822 in my last commit - my guess is flow (or some other part of the precommit hook) is linting that space. i'll reach out to dev & find someone to help me troubleshoot that

Aug 26 2022, 9:17 AM

• derek requested review of D4959: [native] added react-native-webview to support SIWE.

Aug 26 2022, 9:16 AM

• derek updated the diff for D4404: [docs] updated dev env docs for protobuf edge case.

Updating D4404: Summary: updated dev env docs for protobuf edge case, responded to diff comments

Aug 26 2022, 9:14 AM

• derek closed D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

Aug 26 2022, 8:31 AM

• derek committed rCOMM4dd1bf70caab: [landing] SIWE component with RainbowKit that connects & signs a message (authored by • derek).

[landing] SIWE component with RainbowKit that connects & signs a message

Aug 26 2022, 8:31 AM

Aug 11 2022

• derek retitled D4510: [landing] SIWE component with RainbowKit that connects & signs a message from Summary: SIWE component with RainbowKit that connects & signs a message to [landing] SIWE component with RainbowKit that connects & signs a message.

Aug 11 2022, 12:32 PM

• derek abandoned D4546: Summary: ran codegen for identity service CPP modules.

Aug 11 2022, 12:04 PM

• derek requested review of D4546: Summary: ran codegen for identity service CPP modules.

added context for the diff @abosh

Aug 11 2022, 11:29 AM

• derek updated the summary of D4546: Summary: ran codegen for identity service CPP modules.

Aug 11 2022, 11:28 AM

• derek updated the summary of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

Aug 11 2022, 11:26 AM

• derek requested review of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

@varun i added more context in the description & linked the linear issue
@ashoat welcoming feedback on how i can improve my summaries/test plans

Aug 11 2022, 11:25 AM

• derek updated the summary of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

Aug 11 2022, 11:24 AM

Jul 22 2022

• derek added a comment to D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

@varun added a description

Jul 22 2022, 9:15 AM

Jul 20 2022

atul renamed • derek from dereknelson to derek.

Jul 20 2022, 11:31 AM

Jul 15 2022

• derek requested review of D4546: Summary: ran codegen for identity service CPP modules.

Jul 15 2022, 12:54 PM

• derek updated the summary of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

Jul 15 2022, 8:28 AM

• derek updated the summary of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

Jul 15 2022, 8:28 AM

Jul 12 2022

• derek requested review of D4510: [landing] SIWE component with RainbowKit that connects & signs a message.

Jul 12 2022, 12:52 PM

• derek abandoned D4349: Summary: added boilerplate for SIWE.

abandoned for https://phab.comm.dev/D4510

Jul 12 2022, 12:40 PM

Jun 29 2022

• derek added reviewers for D4404: [docs] updated dev env docs for protobuf edge case: varun, • abosh.

Jun 29 2022, 12:28 PM

• derek added reviewers for D4404: [docs] updated dev env docs for protobuf edge case: ashoat, atul.

Jun 29 2022, 12:28 PM

• derek requested review of D4404: [docs] updated dev env docs for protobuf edge case.

Jun 29 2022, 12:19 PM

Jun 23 2022

• derek requested review of D4349: Summary: added boilerplate for SIWE.

Jun 23 2022, 2:17 PM

• derek abandoned D4348: Summary: added boilerplate for SIWE.

more fun with phabricator, new diff https://phab.comm.dev/D4349

Jun 23 2022, 2:12 PM

• derek requested review of D4348: Summary: added boilerplate for SIWE.

Jun 23 2022, 1:55 PM