removed abosh to unblock

Capitalize Reactotron

Fix capitalization

not familiar with Aws sdk, but the C++ looks about right. I feel like having a test case for this would help a lot of asserting that it has the desired behavior

otherwise LGTM

would be nice to have a test case that the online behavior is being correctly updated.

In D5173#151704, @max wrote:

I'm checking what's wrong with the Android and iOS builds (maybe the protobuf changes broke some old client-side API code). Requesting review to unblock it for possible comments.

Add info log to demonstrate usage

Target new runtime location

Unfortunately, I don't have integration tests added yet, see https://phab.comm.dev/D5164#151290 .

Passed a unit test in D5166.

not familiar enough with this yet to give good feedback

If the output files are known ahead of time, we should probably be using a "build rule" rather than a "build phase". The difference being phases are ran regardless (so this script gets ran on every build), where as "build rules" can have the "the output is newer than the input" early exit behavior.

My comment can be address in another revision if this is blocking other work

LGTM, thanks :)

Not sure what the Tunnelbroker CI failures are about... @jon, @max – any context?

Use cachix/install-nix and use our comm cache

What do you mean by just saying "better" with no previous context?

Resolve conflicts from master

Move rust install comment to the appropriate line

Just wondering, what do we need c-ares for?

Use glob

Think we need a globstar

thanks :)

Apply the changes to the right file....

Address comments

Apply suggestions

Simplify "How Nix introduces..." section

idb, and reactotron mention is added https://phab.comm.dev/D5157

Mention flipper in both web and mobile setup

It seems like some of the steps in D4967 aren't linked anywhere (for instance idb). What's our thinking there? Are these steps now optional? If so, how do we expect users to discover them?

going to rebase on top of https://phab.comm.dev/D5153

for future reference the tunnelbroker unit test gate will build the rust + c++ codebase, and run the c++ unit tests https://buildkite.com/comm/tunnelbroker-unittests/builds/11#01834184-25d5-4df8-b559-b259a3eabb6b

Not familiar enough to give a good review

No context on correct path forward

In the future we might want to block new builds/tests until there's a diff up that includes them to CI?

I created https://linear.app/comm/issue/ENG-1814, feel free to edit it doesn't align with intention.

Feel like this is an intermediate commit, guess just deal with it.

Not really qualified yet to give this a proper review.

would really like for this to be rebased, the Arc usage for the other lazy_static items has been removed on master, and would like to avoid potentially adding them back.

Just wanted to assert that harbormaster did a successful build