Page MenuHomePhabricator
Feed Advanced Search

Nov 7 2022

max committed rCOMMbdd7605a1886: [services] Tunnelbroker - Moving directories according to the Rust app structure (authored by max).
[services] Tunnelbroker - Moving directories according to the Rust app structure
Nov 7 2022, 5:51 AM
max updated the diff for D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure.

Rebasing on master changes.

Nov 7 2022, 5:50 AM
max added inline comments to D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.
Nov 7 2022, 5:24 AM
max updated the diff for D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.

Changing to use vec! macro.

Nov 7 2022, 5:22 AM
max added inline comments to D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.
Nov 7 2022, 4:54 AM
max updated the diff for D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.

Rebasing on parent changes.

Nov 7 2022, 4:53 AM
max updated the diff for D5429: [services] Tunnelbroker - Initialization function exposed to Rust.

Changing function name from initialization to initialize, based on the comment https://phab.comm.dev/D5432#162406.

Nov 7 2022, 4:48 AM
max updated the diff for D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.

Rebasing on parent changes.

Nov 7 2022, 4:41 AM
max updated the diff for D5431: [services] Tunnelbroker - Removing of deprecated C++ files.

Rebasing on parent changes.

Nov 7 2022, 4:38 AM
max added a comment to D5431: [services] Tunnelbroker - Removing of deprecated C++ files.
In D5431#162401, @tomek wrote:

This diff removes a lot of code. In the previous diff we added only a part of it. I assume in the next diffs most of this code will be reintroduced, but that makes it hard to verify if the code remains correct. It would be better if parts of the code were moved in a diff instead of removing in one and adding in another.

Nov 7 2022, 4:37 AM
max updated the diff for D5429: [services] Tunnelbroker - Initialization function exposed to Rust.

Rebasing on parent changes.

Nov 7 2022, 4:34 AM
max closed D5525: [services] Tunnelbroker - Removing of 'sessionID' from 'MessageToTunnelbroker'.
Nov 7 2022, 4:34 AM
max committed rCOMM3cf94dbbc3f7: [services] Tunnelbroker - Removing of 'sessionID' from 'MessageToTunnelbroker' (authored by max).
[services] Tunnelbroker - Removing of 'sessionID' from 'MessageToTunnelbroker'
Nov 7 2022, 4:34 AM
max added inline comments to D5429: [services] Tunnelbroker - Initialization function exposed to Rust.
Nov 7 2022, 4:33 AM

Nov 4 2022

max updated the diff for D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`.

Rebasing on the parent changes.

Nov 4 2022, 11:11 AM
max updated the diff for D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`.

Changing the binary location directory to build instead of build/bin according to changes in D5430.

Nov 4 2022, 11:10 AM
max added a comment to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
In D5430#163958, @jon wrote:

the binary is in the build directory as well if I use just install(TARGETS runTests RUNTIME DESTINATION bin) which must use build/bin directory. But it's not and puts the binary into the build directory.

The INSTALL(TARGETS ...) cmake options only come into play when you do something like cmake .. && make install. Otherwise it doesn't do much.

Nov 4 2022, 11:02 AM
max updated the diff for D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.

Removing of the CMAKE_RUNTIME_OUTPUT_DIRECTORY.

Nov 4 2022, 10:52 AM
max added inline comments to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
Nov 4 2022, 10:48 AM
max published D5536: [services] Tunnelbroker - Adding of requesting a new notification token if empty for review.
Nov 4 2022, 9:57 AM
max published D5535: [services] Tunnelbroker - Removing of emptiness check for notification token for review.
Nov 4 2022, 9:57 AM
max updated the test plan for D5534: [services] Tunnelbroker - Adding of handling of the `NewNotifyToken` message.
Nov 4 2022, 7:58 AM
max published D5534: [services] Tunnelbroker - Adding of handling of the `NewNotifyToken` message for review.
Nov 4 2022, 7:49 AM
max added inline comments to D5529: [services] Tunnelbroker - Adding the pinging loop and online status of the client check.
Nov 4 2022, 7:05 AM
max updated the diff for D5529: [services] Tunnelbroker - Adding the pinging loop and online status of the client check.

Rebasing on parent changes.
Adding of debug message.
Adding variables cloning before the move into the spawned task.

Nov 4 2022, 7:03 AM
max planned changes to D5490: [services] Tunnelbroker - Adding of gRPC `NewSession` wrapper implementation.
Nov 4 2022, 6:53 AM
max planned changes to D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation.
Nov 4 2022, 6:53 AM
max added inline comments to D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.
Nov 4 2022, 6:52 AM
max updated the diff for D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.

Small changes based on comments.

Nov 4 2022, 6:48 AM
max updated the diff for D5490: [services] Tunnelbroker - Adding of gRPC `NewSession` wrapper implementation.

Using of the shorthand of cxx_bridge calls. Using of the unwrap_or instead of matching.

Nov 4 2022, 6:33 AM
max updated the diff for D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation.

Move cxx_bridge to the use super::cxx_bridge::ffi for shorter calls instead of the full path.

Nov 4 2022, 6:19 AM

Nov 3 2022

max added a reviewer for D5527: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo: ashoat.
Nov 3 2022, 10:26 AM
max added a reviewer for D5526: [services] Tunnelbroker - Adding of `constants.rs` file: tomek.
Nov 3 2022, 10:25 AM
max added a reviewer for D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies: tomek.
Nov 3 2022, 10:24 AM
max added inline comments to D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.
Nov 3 2022, 7:46 AM
max published D5527: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo for review.
Nov 3 2022, 5:34 AM
max added a comment to D5525: [services] Tunnelbroker - Removing of 'sessionID' from 'MessageToTunnelbroker'.

Thanks for the clarification @tomek ;)

Nov 3 2022, 5:22 AM
max added a comment to D5525: [services] Tunnelbroker - Removing of 'sessionID' from 'MessageToTunnelbroker'.

Seems that the Nix build error is unrelated to the last changes as the only comment was added here.

Nov 3 2022, 4:15 AM
max updated the diff for D5525: [services] Tunnelbroker - Removing of 'sessionID' from 'MessageToTunnelbroker'.

Adding a comment about the metadata.

Nov 3 2022, 3:28 AM
max added a comment to D5525: [services] Tunnelbroker - Removing of 'sessionID' from 'MessageToTunnelbroker'.
In D5525#163498, @tomek wrote:

The Linear task mentions that it is a good practice to use a comment to describe metadata - can we do that?

Nov 3 2022, 3:16 AM

Nov 2 2022

max published D5529: [services] Tunnelbroker - Adding the pinging loop and online status of the client check for review.
Nov 2 2022, 4:50 PM
max published D5526: [services] Tunnelbroker - Adding of `constants.rs` file for review.
Nov 2 2022, 4:39 PM
max published D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata for review.
Nov 2 2022, 4:31 PM
max published D5525: [services] Tunnelbroker - Removing of 'sessionID' from 'MessageToTunnelbroker' for review.
Nov 2 2022, 4:19 PM
max added a reviewer for D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker: tomek.
Nov 2 2022, 12:47 PM
max added inline comments to D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`.
Nov 2 2022, 9:40 AM
max added inline comments to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
Nov 2 2022, 9:35 AM
max updated the diff for D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.

Adding a comment for CMP0003 policy

Nov 2 2022, 9:27 AM
max updated the summary of D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.
Nov 2 2022, 9:09 AM
max added inline comments to D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.
Nov 2 2022, 9:08 AM
max updated the diff for D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.

Changing the SDK install and sources copying commands order.

Nov 2 2022, 9:08 AM
max added inline comments to D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.
Nov 2 2022, 8:50 AM
max updated the diff for D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.

Small changes addressing comments.

Nov 2 2022, 8:39 AM

Oct 27 2022

max added inline comments to D5490: [services] Tunnelbroker - Adding of gRPC `NewSession` wrapper implementation.
Oct 27 2022, 9:10 AM
max updated the summary of D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.
Oct 27 2022, 9:06 AM
max added inline comments to D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.
Oct 27 2022, 9:02 AM
max updated the diff for D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.

Updating Tokio to 1.21 version.

Oct 27 2022, 9:00 AM
max updated the diff for D5490: [services] Tunnelbroker - Adding of gRPC `NewSession` wrapper implementation.

Rebasing on a parent changes.

Oct 27 2022, 8:04 AM
max updated the diff for D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation.

Fixing gRPC struct from grpcResult to idiomatic GrpcResult name.

Oct 27 2022, 7:58 AM
max published D5490: [services] Tunnelbroker - Adding of gRPC `NewSession` wrapper implementation for review.
Oct 27 2022, 6:41 AM
max planned changes to D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.
Oct 27 2022, 3:56 AM
max added a reviewer for D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust: tomek.
Oct 27 2022, 2:32 AM
max added a reviewer for D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app: tomek.
Oct 27 2022, 2:31 AM
max added a reviewer for D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`: tomek.
Oct 27 2022, 2:31 AM
max added a reviewer for D5477: [services] Tunnelbroker - Adding Tonic gRPC server with empty handlers: tomek.
Oct 27 2022, 2:31 AM
max added a reviewer for D5486: [services] Tunnelbroker - Move ffi from `main.rs` to the `cxx_bridge.rs` file: tomek.
Oct 27 2022, 2:26 AM

Oct 26 2022

max added inline comments to D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation.
Oct 26 2022, 10:22 AM
max updated the summary of D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation.
Oct 26 2022, 10:18 AM
max published D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation for review.
Oct 26 2022, 10:15 AM
max published D5486: [services] Tunnelbroker - Move ffi from `main.rs` to the `cxx_bridge.rs` file for review.
Oct 26 2022, 10:02 AM
max updated the summary of D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.
Oct 26 2022, 2:49 AM
max added a reviewer for D5431: [services] Tunnelbroker - Removing of deprecated C++ files: tomek.
Oct 26 2022, 2:23 AM
max added a reviewer for D5429: [services] Tunnelbroker - Initialization function exposed to Rust: tomek.
Oct 26 2022, 2:23 AM
max added a reviewer for D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure: tomek.
Oct 26 2022, 2:22 AM
max added a reviewer for D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only: atul. max removed 1 blocking reviewer(s) for D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only: jon.
Oct 26 2022, 2:13 AM

Oct 25 2022

max accepted D5480: [native] fix path to native rust library directory.
Oct 25 2022, 4:46 PM
max published D5477: [services] Tunnelbroker - Adding Tonic gRPC server with empty handlers for review.
Oct 25 2022, 4:40 PM

Oct 24 2022

max added inline comments to D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.
Oct 24 2022, 10:27 AM
max updated the diff for D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.

Cargo re-run if proto file was changed is added.

Oct 24 2022, 10:26 AM
max updated the summary of D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.
Oct 24 2022, 10:17 AM
max updated the summary of D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.
Oct 24 2022, 10:14 AM
max updated the diff for D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.

Adding to the Tunnelbroker to Rust transition stack.
Rebased on the Cargo stack changes.

Oct 24 2022, 10:14 AM
max requested review of D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.

I've added services/tunnelbroker/src/libcpp/test/build directory to ignore the C++ gTest building cache.
We are building and running gTests for a legacy C++ codebase in Buildkite as well in D5461.
Will re-request a review from @ashoat.

Oct 24 2022, 9:57 AM
max requested review of D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
In D5430#161065, @jon wrote:

please also update the path used by the tunnel broker tests under .buildkite/

Oct 24 2022, 9:54 AM
max added a comment to D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure.
In D5428#161080, @jon wrote:

The CI gates should be updated as part of this as well, having two failing gates isn't good.

I would also be fine with some additional diffs later in the stack which fix the builds later on, however, delaying being "green to green" also means that we will have a lot of intermediate diffs which fail to build or pass tests :(

Oct 24 2022, 9:52 AM
max updated the summary of D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`.
Oct 24 2022, 9:48 AM
max updated the summary of D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.
Oct 24 2022, 9:44 AM
max updated the diff for D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`.

Adding of the gTest building and running for the legacy C++ code.

Oct 24 2022, 9:40 AM
max updated the summary of D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.
Oct 24 2022, 9:38 AM
max updated the diff for D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.

Reducing the file size by squashing commands.
Adding of annotations.
Adding of the building and running of the gTest for the legacy C++ codebase.

Oct 24 2022, 9:38 AM
max updated the diff for D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.

Update on a stack changes.

Oct 24 2022, 9:36 AM
max updated the summary of D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.
Oct 24 2022, 9:36 AM
max planned changes to D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.
Oct 24 2022, 9:34 AM
max updated the diff for D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.

Updating on a stack changes.

Oct 24 2022, 9:34 AM
max planned changes to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
Oct 24 2022, 9:33 AM
max updated the summary of D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.
Oct 24 2022, 9:31 AM
max updated the summary of D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.
Oct 24 2022, 9:30 AM
max updated the diff for D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.

Update on a stack changes.

Oct 24 2022, 9:29 AM
max updated the summary of D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.
Oct 24 2022, 9:28 AM
max updated the diff for D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.

Update on the stack changes.

Oct 24 2022, 9:27 AM