rebase, specify polisy type

remove semicolon

rebase, force caller to specify policy type

Thanks for the suggestion @tomek! Addressed in D5663

rebase

rebase

rebase

update import

I did some research, so few conclusions (about iOS because it seems like the only problem):

rename funciton to isTaskCancelledError

rebase

simplify logic

initialize via curly brackets, simplify logic

I've discussed this change with @tomek but sharing what we established.

set tasksCancelled to false after task execution

This was re-implemented in D5377

rebase

Hi @ashoat, @tomek do you think this is ready to land? (D5377, D5378, D5379). Looks like we don't have any crashes on version 153 yet (the release was patched here: https://phab.comm.dev/rCOMM5b72c8d08824c512a39d222ed9b04ce7b972f005)

rebase

rebase, use const

thanks for the suggestions @marcin, applied

reabse, introduce const, simplify logic

rebase

rebase

use scheduleOrRunCancellableCommonImpl, improve readabillity

use scheduleOrRunCancellableCommonImpl, improve readabillity

rename error to deviceIDGenerationError

simplify condition

check for failure on setting db verison

Good job! Adding @tomek as blocking according to: D5453#161021

It seems like having this process described on Notion might be beneficial. @kamil can you take care of it?

@ashoat thank you for a comprehensive explanation - test done.

fix capitalization, restore source name on keyserver

Looks good to me!

Almost there, requesting changes because of the padding thing but other than that good job!

rebase

use class enum, change type to const reference

fix rebase

After consulting this with @tomek we decided to divide this into two separate functions - merging this flow into one is possible but the code is hard to understand, so this should improve readability.

divide logic into two separate functions

fix identation

I did some changes to avoid calling applyMigration in two (mutually exclusive) conditions like @atul and @marcin prefers.

refactor logic to avoid code duplication

rebase

rename function, update identation

Thanks for suggesting this test @marcin, I am a little bit skeptical because in the concurrent environment we will never be 100% sure it works, only if we will have luck we will find something which might not work but here is what I did:

1. Temporarily change sqlite compilation settings for both iOS and Android so that multithreaded access to SQLite is enabled.

I narrowed this only to iOS where we have multithreaded access because we testing shared code (but I can add implementation for Andriod if you think it's needed later on)