iOS build failure is not related to this diff changes, so I'll land it.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Dec 19 2022
Dec 19 2022
• max updated the diff for D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Rebasing on master changes.
• max published D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function for review.
• max published D5928: [services/commtest] Tunnelbroker - Adding the tonic client builder function for review.
• max published D5926: [services/commtest] Adding of openssl, base64, anyhow to dependencies for review.
Thanks, @jon!
• max updated the diff for D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Rebasing on the stack changes.
Dec 16 2022
Dec 16 2022
Accepting, but have a few thoughts:
Dec 14 2022
Dec 14 2022
In D5861#175531, @ashoat wrote:Well @max I think you would still need to call this script somewhere.
I've rebased D5807 on top of this diff changes and it seems it doesn't solve the issue.
• max updated the diff for D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Rebasing on top of the D5861
Looks good to me!
Dec 9 2022
Dec 9 2022
• max committed rCOMM824a62323ca2: [services] Tunnelbroker - Moving the config file to the `~/.config` directory… (authored by • max).
[services] Tunnelbroker - Moving the config file to the `~/.config` directory…
• max committed rCOMMc78a5f17f204: [services] Upgrading Rust Tonic crate version to 0.8 and Prost to 0.11 (authored by • max).
[services] Upgrading Rust Tonic crate version to 0.8 and Prost to 0.11
• max added inline comments to D5285: [services] Upgrading Rust Tonic crate version to 0.8 and Prost to 0.11.
• max updated the diff for D5285: [services] Upgrading Rust Tonic crate version to 0.8 and Prost to 0.11.
Adding of indent.
• max added a reviewer for D5285: [services] Upgrading Rust Tonic crate version to 0.8 and Prost to 0.11: ashoat.
• max added a comment to D5285: [services] Upgrading Rust Tonic crate version to 0.8 and Prost to 0.11.
In D5285#174742, @varun wrote:Got it, and what’s in the lists folder we’re deleting in that command?
• max requested review of D5285: [services] Upgrading Rust Tonic crate version to 0.8 and Prost to 0.11.
Dec 8 2022
Dec 8 2022
• max published D5285: [services] Upgrading Rust Tonic crate version to 0.8 and Prost to 0.11 for review.
Dec 7 2022
Dec 7 2022
• max added 1 blocking reviewer(s) for D5790: [services] Tunnelbroker - Moving the config file to the `~/.config` directory and removing the sandbox config: ashoat.
• max updated the diff for D5790: [services] Tunnelbroker - Moving the config file to the `~/.config` directory and removing the sandbox config.
Removing a sentence with the config file.
Dec 6 2022
Dec 6 2022
• max committed rCOMMa7ee1eb25732: [services] Tunnelbroker - Removing rudimental `messageID` from messages from… (authored by • max).
[services] Tunnelbroker - Removing rudimental `messageID` from messages from…
• max added a comment to D5790: [services] Tunnelbroker - Moving the config file to the `~/.config` directory and removing the sandbox config.
In D5790#173953, @ashoat wrote:Is it possible for anybody else to rewrite @max's English before I take a pass? Please re-add me once it's ready to go
• max updated the diff for D5808: [services] Tunnelbroker - Removing rudimental `messageID` from messages from client to Tunnelbroker.
Rebasing and merging on master changes.
• max committed rCOMMa3a50255a4ce: [services] Tunnelbroker - Removing rudimental `ping` message from the protobuf (authored by • max).
[services] Tunnelbroker - Removing rudimental `ping` message from the protobuf
• max updated the diff for D5790: [services] Tunnelbroker - Moving the config file to the `~/.config` directory and removing the sandbox config.
Fix configuration file template sentence in a doc.
Dec 5 2022
Dec 5 2022
• max published D5809: [services] Tunnelbroker - Removing rudimental `ping` message from the protobuf for review.
• max added a comment to D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
In D5807#173355, @ashoat wrote:Is the CI failing because of the Protobuf version issue?
• max retitled D5808: [services] Tunnelbroker - Removing rudimental `messageID` from messages from client to Tunnelbroker from [services] Tunnelbroker - Remove `messageID` from messages from client to Tunnelbroker to [services] Tunnelbroker - Removing rudimental `messageID` from messages from client to Tunnelbroker.
• max updated the diff for D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Rebasing on the master.
Dec 2 2022
Dec 2 2022
• max added a comment to D5790: [services] Tunnelbroker - Moving the config file to the `~/.config` directory and removing the sandbox config.
In D5790#173107, @jon wrote:Should also remove the corresponding comm::network::tools::isSandbox() method if it's going to exist within the config file.
Dec 1 2022
Dec 1 2022
• max committed rCOMM8e7d6f906d9e: [native] Removing Tunnelbroker-related protobuf compiled files (authored by • max).
[native] Removing Tunnelbroker-related protobuf compiled files
In D5792#172828, @ashoat wrote:Please wait for iOS build CI to complete before landing!
In D5758#172780, @jon wrote:Maybe we can unify this in a way that comm-dev services stop stopping or/and killing services and we just call comm-dev services stop from the inside of comm-dev services start and move all of the "stopping" logic from the beginning of the comm-dev services start to comm-dev services stop?
How about I add a restart command which does that. I think start should be limited to starting services, and stop should be limited to stoppping services.
• max committed rCOMM508b86102c9a: [services] Tunnelbroker - Adding the gRPC server keep-alive into the Tonic… (authored by • max).
[services] Tunnelbroker - Adding the gRPC server keep-alive into the Tonic…
I assume that we are stopping service first before we are starting it, so maybe we can just call comm-dev services stop.
No. I just check to see if there's a process already running, start it if it's not.
• max added a comment to D5713: [services] Tunnelbroker - Adding the gRPC server keep-alive into the Tonic server.
In D5713#171992, @varun wrote:might be worth explaining in constants.rs the rationale behind the chosen interval and timeout times
• max updated the diff for D5713: [services] Tunnelbroker - Adding the gRPC server keep-alive into the Tonic server.
Switch to use Duration in constants instead of uint.
Nov 30 2022
Nov 30 2022
• max committed rCOMMd4205e430dce: [services] Tunnelbroker - Remove checkpoints from the database (authored by • max).
[services] Tunnelbroker - Remove checkpoints from the database
• max committed rCOMMbc81f2858c4a: [native] Removing gRPC C++ deleted files from the XCode project (authored by • max).
[native] Removing gRPC C++ deleted files from the XCode project
That said, I think the test plan is not good... the app builds in Xcode either way. Instead, can you modify the test plan to include opening up Xcode, and verifying there are no red entries in the file view (folder icon on the left pane) except for CommRelease?
• max updated the test plan for D5766: [native] Removing gRPC C++ deleted files from the XCode project.
Nov 29 2022
Nov 29 2022
Looks ok to me, but have a few comments:
In D5733#171182, @tomek wrote:Are there any other changes that have to be made? E.g. on AWS or in any config file?
• max added a reviewer for D5713: [services] Tunnelbroker - Adding the gRPC server keep-alive into the Tonic server: tomek.
• max added inline comments to D5713: [services] Tunnelbroker - Adding the gRPC server keep-alive into the Tonic server.
• max updated the diff for D5713: [services] Tunnelbroker - Adding the gRPC server keep-alive into the Tonic server.
Switching to use u64 instead of converting from u8 by the into().
Not crazy that we don't have a Terraform config for this, but your reasoning for why is confusing to hear.
Is that because those fields are not defined on the AWS side at all?
• max committed rCOMM0810d1d11618: [native] Removing `codegen-grpc` from native (authored by • max).
[native] Removing `codegen-grpc` from native
Rebased on master and merged.
• max committed rCOMMf547935f23e0: [native] Remove gRPC related C++ code and packages from iOS and Android (authored by • max).
[native] Remove gRPC related C++ code and packages from iOS and Android
• max updated the diff for D5706: [native] Remove gRPC related C++ code and packages from iOS and Android.
Merging.
• max updated the diff for D5706: [native] Remove gRPC related C++ code and packages from iOS and Android.
Rebasing on master and merging.
• max committed rCOMMd489ecfd51da: [services] Tunnelbroker - Removing of `get` and `send` methods from API and… (authored by • max).
[services] Tunnelbroker - Removing of `get` and `send` methods from API and…
• max committed rCOMMab3f2bce300c: [services] Tunnelbroker - Removing the old API (authored by • max).
[services] Tunnelbroker - Removing the old API
• max updated the diff for D5684: [services] Tunnelbroker - Removing of `get` and `send` methods from API and native codebase.
Rebase and merge.
Rebase and merge.
In D5733#171246, @ashoat wrote:Is there a Terraform config for this?
In D5733#171182, @tomek wrote:Are there any other changes that have to be made? E.g. on AWS or in any config file?
In D5733#170956, @max wrote:Adding a @tomek because I think he's the only one who has a full context on this.
After a couple of months I guess that no one has full context and we all have to figure this out.
Nov 28 2022
Nov 28 2022
Adding a @tomek because I think he's the only one who has a full context on this.
• max added a reviewer for D5733: [services] Tunnelbroker - Remove checkpoints from the database: tomek.