Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Dec 28 2022

• max closed D6014: [native/rust_library] Removing of testing `hello.c` and increase C++ standard to 17 in `build.rs`.
Dec 28 2022, 7:10 AM
• max committed rCOMM407f2a2c7d02: [native/rust_library] Removing of testing `hello.c` and increase C++ standard… (authored by • max).
[native/rust_library] Removing of testing `hello.c` and increase C++ standard…
Dec 28 2022, 7:10 AM
• max updated the diff for D6014: [native/rust_library] Removing of testing `hello.c` and increase C++ standard to 17 in `build.rs`.

Rebasing on master.

Dec 28 2022, 6:52 AM
• max added a comment to D6014: [native/rust_library] Removing of testing `hello.c` and increase C++ standard to 17 in `build.rs`.
In D6014#180778, @jon wrote:

We should probably rerun the build if the protos or lib.rs change

println!("cargo:rerun-if-changed=src/lib.rs");
println!("cargo:rerun-if-changed=../../shared/protos/identity.proto");
println!("cargo:rerun-if-changed=../../shared/protos/tunnelbroker.proto");
Dec 28 2022, 6:34 AM
• max updated the diff for D6014: [native/rust_library] Removing of testing `hello.c` and increase C++ standard to 17 in `build.rs`.

Adding of rerun-if-changed for proto files and lib.rs.

Dec 28 2022, 6:33 AM
• max added a comment to D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.
In D5947#181356, @tomek wrote:

Shouldn't we use nonce name also here? D5999

Dec 28 2022, 6:27 AM
• max updated the diff for D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.

Renaming a function and rebasing on parent changes.

Dec 28 2022, 6:27 AM

Dec 27 2022

• max closed D5931: [services/commtest] Tunnelbroker - Adding the API integration tests call function.
Dec 27 2022, 9:57 AM
• max committed rCOMMdefc668d683c: [services/commtest] Tunnelbroker - Adding the API integration tests call… (authored by • max).
[services/commtest] Tunnelbroker - Adding the API integration tests call…
Dec 27 2022, 9:57 AM
• max updated the diff for D5931: [services/commtest] Tunnelbroker - Adding the API integration tests call function.

Rebasing and merging.

Dec 27 2022, 9:40 AM
• max closed D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function.
Dec 27 2022, 9:38 AM
• max committed rCOMMd64f7d4d179c: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function (authored by • max).
[services/commtest] Tunnelbroker - Adding `deviceID` validation check function
Dec 27 2022, 9:38 AM
• max updated the diff for D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function.

Rebasing and merging with the master changes.

Dec 27 2022, 7:20 AM
• max closed D5928: [services/commtest] Tunnelbroker - Adding the tonic client builder function.
Dec 27 2022, 7:17 AM
• max committed rCOMM89b1b3578fcf: [services/commtest] Tunnelbroker - Adding the tonic client builder function (authored by • max).
[services/commtest] Tunnelbroker - Adding the tonic client builder function
Dec 27 2022, 7:17 AM
• max updated the diff for D5946: [services] Tunnelbroker - Expose string to be signed to the Rust.

Changing the function name from getStringToSign to getSavedNonceToSign which will be more self describing and based on the D5947#181356 comment.

Dec 27 2022, 7:16 AM
• max added a comment to D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function.
In D5929#178691, @jon wrote:

Would really like to see these tests get added to the CI. They are pretty expensive to run locally.

Dec 27 2022, 7:05 AM
• max updated the diff for D5928: [services/commtest] Tunnelbroker - Adding the tonic client builder function.

Rebasing on master changes.

Dec 27 2022, 7:00 AM
• max closed D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.
Dec 27 2022, 6:57 AM
• max committed rCOMM73fe7a8927a1: [services/commtest] Tunnelbroker - Adding of helper function for the… (authored by • max).
[services/commtest] Tunnelbroker - Adding of helper function for the…
Dec 27 2022, 6:57 AM
• max updated the diff for D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.

Removing of the dead commit to fix merging.

Dec 27 2022, 6:43 AM
• max updated the diff for D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.

Rebasing and fix merging.

Dec 27 2022, 6:22 AM
• max closed D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Dec 27 2022, 6:17 AM
• max committed rCOMM5b7c49cb858a: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native… (authored by • max).
[native/rust_library] Add Tunnelbroker protobuf file compilation to the native…
Dec 27 2022, 6:17 AM
• max closed D5944: [services] Tunnelbroker - Adding of the `base64` crate to dependencies.
Dec 27 2022, 6:15 AM
• max committed rCOMM3c34a2e014ba: [services] Tunnelbroker - Adding of the `base64` crate to dependencies (authored by • max).
[services] Tunnelbroker - Adding of the `base64` crate to dependencies
Dec 27 2022, 6:15 AM
• max updated the diff for D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.

Rebasing on master.

Dec 27 2022, 6:04 AM
• max closed D5927: [services/commtest] Tunnelbroker - Adding of helper function for the string signing with the private key.
Dec 27 2022, 5:58 AM
• max committed rCOMM49c7d86bc331: [services/commtest] Tunnelbroker - Adding of helper function for the string… (authored by • max).
[services/commtest] Tunnelbroker - Adding of helper function for the string…
Dec 27 2022, 5:58 AM
• max closed D5837: [services/commtest] Tunnelbroker - Adding of helper function for the `SessionSignature` client request.
Dec 27 2022, 5:44 AM
• max committed rCOMM11eb2f8b3d66: [services/commtest] Tunnelbroker - Adding of helper function for the… (authored by • max).
[services/commtest] Tunnelbroker - Adding of helper function for the…
Dec 27 2022, 5:44 AM
• max updated the diff for D5837: [services/commtest] Tunnelbroker - Adding of helper function for the `SessionSignature` client request.

Rebasing on master.

Dec 27 2022, 5:25 AM
• max added inline comments to D5931: [services/commtest] Tunnelbroker - Adding the API integration tests call function.
Dec 27 2022, 5:24 AM
• max updated the diff for D5931: [services/commtest] Tunnelbroker - Adding the API integration tests call function.

Rebasing on master.

Dec 27 2022, 5:22 AM
• max added inline comments to D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function.
Dec 27 2022, 5:06 AM
• max updated the diff for D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function.

Change the Result to be an anyhow.

Dec 27 2022, 5:04 AM
• max added inline comments to D5837: [services/commtest] Tunnelbroker - Adding of helper function for the `SessionSignature` client request.
Dec 27 2022, 4:55 AM
• max updated the diff for D5837: [services/commtest] Tunnelbroker - Adding of helper function for the `SessionSignature` client request.

Make a return shorter.

Dec 27 2022, 4:54 AM
• max closed D5926: [services/commtest] Adding of openssl, base64, anyhow to dependencies.
Dec 27 2022, 4:52 AM
• max committed rCOMM8ab6a820b421: [services/commtest] Adding of openssl, base64, anyhow to dependencies (authored by • max).
[services/commtest] Adding of openssl, base64, anyhow to dependencies
Dec 27 2022, 4:52 AM
• max published D6040: [native/rust_library] Tunnelbroker client - Adding of the `get_new_session_id` function for review.
Dec 27 2022, 3:52 AM
• max published D6039: [native/rust_library] Tunnelbroker client - Adding of the `get_nonce_to_sign` function for review.
Dec 27 2022, 3:52 AM

Dec 23 2022

• max updated the diff for D6000: [native/rust_library] Adding unit test for the `sign_string_with_private_key` function.

Change STRING_TO_BE_SIGNED to NONCE.

Dec 23 2022, 10:52 AM
• max added inline comments to D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools.
Dec 23 2022, 10:50 AM
• max updated the diff for D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools.

Change string_to_be_signed to be nonce.

Dec 23 2022, 10:49 AM
• max added inline comments to D5926: [services/commtest] Adding of openssl, base64, anyhow to dependencies.
Dec 23 2022, 10:14 AM
• max added inline comments to D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Dec 23 2022, 9:56 AM
• max published D6014: [native/rust_library] Removing of testing `hello.c` and increase C++ standard to 17 in `build.rs` for review.
Dec 23 2022, 9:52 AM
• max added a comment to D5969: [native/rust_library] Adding CXX bridge names for C++ Identity service client functions.

Adding @tomek for a final pass as this change touches JSI, and C++ native side names.

Dec 23 2022, 9:16 AM
• max added a reviewer for D5969: [native/rust_library] Adding CXX bridge names for C++ Identity service client functions: tomek.
Dec 23 2022, 9:15 AM
• max added a comment to D5949: [services] Tunnelbroker - Remove `cryptopp` from dependencies.

Adding @ashoat for a final pass because this diff touches dependencies.

Dec 23 2022, 8:08 AM
• max added a reviewer for D5949: [services] Tunnelbroker - Remove `cryptopp` from dependencies: ashoat.
Dec 23 2022, 8:08 AM
• max added a comment to D5944: [services] Tunnelbroker - Adding of the `base64` crate to dependencies.

Adding @ashoat for a final pass because this diff touches dependencies.

Dec 23 2022, 8:07 AM
• max added a reviewer for D5944: [services] Tunnelbroker - Adding of the `base64` crate to dependencies: ashoat.
Dec 23 2022, 8:07 AM
• max updated the diff for D5948: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase.

Rebasing on master.

Dec 23 2022, 7:56 AM
• max updated the diff for D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.

Rebasing on master.

Dec 23 2022, 7:55 AM
• max updated the diff for D5944: [services] Tunnelbroker - Adding of the `base64` crate to dependencies.

Rebasing on master.

Dec 23 2022, 7:52 AM
• max added a comment to D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.

Adding @tomek for a final pass.

Dec 23 2022, 7:50 AM
• max added a reviewer for D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification: tomek.
Dec 23 2022, 7:50 AM
• max added a comment to D5948: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase.

Adding @tomek for a final pass as this is a C++ part of the codebase.

Dec 23 2022, 7:49 AM
• max added a reviewer for D5948: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase: tomek.
Dec 23 2022, 7:48 AM
• max updated the diff for D5949: [services] Tunnelbroker - Remove `cryptopp` from dependencies.

Rebasing on master changes.

Dec 23 2022, 7:47 AM

Dec 22 2022

• max added inline comments to D5945: [services] Tunnelbroker - Adding signed string verification function.
Dec 22 2022, 11:39 AM
• max updated the diff for D5945: [services] Tunnelbroker - Adding signed string verification function.

Removing of unwrap().

Dec 22 2022, 11:38 AM
• max planned changes to D5945: [services] Tunnelbroker - Adding signed string verification function.
Dec 22 2022, 8:26 AM
• max updated the test plan for D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools.
Dec 22 2022, 8:21 AM
• max retitled D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client from [native] Add Tunnelbroker protobuf file compilation to the native client to [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Dec 22 2022, 8:20 AM
• max published D6000: [native/rust_library] Adding unit test for the `sign_string_with_private_key` function for review.
Dec 22 2022, 8:19 AM
• max published D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools for review.
Dec 22 2022, 8:15 AM
• max published D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies for review.
Dec 22 2022, 8:03 AM
• max published D5997: [native/rust_library] Adding of the Tunnelbroker Tonic client initialization for review.
Dec 22 2022, 7:54 AM
• max added a comment to D5926: [services/commtest] Adding of openssl, base64, anyhow to dependencies.

Adding @ashoat for a final pass.

Dec 22 2022, 6:59 AM
• max added a reviewer for D5926: [services/commtest] Adding of openssl, base64, anyhow to dependencies: ashoat.
Dec 22 2022, 6:59 AM
• max requested review of D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Dec 22 2022, 6:51 AM
• max planned changes to D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Dec 22 2022, 6:36 AM
• max updated the diff for D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.

Rebasing on master.

Dec 22 2022, 6:36 AM
• max updated the diff for D5969: [native/rust_library] Adding CXX bridge names for C++ Identity service client functions.

Rebasing and merging on master changes.

Dec 22 2022, 6:23 AM

Dec 21 2022

• max added inline comments to D5928: [services/commtest] Tunnelbroker - Adding the tonic client builder function.
Dec 21 2022, 6:42 AM
• max updated the diff for D5928: [services/commtest] Tunnelbroker - Adding the tonic client builder function.

Fixing a port environment variable, adding default value.

Dec 21 2022, 6:40 AM
• max updated the summary of D5928: [services/commtest] Tunnelbroker - Adding the tonic client builder function.
Dec 21 2022, 6:39 AM
• max published D5949: [services] Tunnelbroker - Remove `cryptopp` from dependencies for review.

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

Dec 21 2022, 6:07 AM
• max published D5948: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase for review.

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

Dec 21 2022, 6:07 AM
• max published D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification for review.

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

Dec 21 2022, 6:07 AM
• max published D5946: [services] Tunnelbroker - Expose string to be signed to the Rust for review.

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

Dec 21 2022, 6:06 AM
• max published D5945: [services] Tunnelbroker - Adding signed string verification function for review.

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

Dec 21 2022, 6:06 AM
• max published D5944: [services] Tunnelbroker - Adding of the `base64` crate to dependencies for review.

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

Dec 21 2022, 6:05 AM
• max published D5969: [native/rust_library] Adding CXX bridge names for C++ Identity service client functions for review.
Dec 21 2022, 6:04 AM
• max published D5968: [native/rust_library] Refactor Tonic client utility function names for Identity service for review.
Dec 21 2022, 6:04 AM
• max published D5967: [native/rust_library] Refactor Tonic client function name for Identity service for review.
Dec 21 2022, 6:03 AM
• max planned changes to D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Dec 21 2022, 3:49 AM
• max updated the diff for D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.

Rebasing on master changes.

Dec 21 2022, 3:49 AM

Dec 20 2022

• max requested review of D5927: [services/commtest] Tunnelbroker - Adding of helper function for the string signing with the private key.
Dec 20 2022, 9:32 AM
• max updated the diff for D5931: [services/commtest] Tunnelbroker - Adding the API integration tests call function.

Rebasing on parent changes, removing unwrap() in a favor of anyhow.

Dec 20 2022, 9:31 AM
• max planned changes to D5927: [services/commtest] Tunnelbroker - Adding of helper function for the string signing with the private key.
Dec 20 2022, 9:24 AM
• max updated the diff for D5927: [services/commtest] Tunnelbroker - Adding of helper function for the string signing with the private key.

Fixing MessageDigest, using Anyhow::Result to pass the error to the caller.

Dec 20 2022, 9:24 AM
• max planned changes to D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.
Dec 20 2022, 5:52 AM
• max updated the diff for D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.

Rebasing on the master changes.

Dec 20 2022, 5:52 AM
• max added a comment to D5758: [Nix] Add script to start/stop tunnelbroker services.
In D5758#178355, @jon wrote:

I think using the same names, but with and without .sh for the comm-dev file makes a mess

This is a compromise for getting the shellchecks, but having the correct command name in the shell (e.g. comm-dev services start instead of comm-dev.sh services start).

Created https://linear.app/comm/issue/ENG-2484 to address this

Dec 20 2022, 3:29 AM

Dec 19 2022

• max closed D5942: [docs] Removing deprecated gRPC codegen from the documentation.
Dec 19 2022, 10:19 AM
• max committed rCOMM4ddb4b60da6d: [docs] Removing deprecated gRPC codegen from the documentation (authored by • max).
[docs] Removing deprecated gRPC codegen from the documentation
Dec 19 2022, 10:19 AM
First
Prev
Next