We've talked about that issue with Tomek. We've tried to find better solution, but it seems hard and we don't get huge benefits here.
Tomek has brought up issue, that calling useEffect that changes state will cause rerender of component. It's single rerender and every value above is memoised, so it shouldn't be huge overhead.
We've decided to go with current solution then.

Added flag keepUpdatingThreadMembers which is set false on mounting tooltip. It causes users to threadMemebrs to get frozen.

Agree. We need to look on all files that import that .css file and look if those styles aren't used anywhere.

I think they're not. They also don't fail on local tests. I'm not sure why. When I run yarn test in web, tests in tooltip failed as well, and they were failing for a long time I guess.

That's exactly the way we handle it on native. I thought that we would want to have some consistency between them. We also handle email-like, and not-alphanumeric usernames on submit (on web).

Reverted changes in utility function. That was unnecessary.
We still get unkonw error when password is empty on web.

Sorry, I missed your comments after build fail and tried to fix it myself. That's why I haven't addressed them.

Looks good besides nit from @michal

Fix - make viewer param optional.

Used scrollTo.
Added tests and run them.
There were some problems that I solved locally using fixes from here: https://linear.app/comm/issue/ENG-2654/problems-with-jest
I haven't pushed those fixes anywhere as it is to be discussed yet, but I found it acceptable to
push tests even if they fail currently (due to lack of mocks as mentioned on linear).
Similar thing is happening to tooltip-utils.test.js tests and it was ignored in the past I guess.

Responded to inlines and fixed code.
Tested everything once again.

Added close to accept function to simplify logic in other places in diff 11/13.

rebased

Responded to inlines.

Changed name to dividend as it is the thing that is divided.
Added test for negative dividend.

It felt cleaner to has it closed in utils funtion.

I also needed to add extra checks in 2 places, because on web when password is empty it was checked on a server side in one of validation-utils.js functions. This caused another unknown error, but is fixed now.

You're all right. I'm not sure what happened here.
It works now. Tested on web and native. I runned into huge problems with testing on older versions and wasted a lot of time on trying to do it. I'm not sure what approach should we take here?
I have analyzed the code and in really old versions it shoudl still work, but I feel like it's insufficient, but I don't want to waste more time figuring out how to run old version of client.

Fixed problems. Took wrong aproach in the beginning.

Rebased

Renamed onclick to execute. Fixed nits.

Moved function to lib and added some simple tests. Made sure they pass.

Changed void to mixed.

Utility function changed name.

Renamed function and added comment.

You're right I'm updating the diff right now. Sorry for that, I meant to do it, but only responded to comment.

Spotted a bug: We were not setting chosen position to 0, when suggested users changed.

Destructure as Inka suggested.

Responding to both comments. I should probably call it least positive residue as defined here: https://en.wikipedia.org/wiki/Modulo_operation.
We are not concerned with negative modulus as we just need that function to "wrap" numbers between 0 and <MODULUS - 1>.

Made function arguments read only

Returned early.

rebase

rebase

Spotted bug later on, that allowed user to accept @-ing with enter when overlay was no longer visible. Clearing callbacks on unmount fixes it.

Spotted uncaught bug while testing later on - it caused to freeze users list in wrong situations. Moved frozen users to state in context. It works now.

Responding to questions but need to abandon revision to split diffs into smaller ones. Also I introduce huge changes to code so it would be beneficial to discuss in fresh diff

Rebasing

The thing about scrollbar is intended, we discussed it in linear task with dave and agreed on it being better. Moving all tiles to the left created weird empty space on the right when scrollbar was not visible.

Addressed issues in code and answered to comments.

Addressed comment.

One more rename

Addressed Ashoat's comments.