Page MenuHomePhabricator
Feed Advanced Search

Jan 25 2023

max updated the diff for D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.

Forcing ot install protoc out of buildkite.

Jan 25 2023, 10:14 AM
max planned changes to D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
Jan 25 2023, 9:59 AM
max updated the diff for D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.

Fixing the install protoc script running.

Jan 25 2023, 9:59 AM
max planned changes to D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
Jan 25 2023, 9:28 AM
max updated the diff for D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.

Installing protoc by the script.

Jan 25 2023, 9:27 AM
max planned changes to D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
Jan 25 2023, 6:27 AM
max published D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies for review.
Jan 25 2023, 6:27 AM
max added inline comments to D5796: [keyserver] implement registerUser rpc with napi-rs/tonic/opaque-ke.
Jan 25 2023, 6:20 AM
max added a comment to D5796: [keyserver] implement registerUser rpc with napi-rs/tonic/opaque-ke.

@max are you using yarn arcpatch?

Jan 25 2023, 5:38 AM
max added inline comments to D6388: [blob][backup] Remove blob_hash from log span.
Jan 25 2023, 5:33 AM
max added inline comments to D6251: [services] Tunnelbroker - Add skip authentication config parameter.
Jan 25 2023, 5:29 AM
max updated the diff for D6251: [services] Tunnelbroker - Add skip authentication config parameter.

Return in a more elegant way.

Jan 25 2023, 5:26 AM
max added 1 blocking reviewer(s) for D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function: varun.
Jan 25 2023, 4:59 AM
max added a comment to D6279: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf.

Adding @varun for a final pass.

Jan 25 2023, 4:59 AM
max added a reviewer for D6279: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf: varun.
Jan 25 2023, 4:59 AM
max added a comment to D6278: [tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the `.gitignore`.

Adding @ashoat for a final pass.

Jan 25 2023, 4:58 AM
max added a reviewer for D6278: [tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the `.gitignore`: ashoat.
Jan 25 2023, 4:58 AM
max added a comment to D6277: [tunnelbroker-client] Creating a Cargo project file.

Adding @tomek for a final pass.

Jan 25 2023, 4:58 AM
max added a reviewer for D6277: [tunnelbroker-client] Creating a Cargo project file: tomek.
Jan 25 2023, 4:57 AM
max added inline comments to D6331: [native] Make it possible to swipe back from anywhere.
Jan 25 2023, 4:55 AM
max added inline comments to D6282: [buildkite] Adding CI test for the Tunnelbroker client shared library.
Jan 25 2023, 4:49 AM
max updated the diff for D6282: [buildkite] Adding CI test for the Tunnelbroker client shared library.

Minimize cargo command. Rebasing.

Jan 25 2023, 4:48 AM
max added a comment to D5796: [keyserver] implement registerUser rpc with napi-rs/tonic/opaque-ke.

Trust the CI, but can't patch on this diff from the latest master:

 Cherry Pick Failed!
 Exception 
Command failed with error #1!
COMMAND
git cherry-pick -- arcpatch-D6261
Jan 25 2023, 3:04 AM
max accepted D5796: [keyserver] implement registerUser rpc with napi-rs/tonic/opaque-ke.
Jan 25 2023, 12:51 AM

Jan 18 2023

max planned changes to D6282: [buildkite] Adding CI test for the Tunnelbroker client shared library.
Jan 18 2023, 5:38 AM

Jan 17 2023

max planned changes to D6251: [services] Tunnelbroker - Add skip authentication config parameter.
Jan 17 2023, 7:24 AM
max published D6282: [buildkite] Adding CI test for the Tunnelbroker client shared library for review.
Jan 17 2023, 7:22 AM
max published D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function for review.
Jan 17 2023, 7:16 AM
max published D6279: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf for review.
Jan 17 2023, 7:10 AM
max published D6278: [tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the `.gitignore` for review.
Jan 17 2023, 7:05 AM
max published D6277: [tunnelbroker-client] Creating a Cargo project file for review.
Jan 17 2023, 7:00 AM

Jan 12 2023

max reopened D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.

I'll reopen this diff, but it will not be landed until the Rust OpenSSL problem on native will be resolved or we will replace the verifying function in D5999 without using OpenSSL. In this case, it will be abandoned, but for now it's better to keep it open to not to forget the state of the stack.

Jan 12 2023, 8:29 AM
max published D6253: [services] Tunnelbroker - Skipping session checks in a stream when `skip_authentication` flag is set for review.
Jan 12 2023, 8:22 AM
max published D6252: [services] Tunnelbroker - Expose `isConfigParameterSet` function to the Rust for review.
Jan 12 2023, 8:22 AM
max published D6251: [services] Tunnelbroker - Add skip authentication config parameter for review.
Jan 12 2023, 8:21 AM

Jan 5 2023

max closed D6173: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies".
Jan 5 2023, 9:17 AM
max committed rCOMM5f4cc9324721: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies" (authored by max).
[native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies"
Jan 5 2023, 9:17 AM
max accepted D6169: [keyserver] rename node addon.

As we are going to use a unified rust library for the gRPC client, looks good to me to make these changes.

Jan 5 2023, 2:39 AM
max published D6173: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies" for review.
Jan 5 2023, 1:48 AM
max added a reverting change for D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies: D6173: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies".
Jan 5 2023, 1:42 AM
max added a reverting change for rCOMMa5ec4c770533: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies: D6173: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies".
Jan 5 2023, 1:42 AM

Jan 4 2023

max closed D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.
Jan 4 2023, 9:39 AM
max committed rCOMMa5ec4c770533: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies (authored by max).
[native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies
Jan 4 2023, 9:39 AM
max updated the diff for D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.

Rebasing on master changes.

Jan 4 2023, 7:12 AM

Dec 29 2022

max reopened D6000: [native/rust_library] Adding unit test for the `sign_string_with_private_key` function.

This diff will be landed after ENG-2563 will be resolved.

Dec 29 2022, 8:13 AM
max reopened D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools.

This diff will be landed after ENG-2563 will be resolved.

Dec 29 2022, 8:12 AM
max closed D6089: [native] Reverting D5999 and D6000.
Dec 29 2022, 8:12 AM
max added a reverting change for D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools: rCOMMe01e78fb8b04: [native] Reverting D5999 and D6000.
Dec 29 2022, 8:12 AM
max added a reverting change for D6000: [native/rust_library] Adding unit test for the `sign_string_with_private_key` function: rCOMMe01e78fb8b04: [native] Reverting D5999 and D6000.
Dec 29 2022, 8:12 AM
max committed rCOMMe01e78fb8b04: [native] Reverting D5999 and D6000 (authored by max).
[native] Reverting D5999 and D6000
Dec 29 2022, 8:12 AM
max removed 1 blocking reviewer(s) for D6089: [native] Reverting D5999 and D6000: tomek.
Dec 29 2022, 3:31 AM
max added a comment to D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.

This diff will be landed after ENG-2563 will be resolved.

Dec 29 2022, 2:50 AM
max reopened D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.
Dec 29 2022, 2:47 AM
max published D6089: [native] Reverting D5999 and D6000 for review.
Dec 29 2022, 2:43 AM
max added a reverting change for D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools: D6089: [native] Reverting D5999 and D6000.
Dec 29 2022, 2:43 AM
max added a reverting change for D6000: [native/rust_library] Adding unit test for the `sign_string_with_private_key` function: D6089: [native] Reverting D5999 and D6000.
Dec 29 2022, 2:43 AM
Herald added a reviewer for D4652: [draft] [services] Blob - Add Logs: jon.

I think this diff should be canceled because the Blob service going to Rust now. I can commandeer and close it if @tomek doesn't mind.

Dec 29 2022, 2:24 AM
Herald added a reviewer for D4653: [draft] [services] Backup - Add Logs: jon.

I think this diff should be canceled because the Backup service going to Rust now. I can commandeer and close it if @tomek doesn't mind.

Dec 29 2022, 2:23 AM
max updated the diff for D6040: [native/rust_library] Tunnelbroker client - Adding of the `get_new_session_id` function.

Rebasing and merging.

Dec 29 2022, 2:19 AM
max updated the diff for D6039: [native/rust_library] Tunnelbroker client - Adding of the `get_nonce_to_sign` function.

Rebasing and merging.

Dec 29 2022, 2:18 AM
max closed D6000: [native/rust_library] Adding unit test for the `sign_string_with_private_key` function.
Dec 29 2022, 2:09 AM
max committed rCOMMe7fa7d37a224: [native/rust_library] Adding unit test for the `sign_string_with_private_key`… (authored by max).
[native/rust_library] Adding unit test for the `sign_string_with_private_key`…
Dec 29 2022, 2:09 AM
max closed D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools.
Dec 29 2022, 2:08 AM
max committed rCOMMb637b2bcb09c: [native/rust_library] Adding `sign_string_with_private_key` function to crypto… (authored by max).
[native/rust_library] Adding `sign_string_with_private_key` function to crypto…
Dec 29 2022, 2:08 AM

Dec 28 2022

max updated the diff for D6000: [native/rust_library] Adding unit test for the `sign_string_with_private_key` function.

Rebasing and merging on master changes.

Dec 28 2022, 11:08 AM
max updated the diff for D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools.

Rebasing and merging on master changes.

Dec 28 2022, 11:05 AM
max closed D5997: [native/rust_library] Adding of the Tunnelbroker Tonic client initialization.
Dec 28 2022, 11:03 AM
max committed rCOMM772b92df08f0: [native/rust_library] Adding of the Tunnelbroker Tonic client initialization (authored by max).
[native/rust_library] Adding of the Tunnelbroker Tonic client initialization
Dec 28 2022, 11:03 AM
max closed D5949: [services] Tunnelbroker - Remove `cryptopp` from dependencies.
Dec 28 2022, 10:43 AM
max committed rCOMM578d3d993813: [services] Tunnelbroker - Remove `cryptopp` from dependencies (authored by max).
[services] Tunnelbroker - Remove `cryptopp` from dependencies
Dec 28 2022, 10:43 AM
max updated the diff for D5997: [native/rust_library] Adding of the Tunnelbroker Tonic client initialization.

Merging on master changes.

Dec 28 2022, 10:39 AM
max closed D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.
Dec 28 2022, 10:36 AM
max committed rCOMMd2fd0f2e9fba: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies (authored by max).
[native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies
Dec 28 2022, 10:36 AM
max closed D5969: [native/rust_library] Adding CXX bridge names for C++ Identity service client functions.
Dec 28 2022, 10:35 AM
max committed rCOMM85d153794a09: [native/rust_library] Adding CXX bridge names for C++ Identity service client… (authored by max).
[native/rust_library] Adding CXX bridge names for C++ Identity service client…
Dec 28 2022, 10:35 AM
max updated the diff for D5949: [services] Tunnelbroker - Remove `cryptopp` from dependencies.

Merging with master changes.

Dec 28 2022, 10:31 AM
max closed D5948: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase.
Dec 28 2022, 10:30 AM
max committed rCOMM506641f4a271: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase (authored by max).
[services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase
Dec 28 2022, 10:30 AM
max added inline comments to D5969: [native/rust_library] Adding CXX bridge names for C++ Identity service client functions.
Dec 28 2022, 10:21 AM
max updated the diff for D5969: [native/rust_library] Adding CXX bridge names for C++ Identity service client functions.

Removing moving of uses in the header.

Dec 28 2022, 10:19 AM
max updated the diff for D5948: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase.

Rebasing on master and merging fix.

Dec 28 2022, 10:09 AM
max added a comment to D5948: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase.
In D5948#181364, @tomek wrote:

Why is the verification moved outside the newSessionHandler?

Dec 28 2022, 10:02 AM
max closed D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.
Dec 28 2022, 8:31 AM
max committed rCOMMbe572df58390: [services] Tunnelbroker - Modify server handler to use Rust signature… (authored by max).
[services] Tunnelbroker - Modify server handler to use Rust signature…
Dec 28 2022, 8:31 AM
max closed D5968: [native/rust_library] Refactor Tonic client utility function names for Identity service.
Dec 28 2022, 8:20 AM
max committed rCOMM7b335fb66032: [native/rust_library] Refactor Tonic client utility function names for Identity… (authored by max).
[native/rust_library] Refactor Tonic client utility function names for Identity…
Dec 28 2022, 8:20 AM
max updated the diff for D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.

Merging with the master changes.

Dec 28 2022, 8:18 AM
max closed D5946: [services] Tunnelbroker - Expose string to be signed to the Rust.
Dec 28 2022, 8:14 AM
max committed rCOMM2a6ad8ddbc0d: [services] Tunnelbroker - Expose string to be signed to the Rust (authored by max).
[services] Tunnelbroker - Expose string to be signed to the Rust
Dec 28 2022, 8:14 AM
max updated the diff for D5968: [native/rust_library] Refactor Tonic client utility function names for Identity service.

Fixing merging, rebasing on master.

Dec 28 2022, 8:04 AM
max closed D5967: [native/rust_library] Refactor Tonic client function name for Identity service.
Dec 28 2022, 7:58 AM
max committed rCOMMefc75acf3796: [native/rust_library] Refactor Tonic client function name for Identity service (authored by max).
[native/rust_library] Refactor Tonic client function name for Identity service
Dec 28 2022, 7:58 AM
max updated the diff for D5946: [services] Tunnelbroker - Expose string to be signed to the Rust.

Fix merging, rebasing on master.

Dec 28 2022, 7:57 AM
max closed D5945: [services] Tunnelbroker - Adding signed string verification function.
Dec 28 2022, 7:55 AM
max committed rCOMMfedfe134b117: [services] Tunnelbroker - Adding signed string verification function (authored by max).
[services] Tunnelbroker - Adding signed string verification function
Dec 28 2022, 7:55 AM
max updated the diff for D5967: [native/rust_library] Refactor Tonic client function name for Identity service.

Rebasing.

Dec 28 2022, 7:39 AM
max updated the diff for D5945: [services] Tunnelbroker - Adding signed string verification function.

Merging fix.

Dec 28 2022, 7:36 AM
max added a comment to D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.

Adding @ashoat for a final pass.

Dec 28 2022, 7:27 AM
max added a reviewer for D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies: ashoat.
Dec 28 2022, 7:26 AM
max updated the diff for D5967: [native/rust_library] Refactor Tonic client function name for Identity service.

Fix merging and rebasing on master.

Dec 28 2022, 7:23 AM