rebase fix import
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 29 2024
Jan 29 2024
rebase: fix import
atul updated the diff for D10731: [lib] Expand `RoleInfo` to `LegacyRoleInfo | MinimallyEncodedRoleInfo`.
fix import
rebase
rebase
rebase
rebase
atul updated the diff for D10789: [lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo`.
rebase
rebase
rebase
atul updated the diff for D10731: [lib] Expand `RoleInfo` to `LegacyRoleInfo | MinimallyEncodedRoleInfo`.
rebase
atul committed rCOMMf36b8ff65079: Rename `MinimallyEncodedRelativeMemberInfo` to `RelativeMemberInfo` (authored by atul).
Rename `MinimallyEncodedRelativeMemberInfo` to `RelativeMemberInfo`
atul committed rCOMM73d2fd7b4e3f: [lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase (authored by atul).
[lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase
atul committed rCOMMcb3ac5eb2528: [web][native] Remove client usages of `LegacyRelativeMemberInfo` (authored by atul).
[web][native] Remove client usages of `LegacyRelativeMemberInfo`
atul committed rCOMMb1012bec65f2: [lib] First pass at removing `LegacyRelativeMemberInfo` from `lib` (authored by atul).
[lib] First pass at removing `LegacyRelativeMemberInfo` from `lib`
atul added a comment to D10729: [lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase.
Double checked for import issues before landing.
atul added a comment to D10730: Rename `MinimallyEncodedRelativeMemberInfo` to `RelativeMemberInfo`.
Double checked for import issues before landing.
Double checked for import issues before landing.
Double checked for import issues before landing.
atul updated the diff for D10730: Rename `MinimallyEncodedRelativeMemberInfo` to `RelativeMemberInfo`.
rebase
atul updated the diff for D10729: [lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase.
rebase
rebase
atul updated the diff for D10727: [lib] First pass at removing `LegacyRelativeMemberInfo` from `lib`.
rebase
atul committed rCOMM874cc72b1f49: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo |… (authored by atul).
Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo |…
atul added a comment to D10726: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`.
Double checked imports before landing.
atul updated the diff for D10726: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`.
re-introduce fixes
atul updated the diff for D10726: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`.
resolve merge conflicts
[lib] Remove unused utilities and validators
Double checked that there were no import issues before landing.
In D10703#311383, @ashoat wrote:I updated this diff to disable WAL on web. If you @ashoat or @atul meant to disable WAL across all platforms just let me know and I will change the behaviour.
I'm not sure if @atul's suggestion in this comment was meant to be web-only or across the whole codebase.
Personally, I don't feel strongly. Are there any risks in having a different approach on web vs. native?
atul updated the test plan for D10826: [web] Migrate existing `ClientDBThreadInfo`s on `web` to be minimally encoded.
atul added a comment to D10826: [web] Migrate existing `ClientDBThreadInfo`s on `web` to be minimally encoded.
Unmarking as DRAFT, think this is good for review.
atul retitled D10826: [web] Migrate existing `ClientDBThreadInfo`s on `web` to be minimally encoded from [DRAFT][web] Migrate existing `ClientDBThreadInfo`s on `web` to be minimally encoded to [web] Migrate existing `ClientDBThreadInfo`s on `web` to be minimally encoded.
Jan 26 2024
Jan 26 2024
rebase
atul committed rCOMM51c38a95316e: [lib] Remove simple usages of `LegacyRawThreadInfo` (authored by atul).
[lib] Remove simple usages of `LegacyRawThreadInfo`
rebase
atul committed rCOMMe231ab33123b: [lib] Remove `LegacyThreadInfo` and `legacyThreadInfoValidator` (authored by atul).
[lib] Remove `LegacyThreadInfo` and `legacyThreadInfoValidator`
Double checked that import ordering issues were resolved before landing.
rebase
atul added inline comments to D10721: [lib] Remove `LegacyThreadInfo` and `legacyThreadInfoValidator`.
atul added inline comments to D10721: [lib] Remove `LegacyThreadInfo` and `legacyThreadInfoValidator`.
Dang rebased off of the wrong branch for this (everything is correct except import ordering). Will double check rest of stack to make sure diffs are updated properly.
atul committed rCOMM9c89cbd44f3f: [lib] Remove `LegacyThreadInfo`-related type utilities (authored by atul).
[lib] Remove `LegacyThreadInfo`-related type utilities
rebase
atul committed rCOMM0173927531a1: [lib] Remove branching from `threadInfoFromRawThreadInfo(...)` (authored by atul).
[lib] Remove branching from `threadInfoFromRawThreadInfo(...)`
land
atul added inline comments to D10718: [lib] Remove branching from `threadInfoFromRawThreadInfo(...)`.
Jan 25 2024
Jan 25 2024
What does "vip" mean in this situation? Not seeing anything in the linked Linear issue.
atul updated the test plan for D10812: Rename `useDisconnectedBarVisibilityHandler` to `useKeyserverReachabilityHandler`.
atul requested review of D10812: Rename `useDisconnectedBarVisibilityHandler` to `useKeyserverReachabilityHandler`.
Updated Test Plan
atul requested review of D10818: [lib] Add `threadInfoFromRawThreadInfo` test to `thread-utils.test`.
In D10810#311730, @ashoat wrote:Can you remove the extra newlines before landing? I'm assuming they're not intentional
Jan 24 2024
Jan 24 2024
atul requested review of D10811: [web][native] Remove branching on `minimallyEncoded` in `redux-setup`.
atul requested review of D10807: [lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos`.
atul requested review of D10805: Rename `MinimallyEncodedThreadCurrentUserInfo` to `ThreadCurrentUserInfo`.
rebase
rebase
rebase
rebase
rebase
rebase
atul updated the diff for D10789: [lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo`.
rebase
Seems reasonable, thanks for pointing out other places in the codebase that use that pattern.
Jan 23 2024
Jan 23 2024
rebase
rebase
rebase
atul updated the diff for D10789: [lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo`.
rebase
atul updated the diff for D10789: [lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo`.
rebase
rebase
rebase
atul updated the diff for D10731: [lib] Expand `RoleInfo` to `LegacyRoleInfo | MinimallyEncodedRoleInfo`.
rebase
atul updated the diff for D10730: Rename `MinimallyEncodedRelativeMemberInfo` to `RelativeMemberInfo`.
rebase
atul updated the diff for D10729: [lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase.
rebase
rebase
atul updated the diff for D10727: [lib] First pass at removing `LegacyRelativeMemberInfo` from `lib`.
rebase
atul updated the diff for D10726: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`.
rebase
rebaser
rebase