Page MenuHomePhabricator
Differential D10720

[lib] Remove `LegacyThreadInfo`-related type utilities
ClosedPublic
Actions

Authored by atul on Jan 18 2024, 11:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 10:59 PM
Unknown Object (File)
Thu, Mar 6, 6:58 PM
Unknown Object (File)
Feb 21 2025, 9:52 PM
Unknown Object (File)
Feb 21 2025, 9:52 PM
Unknown Object (File)
Feb 21 2025, 9:52 PM
Unknown Object (File)
Feb 21 2025, 9:52 PM
Unknown Object (File)
Feb 21 2025, 9:52 PM
Unknown Object (File)
Feb 21 2025, 9:52 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM9c89cbd44f3f: [lib] Remove `LegacyThreadInfo`-related type utilities
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo
Get rid of minimallyEncode*/decode* utilities.

Depends on D10718

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jan 18 2024, 11:52 AM
atul added a child revision: D10721: [lib] Remove `LegacyThreadInfo` and `legacyThreadInfoValidator`.Jan 18 2024, 11:59 AM
Harbormaster completed remote builds in B25921: Diff 35841.Jan 18 2024, 12:29 PM
atul requested review of this revision.Jan 18 2024, 12:29 PM
ashoat accepted this revision.Jan 21 2024, 9:34 PM
ashoat added inline comments.
lib/types/minimally-encoded-thread-permissions-types.js
12 ↗(On Diff #35841)

Can you revert import ordering changes before landing?

This revision is now accepted and ready to land.Jan 21 2024, 9:34 PM
atul updated this revision to Diff 36071.Jan 23 2024, 2:30 PM

rebase

Harbormaster completed remote builds in B26100: Diff 36071.Jan 23 2024, 2:49 PM
atul updated this revision to Diff 36202.Jan 26 2024, 4:46 PM

rebase

This revision was landed with ongoing or failed builds.Jan 26 2024, 4:48 PM
Closed by commit rCOMM9c89cbd44f3f: [lib] Remove `LegacyThreadInfo`-related type utilities (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9c89cbd44f3f: [lib] Remove `LegacyThreadInfo`-related type utilities.
Harbormaster completed remote builds in B26212: Diff 36202.Jan 26 2024, 5:05 PM
ashoat added a comment.Jan 26 2024, 7:20 PM

Import ordering changes don't appear to have been reverted, but at this point it won't help to revert it since we'd need a separate commit

atul added a comment.Jan 26 2024, 10:47 PM

Dang rebased off of the wrong branch for this (everything is correct except import ordering). Will double check rest of stack to make sure diffs are updated properly.

Revision Contents
Changeset List

Diff 36203

View Options

lib/types/minimally-encoded-thread-permissions-types.js

Show All 14 Linesimport {
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { import {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Linesclass App extends React.PureComponent<Props> {
render(): React.Node { render(): React.Node {
let content; let content;
if (this.props.loggedIn) { if (this.props.loggedIn) {
content = ( content = (
<> <>
<WebEditThreadAvatarProvider> <WebEditThreadAvatarProvider>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<StaffContextProvider>
{this.renderMainContent()} {this.renderMainContent()}
{this.props.modals} {this.props.modals}
</StaffContextProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</WebEditThreadAvatarProvider> </WebEditThreadAvatarProvider>
</> </>
); );
} else { } else {
content = ( content = (
<> <>
{this.renderLoginPage()} {this.renderLoginPage()}
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines