Differential D10639 Authored by atul on Jan 15 2024, 12:40 PM.
Tags None Referenced Files
Subscribers None
Details Summary Part of the work described here: https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo Used IDE "Inline type alias" feature to do this refactor automatically. Read through to make sure there were no issues. Had to insert ? manually for MinimallyEncodedThreadInfo where it was previously ?ThreadInfo. Depends on D10638 Test Plan flow
Diff Detail
Event TimelineComment Actions NOTE: Still need to make some tweaks to thread-utils and thread-selectors before removing ThreadInfo altogether. Will be handled in followup diff. Harbormaster completed remote builds in B25778: Diff 35641.Jan 15 2024, 1:01 PM2024-01-15 13:01:03 (UTC-8) Comment Actions This is going to add a lot of noise to the codebase... what % of these unions do you think you'll be able to "back out" back to just the minimally-encoded variant?
This revision is now accepted and ready to land.Jan 15 2024, 5:41 PM2024-01-15 17:41:14 (UTC-8) Comment Actions
In practice it ended up being ~75+%. They're pretty much fully removed from web/native client except to support old migrations. Unless you're talking about git history noise vs the noise of having multiple types around?
This revision was landed with ongoing or failed builds.Jan 22 2024, 12:36 PM2024-01-22 12:36:28 (UTC-8) Closed by commit rCOMM4b48e731c0a1: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` (authored by atul). · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B26049: Diff 35992.Jan 22 2024, 12:38 PM2024-01-22 12:38:02 (UTC-8) Harbormaster completed remote builds in B26054: Diff 35997.Jan 22 2024, 12:45 PM2024-01-22 12:45:49 (UTC-8) Large DiffThis large diff affects 202 files. Files without inline comments have been collapsed. Expand All Files
Revision Contents
Diff 36000 | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||