Page MenuHomePhabricator

[lib] Update `useResolvedThreadInfos` to remove `LegacyThreadInfo`
ClosedPublic

Authored by atul on Jan 17 2024, 2:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 1:43 AM
Unknown Object (File)
Sat, Nov 2, 1:05 AM
Unknown Object (File)
Wed, Oct 16, 12:42 AM
Unknown Object (File)
Wed, Oct 16, 12:42 AM
Unknown Object (File)
Wed, Oct 16, 12:42 AM
Unknown Object (File)
Wed, Oct 16, 12:42 AM
Unknown Object (File)
Wed, Oct 16, 12:41 AM
Unknown Object (File)
Wed, Oct 16, 12:41 AM
Subscribers
None

Details

Summary

As part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

We want to remove LegacyResolvedThreadInfo altogether.

To start we're updating useResolvedThreadInfos (and related functions) to only handle MinimallyEncodedThreadInfos.

This diff makes that change and addresses the flow issues that arose in lib. Will create separate diffs for web and native, the CI will fail for this diff. Personally would've preferred to include all of them in a single diff that passes CI, but will break it up.

[skip-ci]


Depends on D10655

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Jan 17 2024, 2:28 PM
lib/shared/thread-utils.js
1355–1369 ↗(On Diff #35739)
NOTE: Removed some branching here.
lib/utils/entity-helpers.js
46–57 ↗(On Diff #35739)
NOTE: Removed some branching here.
This revision is now accepted and ready to land.Jan 17 2024, 3:28 PM