Page MenuHomePhabricator
Differential D10673

Remove `LegacyResolvedThreadInfo` from the codebase entirely
ClosedPublic
Actions

Authored by atul on Jan 17 2024, 3:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 3:39 AM
Unknown Object (File)
Thu, Mar 13, 3:19 AM
Unknown Object (File)
Sun, Mar 2, 11:01 AM
Unknown Object (File)
Feb 21 2025, 11:55 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM8baab0e38b7b: Remove `LegacyResolvedThreadInfo` from the codebase entirely
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

Remove last instances of LegacyResolvedThreadInfo from the codebase in all workspaces.

Depends on D10672

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 36051

View Options

lib/components/chat-mention-provider.react.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

lib/shared/markdown.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

lib/shared/mention-utils.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

lib/shared/mention-utils.test.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

lib/types/filter-types.js

Loading...
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/drawer-utils.react.js

Loading...
View Options

native/avatars/thread-avatar.react.js

Loading...
View Options

native/chat/settings/delete-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-avatar.react.js

Loading...
View Options

native/chat/settings/thread-settings-delete-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-name.react.js

Loading...
View Options

web/calendar/entry.react.js

Loading...
View Options

web/markdown/markdown-chat-mention.react.js

Loading...
View Options

web/modals/history/history-entry.react.js

Loading...
View Options

web/navigation-sidebar/community-list-item.react.js

Loading...