Paths

Table of Contentst

Differential D10725

[lib] Remove unused utilities and validators
ClosedPublic
Actions

Authored by atul on Jan 18 2024, 1:30 PM.

Tags

None

Referenced Files

	F1799816: D10725.id36289.diff
	Mon, May 20, 4:29 AM

	F1799815: D10725.id36208.diff
	Mon, May 20, 4:29 AM

	F1799814: D10725.id36074.diff
	Mon, May 20, 4:29 AM

	F1799813: D10725.id35850.diff
	Mon, May 20, 4:29 AM

	F1799808: D10725.id.diff
	Mon, May 20, 4:29 AM

	F1799807: D10725.diff
	Mon, May 20, 4:29 AM

	Unknown Object (File)
	Apr 8 2024, 12:06 PM

	Unknown Object (File)
	Mar 16 2024, 6:26 AM

View All 28 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMM23b646b949de: [lib] Remove unused utilities and validators

Summary

Part of ENG-6366 : Rename MinimallyEncodedRawThreadInfo to RawThreadInfo

Noticed a coouple of functions were completely unused and could be removed. Flipped on "Unused function" inspection in my IDE and found a ton of similar functions throughout the codebase, but just addressing the ones in files I'm working with right now.

Depends on D10724

Test Plan

None of these were used anywhere, flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jan 18 2024, 1:30 PM

atul added a child revision: D10726: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`.Jan 18 2024, 1:43 PM

Harbormaster completed remote builds in B25928: Diff 35850.Jan 18 2024, 1:49 PM

atul requested review of this revision.Jan 18 2024, 1:49 PM

ashoat accepted this revision.Jan 21 2024, 9:41 PM

This revision is now accepted and ready to land.Jan 21 2024, 9:41 PM

rebaser

Harbormaster failed remote builds in B26103: Diff 36074!Jan 23 2024, 2:49 PM

rebase

Harbormaster completed remote builds in B26215: Diff 36208.Jan 27 2024, 12:19 AM

Double checked that there were no import issues before landing.

Closed by commit rCOMM23b646b949de: [lib] Remove unused utilities and validators (authored by atul). · Explain WhyJan 29 2024, 9:32 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM23b646b949de: [lib] Remove unused utilities and validators.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

minimally-encoded-thread-permissions-validators.js

8 lines

shared/

thread-utils.js

10 lines

types/

minimally-encoded-thread-permissions-types.js

29 lines

Diff 36289

lib/permissions/minimally-encoded-thread-permissions-validators.js

Loading...

lib/shared/thread-utils.js

Loading...

lib/types/minimally-encoded-thread-permissions-types.js

Loading...