Page MenuHomePhabricator

[lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`
ClosedPublic

Authored by atul on Jan 11 2024, 8:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 1:40 PM
Unknown Object (File)
Wed, Oct 30, 1:06 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Subscribers
None

Details

Summary

Followup to D10588. This is the first step in removing the invariant inside the

action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === registerActionTypes.success ||
action.type === fullStateSyncActionType

condition.


Depends on D10588

Test Plan

N/A, trusting flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2024, 9:10 AM
Harbormaster failed remote builds in B25700: Diff 35540!

separate out ClientLogInResponse and ServerLogInResponse to address flow issue in keyserver (not sure why it didn't get caught pre-commit)

atul published this revision for review.Jan 11 2024, 9:44 AM
ashoat added inline comments.
lib/types/account-types.js
158–161 ↗(On Diff #35550)

We should make sure cookieChange is read-only

Note: the + shorthand will not work here because of the type spread operator

This revision is now accepted and ready to land.Jan 11 2024, 9:49 AM

make cookieChange readonly