Page MenuHomePhabricator
Differential D10675

[web] Remove all instances of `LegacyThreadInfo` from `web`
ClosedPublic
Actions

Authored by atul on Jan 17 2024, 3:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 1:00 PM
Unknown Object (File)
Fri, Mar 14, 7:36 AM
Unknown Object (File)
Sat, Mar 1, 2:59 PM
Unknown Object (File)
Sat, Mar 1, 6:11 AM
Unknown Object (File)
Feb 21 2025, 11:55 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMMc1e3ee4ceae4: [web] Remove all instances of `LegacyThreadInfo` from `web`
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

Depends on D10674

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jan 17 2024, 3:31 PM
atul published this revision for review.Jan 17 2024, 3:32 PM
ashoat accepted this revision.Jan 17 2024, 3:39 PM
This revision is now accepted and ready to land.Jan 17 2024, 3:39 PM
atul added a child revision: D10676: [native] Remove all instances of `LegacyThreadInfo` from `native`.Jan 17 2024, 3:50 PM
Harbormaster completed remote builds in B25851: Diff 35744.Jan 17 2024, 3:51 PM
atul updated this revision to Diff 36015.Jan 22 2024, 1:24 PM

rebase

Harbormaster completed remote builds in B26065: Diff 36015.Jan 22 2024, 1:43 PM
atul updated this revision to Diff 36053.Jan 23 2024, 12:59 PM

rebase

atul updated this revision to Diff 36059.Jan 23 2024, 1:16 PM

remove extraneous import changes

Harbormaster completed remote builds in B26089: Diff 36053.Jan 23 2024, 1:19 PM
Harbormaster completed remote builds in B26095: Diff 36059.Jan 23 2024, 1:35 PM
Closed by commit rCOMMc1e3ee4ceae4: [web] Remove all instances of `LegacyThreadInfo` from `web` (authored by atul). · Explain WhyJan 23 2024, 1:43 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc1e3ee4ceae4: [web] Remove all instances of `LegacyThreadInfo` from `web`.

Revision Contents
Changeset List

PathSize
web/
avatars/
3 lines
3 lines
3 lines
3 lines
calendar/
3 lines
chat/
3 lines
3 lines
5 lines
3 lines
relationship-prompt/
3 lines
3 lines
input/
28 lines
10 lines
invite-links/
manage/
3 lines
markdown/
7 lines
modals/
search/
3 lines
threads/
create/
steps/
9 lines
gallery/
3 lines
members/
7 lines
7 lines
7 lines
settings/
3 lines
3 lines
7 lines
7 lines
7 lines
user-profile/
3 lines
3 lines
3 lines
roles/
9 lines
7 lines
3 lines
3 lines
3 lines
selectors/
3 lines
9 lines
sidebar/
3 lines
3 lines
3 lines
3 lines
tooltips/
3 lines

Diff 36064

View Options

web/avatars/edit-thread-avatar-menu.react.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

web/avatars/edit-thread-avatar.react.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

web/avatars/thread-avatar.react.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

web/avatars/thread-emoji-avatar-selection-modal.react.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

web/calendar/day.react.js

Loading...
View Options

web/chat/chat-thread-list-item-menu.react.js

Loading...
View Options

web/chat/chat-thread-list-see-more-sidebars.react.js

Loading...
View Options

web/chat/inline-engagement.react.js

Loading...
View Options

web/chat/message-preview.react.js

Loading...
View Options

web/chat/relationship-prompt/relationship-prompt.js

Loading...
View Options

web/chat/robotext-message.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/input/input-state.js

Loading...
View Options

web/invite-links/manage/edit-link-modal.react.js

Loading...
View Options

web/markdown/rules.react.js

Loading...
View Options

web/modals/search/message-search-utils.react.js

Loading...
View Options

web/modals/threads/create/steps/subchannel-members-list.react.js

Loading...
View Options

web/modals/threads/gallery/thread-settings-media-gallery.react.js

Loading...
View Options

web/modals/threads/members/change-member-role-modal.react.js

Loading...
View Options

web/modals/threads/members/member.react.js

Loading...
View Options

web/modals/threads/members/members-list.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-confirmation-modal.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-modal.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Loading...
View Options

web/modals/user-profile/user-profile-action-buttons.react.js

Loading...
View Options

web/modals/user-profile/user-profile-menu.react.js

Loading...
View Options

web/modals/user-profile/user-profile-message-button.react.js

Loading...
View Options

web/roles/community-roles-modal.react.js

Loading...
View Options

web/roles/create-roles-modal.react.js

Loading...
View Options

web/roles/delete-role-modal.react.js

Loading...
View Options

web/roles/role-actions-menu.react.js

Loading...
View Options

web/roles/role-panel-entry.react.js

Loading...
View Options

web/selectors/calendar-selectors.js

Loading...
View Options

web/selectors/thread-selectors.js

Loading...
View Options

web/sidebar/community-drawer-item-community-handlers.react.js

Loading...
View Options

web/sidebar/community-drawer-item-handlers.react.js

Loading...
View Options

web/sidebar/community-drawer-utils.react.js

Loading...
View Options

web/sidebar/subchannels-button.react.js

Loading...
View Options

web/tooltips/message-tooltip.react.js

Loading...