Page MenuHomePhabricator

[lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`
ClosedPublic

Authored by atul on Jan 11 2024, 9:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 24, 6:28 AM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Mon, Oct 14, 6:28 PM
Subscribers
None

Details

Summary

Similar to D10606, but for registration.


Depends on D10606

Test Plan

N/A, trusting flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2024, 9:20 AM
Harbormaster failed remote builds in B25702: Diff 35543!
atul published this revision for review.Jan 11 2024, 9:44 AM
atul planned changes to this revision.
ashoat added inline comments.
lib/types/account-types.js
71–77 ↗(On Diff #35552)

We should always convert types like this to read-only when we touch them. Can you try and see if it introduces any errors?

address feedback (make readonly)

This revision is now accepted and ready to land.Jan 12 2024, 11:45 PM
This revision was landed with ongoing or failed builds.Jan 14 2024, 4:23 PM
This revision was automatically updated to reflect the committed changes.