Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMM874cc72b1f49: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo |…

Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

Just like the rest of the stack we're going to expand RelativeMemberInfo and remove the Legacy* variant wherever possible.

Depends on D10725

Test Plan

flow, this was simple IDE "Inline alias..." refactor

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jan 18 2024, 9:43 PM

atul added a child revision: D10727: [lib] First pass at removing `LegacyRelativeMemberInfo` from `lib`.Jan 18 2024, 9:56 PM

Harbormaster completed remote builds in B25929: Diff 35851.Jan 18 2024, 10:02 PM

atul requested review of this revision.Jan 18 2024, 10:02 PM

ashoat accepted this revision.Jan 22 2024, 5:44 AM

ashoat added inline comments.

lib/selectors/thread-selectors.js
28 ↗	(On Diff #35851)	Please revert import ordering changes before landing

This revision is now accepted and ready to land.Jan 22 2024, 5:44 AM

rebase

Harbormaster completed remote builds in B26104: Diff 36075.Jan 23 2024, 11:13 PM

resolve merge conflicts

Harbormaster completed remote builds in B26262: Diff 36290.Jan 29 2024, 5:56 PM

re-introduce fixes

Double checked imports before landing.

Harbormaster completed remote builds in B26263: Diff 36291.Jan 29 2024, 6:21 PM

Closed by commit rCOMM874cc72b1f49: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo |…. · Explain WhyJan 29 2024, 7:54 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM874cc72b1f49: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo |….

Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 36293

lib/selectors/nav-selectors.js

lib/selectors/thread-selectors.js

lib/selectors/user-selectors.js

lib/shared/markdown.js

lib/shared/mention-utils.js

lib/shared/thread-utils.js

lib/types/thread-types.js

lib/utils/role-utils.js

native/chat/chat-input-bar.react.js

native/chat/settings/thread-settings-member-tooltip-modal.react.js

native/chat/settings/thread-settings-member.react.js

native/chat/settings/thread-settings.react.js

native/roles/change-roles-screen.react.js

web/input/input-state.js

web/modals/threads/create/steps/subchannel-members-list.react.js

web/modals/threads/members/change-member-role-modal.react.js

web/modals/threads/members/member.react.js

web/modals/threads/members/members-list.react.js

web/modals/threads/members/members-modal.react.js

Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36293

lib/selectors/nav-selectors.js

lib/selectors/thread-selectors.js

lib/selectors/user-selectors.js

lib/shared/markdown.js

lib/shared/mention-utils.js

lib/shared/thread-utils.js

lib/types/thread-types.js

lib/utils/role-utils.js

native/chat/chat-input-bar.react.js

native/chat/settings/thread-settings-member-tooltip-modal.react.js

native/chat/settings/thread-settings-member.react.js

native/chat/settings/thread-settings.react.js

native/roles/change-roles-screen.react.js

web/input/input-state.js

web/modals/threads/create/steps/subchannel-members-list.react.js

web/modals/threads/members/change-member-role-modal.react.js

web/modals/threads/members/member.react.js

web/modals/threads/members/members-list.react.js

web/modals/threads/members/members-modal.react.js

Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`
ClosedPublic
Actions

Revision Contents
Changeset List