Page MenuHomePhabricator

[lib] Rename `RawThreadInfos` to `MixedRawThreadInfos`
ClosedPublic

Authored by atul on Jan 15 2024, 10:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 4:52 AM
Unknown Object (File)
Mon, Nov 4, 7:40 AM
Unknown Object (File)
Oct 20 2024, 3:39 AM
Unknown Object (File)
Oct 19 2024, 6:11 PM
Unknown Object (File)
Oct 16 2024, 1:34 AM
Unknown Object (File)
Oct 16 2024, 1:34 AM
Unknown Object (File)
Oct 16 2024, 1:34 AM
Unknown Object (File)
Oct 16 2024, 1:34 AM
Subscribers
None

Details

Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

New type looks like:

export type MixedRawThreadInfos = {
  +[id: string]: LegacyRawThreadInfo | RawThreadInfo,
};

which is slightly different than

LegacyRawThreadInfos | MinimallyEncodedRawThreadInfos because it allows values of both types.

However, we should be able to now replace most instances of MixedRawThreadInfos with LegacyRawThreadInfos | MinimallyEncodedRawThreadInfos. I think we only really will need MixedRawThreadInfos when we're working with SQLite store that may contain either (eg in case we're upgrading from an old version and applying migrations before encoding change).


Depends on D10634

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable