[lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-utils`
ClosedPublic
Actions

Authored by atul on Jan 15 2024, 1:11 PM.

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMMaadf73d8ac7d: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in…

Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

Similarly to D10640, initially had issues with this file so decided to address in separate diff from D10639. However, it looks like I must've made some mistake initially because there are no longer any flow issues.

Depends on D10640

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jan 15 2024, 1:11 PM

Harbormaster completed remote builds in B25780: Diff 35643.Jan 15 2024, 1:31 PM

atul requested review of this revision.Jan 15 2024, 1:31 PM

atul added a child revision: D10642: [lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo`.Jan 15 2024, 1:33 PM

ashoat accepted this revision.Jan 15 2024, 5:42 PM

This revision is now accepted and ready to land.Jan 15 2024, 5:42 PM

rebase

This revision was landed with ongoing or failed builds.Jan 22 2024, 12:36 PM

Closed by commit rCOMMaadf73d8ac7d: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMaadf73d8ac7d: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in….

Harbormaster completed remote builds in B26051: Diff 35994.Jan 22 2024, 12:41 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

186 lines

Diff 36002

View Options

lib/shared/thread-utils.js

[lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-utils`ClosedPublicActions