Differential D10812 Authored by atul on Jan 24 2024, 10:47 PM.
Details Summary Part of https://linear.app/comm/issue/ENG-5796/update-usedisconnectedbarvisibilityhandler Basically we want to maintain the functionality that determines whether a keyserver is reachable, but we want to rename things so they're no disconnected bar sepcific (which will now display or not display based on general network connectivity). Will need to make some Redux changes as well. Depends on D10811 Test Plan NA, flow Manually killed/started local keyserver a few times and ensured that Redux state updated as expected.
Diff Detail
Event TimelineHarbormaster completed remote builds in B26149: Diff 36125.Jan 24 2024, 11:06 PM2024-01-24 23:06:38 (UTC-8) This revision now requires changes to proceed.Jan 25 2024, 3:00 AM2024-01-25 03:00:25 (UTC-8) atul edited the test plan for this revision. (Show Details)Jan 25 2024, 11:39 AM2024-01-25 11:39:14 (UTC-8) This revision is now accepted and ready to land.Jan 26 2024, 2:09 AM2024-01-26 02:09:27 (UTC-8) Harbormaster completed remote builds in B26290: Diff 36330.Jan 29 2024, 3:39 PM2024-01-29 15:39:11 (UTC-8) Closed by commit rCOMMb15b192fc625: Rename `useDisconnectedBarVisibilityHandler` to… (authored by atul). · Explain WhyJan 29 2024, 7:16 PM2024-01-29 19:16:01 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 36341 |