Page MenuHomePhabricator
Differential D10812

Rename `useDisconnectedBarVisibilityHandler` to `useKeyserverReachabilityHandler`
ClosedPublic
Actions

Authored by atul on Jan 24 2024, 10:47 PM.
Tags
None
Referenced Files
F3351358: D10812.diff
Sat, Nov 23, 1:11 AM
Unknown Object (File)
Fri, Nov 15, 7:37 AM
Unknown Object (File)
Thu, Nov 7, 3:51 AM
Unknown Object (File)
Oct 15 2024, 10:07 PM
Unknown Object (File)
Oct 15 2024, 10:07 PM
Unknown Object (File)
Oct 15 2024, 10:07 PM
Unknown Object (File)
Oct 15 2024, 10:06 PM
Unknown Object (File)
Oct 15 2024, 10:06 PM
View All 51 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMMb15b192fc625: Rename `useDisconnectedBarVisibilityHandler` to…
Summary

Part of https://linear.app/comm/issue/ENG-5796/update-usedisconnectedbarvisibilityhandler

Basically we want to maintain the functionality that determines whether a keyserver is reachable, but we want to rename things so they're no disconnected bar sepcific (which will now display or not display based on general network connectivity).

Will need to make some Redux changes as well.

Depends on D10811

Test Plan

NA, flow

Manually killed/started local keyserver a few times and ensured that Redux state updated as expected.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 24 2024, 10:47 PM
Harbormaster completed remote builds in B26149: Diff 36125.Jan 24 2024, 11:06 PM
atul requested review of this revision.Jan 24 2024, 11:06 PM
tomek requested changes to this revision.Jan 25 2024, 3:00 AM

This diff should have a meaningful test plan

This revision now requires changes to proceed.Jan 25 2024, 3:00 AM
atul added a child revision: D10818: [lib] Add `threadInfoFromRawThreadInfo` test to `thread-utils.test`.Jan 25 2024, 11:18 AM
atul requested review of this revision.Jan 25 2024, 11:38 AM

Updated Test Plan

atul edited the test plan for this revision. (Show Details)Jan 25 2024, 11:39 AM
ashoat accepted this revision.Jan 25 2024, 5:49 PM
tomek accepted this revision.Jan 26 2024, 2:09 AM
This revision is now accepted and ready to land.Jan 26 2024, 2:09 AM
atul updated this revision to Diff 36330.Jan 29 2024, 3:15 PM

rebase

Harbormaster completed remote builds in B26290: Diff 36330.Jan 29 2024, 3:39 PM
Closed by commit rCOMMb15b192fc625: Rename `useDisconnectedBarVisibilityHandler` to… (authored by atul). · Explain WhyJan 29 2024, 7:16 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb15b192fc625: Rename `useDisconnectedBarVisibilityHandler` to….

Revision Contents
Changeset List

Diff 36330

View Options

lib/hooks/disconnected-bar.js

Loading...
View Options

lib/hooks/keyserver-reachability.js

Loading...
View Options

native/navigation/disconnected-bar-visibility-handler.react.js

Loading...
View Options

native/navigation/keyserver-reachability-handler.js

Loading...
View Options

native/root.react.js

Loading...
View Options

web/app.react.js

Loading...
View Options

web/redux/disconnected-bar-visibility-handler.js

Loading...
View Options

web/redux/disconnected-bar.js

Loading...
View Options

web/redux/keyserver-reachability-handler.js

Loading...