Page MenuHomePhabricator
Differential D10645

[lib] First pass at removing `LegacyThreadInfo` from `chat-selectors`
ClosedPublic
Actions

Authored by atul on Jan 15 2024, 2:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 1:39 PM
Unknown Object (File)
Sat, Mar 29, 5:55 AM
Unknown Object (File)
Sun, Mar 23, 9:33 PM
Unknown Object (File)
Sun, Mar 23, 9:33 PM
Unknown Object (File)
Sun, Mar 23, 9:33 PM
Unknown Object (File)
Sun, Mar 23, 9:32 PM
Unknown Object (File)
Sun, Mar 23, 9:32 PM
Unknown Object (File)
Tue, Mar 18, 1:44 AM
View All 99 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMMdf18b2bb378c: [lib] First pass at removing `LegacyThreadInfo` from `chat-selectors`
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

We can't remove them all because we'll need to address thread-utils first. Will do that next.

Depends on D10644

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
selectors/
18 lines

Diff 36017

View Options

lib/selectors/chat-selectors.js

Show All 14 Linesimport {
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { import {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Linesclass App extends React.PureComponent<Props> {
render(): React.Node { render(): React.Node {
let content; let content;
if (this.props.loggedIn) { if (this.props.loggedIn) {
content = ( content = (
<> <>
<WebEditThreadAvatarProvider> <WebEditThreadAvatarProvider>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<StaffContextProvider>
{this.renderMainContent()} {this.renderMainContent()}
{this.props.modals} {this.props.modals}
</StaffContextProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</WebEditThreadAvatarProvider> </WebEditThreadAvatarProvider>
</> </>
); );
} else { } else {
content = ( content = (
<> <>
{this.renderLoginPage()} {this.renderLoginPage()}
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines